bgpd: fix bgp_best_selection heap-use-after-free #14894
Execution finished at mininet2502 after 1195.563 seconds
Bamboo CI Link
Execution details at https://ci1.netdef.org/browse/FRR-PULLREQ3-TOPO5DEB10AMD64-847
Execution Summary
Failures
All tests passed
Success and Not classified
✔️ bgp_max_med_on_startup.test_bgp_max_med_on_startup test_bgp_max_med_on_startup (10.236 s)
✔️ bgp_maximum_prefix_invalid_update.test_bgp_maximum_prefix_invalid_update test_bgp_maximum_prefix_invalid (4.735 s)
✔️ bgp_maximum_prefix_out.test_bgp_maximum_prefix_out test_bgp_maximum_prefix_out (23.059 s)
✔️ bgp_minimum_holdtime.test_bgp_minimum_holdtime test_bgp_minimum_holdtime (4.923 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_address_unambiguous_within_each_vrf_p0 (28.416 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_ambiguous_overlapping_addresses_in_different_vrfs_p0 (3.353 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_static_routes_associated_to_specific_vrfs_p0 (3.910 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_vrf_with_unique_physical_interface_p0 (5.974 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_prefixes_leaking_p0 (6.325 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_static_routes_advertised_within_specific_vrf_p0 (5.564 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_end_to_end_traffic_isolation_p0 (31.228 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_static_routes_for_inter_vrf_route_leaking_p0 (3.230 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_inter_vrf_and_intra_vrf_communication_iBGP_p0 (2.769 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_inter_vrf_and_intra_vrf_communication_eBGP_p0 (2.917 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_route_map_within_vrf_to_alter_bgp_attribute_nexthop_p0 (6.806 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_route_map_within_vrf_to_alter_bgp_attribute_p0[locPrf] (14.641 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_route_map_within_vrf_to_alter_bgp_attribute_p0[weight] (14.909 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_route_map_within_vrf_to_alter_bgp_attribute_p0[metric] (14.546 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_route_map_within_vrf_to_alter_bgp_attribute_aspath_p0 (15.150 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_route_map_within_vrf_to_alter_bgp_attribute_lcomm_p0 (4.653 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_route_map_match_traffic_based_on_vrf_p0 (7.677 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_vrf_lite_with_static_bgp_originated_routes_p0 (12.840 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_prefix_list_to_permit_deny_prefixes_p0 (7.643 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_route_map_set_and_match_tag_p0 (3.590 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_route_map_set_and_match_metric_p0 (3.426 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_route_map_set_and_match_community_p0 (8.367 s)
✔️ bgp_multi_vrf_topo2.test_bgp_multi_vrf_topo2 test_vrf_with_multiple_links_p1 (104.743 s)
✔️ bgp_multi_vrf_topo2.test_bgp_multi_vrf_topo2 test_shut_noshut_p1 (34.404 s)
✔️ bgp_multi_vrf_topo2.test_bgp_multi_vrf_topo2 test_vrf_vlan_routing_table_p1 (25.090 s)
✔️ bgp_multi_vrf_topo2.test_bgp_multi_vrf_topo2 test_vrf_route_leaking_next_hop_interface_flapping_p1 (4.437 s)
✔️ bgp_multi_vrf_topo2.test_bgp_multi_vrf_topo2 test_restart_bgpd_daemon_p1 (11.569 s)
✔️ bgp_multi_vrf_topo2.test_bgp_multi_vrf_topo2 test_delete_and_re_add_vrf_p1 (40.191 s)
✔️ bgp_multi_vrf_topo2.test_bgp_multi_vrf_topo2 test_vrf_name_significance_p1 (64.090 s)
✔️ bgp_multi_vrf_topo2.test_bgp_multi_vrf_topo2 test_restart_frr_services_p1 (15.072 s)
✔️ bgp_multiview_topo1.test_bgp_multiview_topo1 test_router_running (7.252 s)
✔️ bgp_multiview_topo1.test_bgp_multiview_topo1 test_bgp_converge (10.449 s)
✔️ bgp_multiview_topo1.test_bgp_multiview_topo1 test_bgp_routingTable (0.342 s)
/root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ3-TOPO5DEB10AMD64/topotests/bgp_multiview_topo1/test_bgp_multiview_topo1.py:216: Memory leak test/report is disabled
✔️ bgp_multiview_topo1.test_bgp_multiview_topo1 test_shutdown_check_memleak (1.200 s)
✔️ bgp_multiview_topo1.test_bgp_multiview_topo1 test_shutdown_check_memleak (1.200 s)
✔️ bgp_path_attribute_discard.test_bgp_path_attribute_discard test_bgp_path_attribute_discard (5.823 s)
/root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ3-TOPO5DEB10AMD64/topotests/bgp_path_attribute_discard/test_bgp_path_attribute_discard.py:147: Memory leak test/report is disabled
✔️ bgp_path_attribute_discard.test_bgp_path_attribute_discard test_memory_leak (0.478 s)
✔️ bgp_path_attribute_discard.test_bgp_path_attribute_discard test_memory_leak (0.478 s)
✔️ bgp_path_attribute_treat_as_withdraw.test_bgp_path_attribute_treat_as_withdraw test_bgp_path_attribute_treat_as_withdraw (7.800 s)
/root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ3-TOPO5DEB10AMD64/topotests/bgp_path_attribute_treat_as_withdraw/test_bgp_path_attribute_treat_as_withdraw.py:142: Memory leak test/report is disabled
✔️ bgp_path_attribute_treat_as_withdraw.test_bgp_path_attribute_treat_as_withdraw test_memory_leak (1.822 s)
✔️ bgp_path_attribute_treat_as_withdraw.test_bgp_path_attribute_treat_as_withdraw test_memory_leak (1.822 s)
✔️ bgp_path_attributes_topo1.test_bgp_path_attributes test_next_hop_attribute (20.934 s)
✔️ bgp_path_attributes_topo1.test_bgp_path_attributes test_aspath_attribute (12.672 s)
✔️ bgp_path_attributes_topo1.test_bgp_path_attributes test_localpref_attribute (12.574 s)
✔️ bgp_path_attributes_topo1.test_bgp_path_attributes test_weight_attribute (12.869 s)
✔️ bgp_path_attributes_topo1.test_bgp_path_attributes test_origin_attribute (7.265 s)
✔️ bgp_path_attributes_topo1.test_bgp_path_attributes test_med_attribute (14.570 s)
✔️ bgp_path_attributes_topo1.test_bgp_path_attributes test_admin_distance (16.825 s)
✔️ bgp_path_selection.test_bgp_path_selection test_bgp_path_selection_ecmp (6.120 s)
✔️ bgp_path_selection.test_bgp_path_selection test_bgp_path_selection_vpn_ecmp (1.998 s)
✔️ bgp_path_selection.test_bgp_path_selection test_bgp_path_selection_metric (0.258 s)
✔️ bgp_path_selection.test_bgp_path_selection test_bgp_path_selection_vpn_metric (2.158 s)
✔️ bgp_peer_graceful_shutdown.test_bgp_peer_graceful_shutdown test_bgp_orf (7.980 s)
✔️ bgp_peer_group.test_bgp_peer-group test_bgp_peer_group (7.708 s)
✔️ bgp_peer_type_multipath_relax.test_bgp_peer-type_multipath-relax test_bgp_peer_type_multipath_relax (18.956 s)
/root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ3-TOPO5DEB10AMD64/topotests/bgp_peer_type_multipath_relax/test_bgp_peer-type_multipath-relax.py:365: Memory leak test/report is disabled
✔️ bgp_peer_type_multipath_relax.test_bgp_peer-type_multipath-relax test_memory_leak (0.667 s)
✔️ bgp_peer_type_multipath_relax.test_bgp_peer-type_multipath-relax test_memory_leak (0.667 s)
✔️ bgp_prefix_list_any.test_bgp_prefix_list_any test_bgp_route_map_prefix_list (19.988 s)
✔️ bgp_prefix_list_topo1.test_prefix_lists test_ip_prefix_lists_in_permit (11.864 s)
✔️ bgp_prefix_list_topo1.test_prefix_lists test_ip_prefix_lists_out_permit (3.666 s)
✔️ bgp_prefix_list_topo1.test_prefix_lists test_ip_prefix_lists_in_deny_and_permit_any (1.249 s)
✔️ bgp_prefix_list_topo1.test_prefix_lists test_delete_prefix_lists (1.249 s)
✔️ bgp_prefix_list_topo1.test_prefix_lists test_ip_prefix_lists_out_deny_and_permit_any (3.664 s)
✔️ bgp_prefix_list_topo1.test_prefix_lists test_modify_prefix_lists_in_permit_to_deny (9.955 s)
✔️ bgp_prefix_list_topo1.test_prefix_lists test_modify_prefix_lists_in_deny_to_permit (10.180 s)
✔️ bgp_prefix_list_topo1.test_prefix_lists test_modify_prefix_lists_out_permit_to_deny (9.983 s)
✔️ bgp_prefix_list_topo1.test_prefix_lists test_modify_prefix_lists_out_deny_to_permit (9.996 s)
✔️ bgp_prefix_list_topo1.test_prefix_lists test_ip_prefix_lists_implicit_deny (6.273 s)
✔️ bgp_prefix_list_topo1.test_prefix_modify test_bug_prefix_lists_deny_to_permit_p1 (34.923 s)
✔️ bgp_prefix_sid.test_bgp_prefix_sid test_r1_receive_and_advertise_prefix_sid_type1 (7.780 s)
✔️ bgp_prefix_sid.test_bgp_prefix_sid test_peer2_receive_prefix_sid_type1 (1.992 s)
✔️ bgp_prefix_sid2.test_bgp_prefix_sid2 test_r1_rib (6.514 s)
✔️ bgp_recursive_route_ebgp_multi_hop.test_bgp_recursive_route_ebgp_multi_hop test_recursive_routes_iBGP_peer_p1 (30.450 s)
✔️ bgp_recursive_route_ebgp_multi_hop.test_bgp_recursive_route_ebgp_multi_hop test_next_hop_as_self_ip_p1 (18.949 s)
✔️ bgp_recursive_route_ebgp_multi_hop.test_bgp_recursive_route_ebgp_multi_hop test_next_hop_with_recursive_lookup_p1 (48.279 s)
✔️ bgp_recursive_route_ebgp_multi_hop.test_bgp_recursive_route_ebgp_multi_hop test_BGP_path_attributes_default_values_p1 (11.710 s)
✔️ bgp_recursive_route_ebgp_multi_hop.test_bgp_recursive_route_ebgp_multi_hop test_BGP_peering_bw_loopback_and_physical_p1 (21.028 s)
✔️ bgp_recursive_route_ebgp_multi_hop.test_bgp_recursive_route_ebgp_multi_hop test_BGP_active_standby_preemption_and_ecmp_p1 (21.800 s)
✔️ bgp_recursive_route_ebgp_multi_hop.test_bgp_recursive_route_ebgp_multi_hop test_password_authentication_for_eBGP_and_iBGP_peers_p1 (22.063 s)
✔️ bgp_redistribute_table.test_bgp_redistribute_table test_step1_protocols_convergence (4.708 s)
✔️ bgp_redistribute_table.test_bgp_redistribute_table test_step2_add_kernel_route_on_table_2200 (0.303 s)
✔️ bgp_redistribute_table.test_bgp_redistribute_table test_step3_remove_kernel_route_on_table_2200 (0.365 s)
✔️ bgp_redistribute_table.test_bgp_redistribute_table test_step4_add_kernel_route_on_table_2200 (0.299 s)
✔️ bgp_redistribute_table.test_bgp_redistribute_table test_step5_no_redistribute_table_2200 (0.432 s)
✔️ bgp_redistribute_table.test_bgp_redistribute_table test_step6_redistribute_table_2200 (0.420 s)
✔️ bgp_redistribute_table.test_bgp_redistribute_table test_step7_reset_bgp_instance_add_kernel_route_and_add_bgp (2.750 s)
/root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ3-TOPO5DEB10AMD64/topotests/bgp_redistribute_table/test_bgp_redistribute_table.py:299: Memory leak test/report is disabled
✔️ bgp_redistribute_table.test_bgp_redistribute_table test_memory_leak (1.821 s)
✔️ bgp_redistribute_table.test_bgp_redistribute_table test_memory_leak (1.821 s)
✔️ bgp_reject_as_sets.test_bgp_reject_as_sets test_bgp_reject_as_sets (7.382 s)
✔️ bgp_remove_private_as.test_bgp_remove_private_as test_bgp_remove_private_as (18.839 s)
✔️ bgp_remove_private_as_route_map.test_bgp_remove_private_as_route_map test_bgp_remove_private_as_route_map (10.526 s)
✔️ bgp_rfapi_basic_sanity.test_bgp_rfapi_basic_sanity test_add_routes (7.840 s)
✔️ bgp_rfapi_basic_sanity.test_bgp_rfapi_basic_sanity test_adjacencies (13.604 s)
✔️ bgp_rfapi_basic_sanity.test_bgp_rfapi_basic_sanity test_check_routes (1.670 s)
✔️ bgp_rfapi_basic_sanity.test_bgp_rfapi_basic_sanity test_check_close (0.851 s)
✔️ bgp_rfapi_basic_sanity.test_bgp_rfapi_basic_sanity test_check_timeout (0.332 s)
✔️ bgp_rfapi_basic_sanity.test_bgp_rfapi_basic_sanity test_cleanup_all (1.332 s)
/root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ3-TOPO5DEB10AMD64/topotests/lib/ltemplate.py:197: Memory leak test/report is disabled
✔️ bgp_rfapi_basic_sanity.test_bgp_rfapi_basic_sanity test_memory_leak (2.553 s)
✔️ bgp_rfapi_basic_sanity.test_bgp_rfapi_basic_sanity test_memory_leak (2.553 s)
✔️ bgp_rfapi_basic_sanity_config2.test_bgp_rfapi_basic_sanity_config2 test_add_routes (8.705 s)
✔️ bgp_rfapi_basic_sanity_config2.test_bgp_rfapi_basic_sanity_config2 test_adjacencies (17.074 s)
✔️ bgp_rfapi_basic_sanity_config2.test_bgp_rfapi_basic_sanity_config2 test_check_routes (1.582 s)
✔️ bgp_rfapi_basic_sanity_config2.test_bgp_rfapi_basic_sanity_config2 test_check_close (0.885 s)
✔️ bgp_rfapi_basic_sanity_config2.test_bgp_rfapi_basic_sanity_config2 test_check_timeout (0.301 s)
✔️ bgp_rfapi_basic_sanity_config2.test_bgp_rfapi_basic_sanity_config2 test_cleanup_all (1.390 s)
/root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ3-TOPO5DEB10AMD64/topotests/lib/ltemplate.py:197: Memory leak test/report is disabled
✔️ bgp_rfapi_basic_sanity_config2.test_bgp_rfapi_basic_sanity_config2 test_memory_leak (2.085 s)
✔️ bgp_rfapi_basic_sanity_config2.test_bgp_rfapi_basic_sanity_config2 test_memory_leak (2.085 s)
✔️ bgp_route_aggregation.test_bgp_aggregation test_route_summarisation_with_summary_only_p1 (26.323 s)
✔️ bgp_route_aggregation.test_bgp_aggregation test_route_summarisation_with_as_set_p1 (16.367 s)