bgpd: fix bgp_best_selection heap-use-after-free #14894
Execution finished at ci07-FRR-PULLREQ3-TOPO5U18ARM8-847 after 1767.084 seconds
Bamboo CI Link
Execution details at https://ci1.netdef.org/browse/FRR-PULLREQ3-TOPO5U18ARM8-847
Execution Summary
Failures
All tests passed
Success and Not classified
✔️ bgp_max_med_on_startup.test_bgp_max_med_on_startup test_bgp_max_med_on_startup (113.543 s)
✔️ bgp_maximum_prefix_invalid_update.test_bgp_maximum_prefix_invalid_update test_bgp_maximum_prefix_invalid (14.083 s)
✔️ bgp_maximum_prefix_out.test_bgp_maximum_prefix_out test_bgp_maximum_prefix_out (29.665 s)
✔️ bgp_minimum_holdtime.test_bgp_minimum_holdtime test_bgp_minimum_holdtime (5.496 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_address_unambiguous_within_each_vrf_p0 (185.072 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_ambiguous_overlapping_addresses_in_different_vrfs_p0 (4.340 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_static_routes_associated_to_specific_vrfs_p0 (4.644 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_vrf_with_unique_physical_interface_p0 (4.430 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_prefixes_leaking_p0 (4.929 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_static_routes_advertised_within_specific_vrf_p0 (4.078 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_end_to_end_traffic_isolation_p0 (29.294 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_static_routes_for_inter_vrf_route_leaking_p0 (34.533 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_inter_vrf_and_intra_vrf_communication_iBGP_p0 (30.867 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_inter_vrf_and_intra_vrf_communication_eBGP_p0 (23.428 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_route_map_within_vrf_to_alter_bgp_attribute_nexthop_p0 (5.386 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_route_map_within_vrf_to_alter_bgp_attribute_p0[locPrf] (12.370 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_route_map_within_vrf_to_alter_bgp_attribute_p0[weight] (12.329 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_route_map_within_vrf_to_alter_bgp_attribute_p0[metric] (12.407 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_route_map_within_vrf_to_alter_bgp_attribute_aspath_p0 (12.448 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_route_map_within_vrf_to_alter_bgp_attribute_lcomm_p0 (4.844 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_route_map_match_traffic_based_on_vrf_p0 (6.166 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_vrf_lite_with_static_bgp_originated_routes_p0 (11.088 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_prefix_list_to_permit_deny_prefixes_p0 (6.121 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_route_map_set_and_match_tag_p0 (4.388 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_route_map_set_and_match_metric_p0 (4.101 s)
✔️ bgp_multi_vrf_topo1.test_bgp_multi_vrf_topo1 test_route_map_set_and_match_community_p0 (52.023 s)
✔️ bgp_multi_vrf_topo2.test_bgp_multi_vrf_topo2 test_vrf_with_multiple_links_p1 (251.509 s)
✔️ bgp_multi_vrf_topo2.test_bgp_multi_vrf_topo2 test_shut_noshut_p1 (36.301 s)
✔️ bgp_multi_vrf_topo2.test_bgp_multi_vrf_topo2 test_vrf_vlan_routing_table_p1 (24.413 s)
✔️ bgp_multi_vrf_topo2.test_bgp_multi_vrf_topo2 test_vrf_route_leaking_next_hop_interface_flapping_p1 (3.285 s)
✔️ bgp_multi_vrf_topo2.test_bgp_multi_vrf_topo2 test_restart_bgpd_daemon_p1 (9.823 s)
✔️ bgp_multi_vrf_topo2.test_bgp_multi_vrf_topo2 test_delete_and_re_add_vrf_p1 (37.943 s)
✔️ bgp_multi_vrf_topo2.test_bgp_multi_vrf_topo2 test_vrf_name_significance_p1 (62.183 s)
✔️ bgp_multi_vrf_topo2.test_bgp_multi_vrf_topo2 test_restart_frr_services_p1 (14.799 s)
✔️ bgp_multiview_topo1.test_bgp_multiview_topo1 test_router_running (16.210 s)
✔️ bgp_multiview_topo1.test_bgp_multiview_topo1 test_bgp_converge (10.396 s)
✔️ bgp_multiview_topo1.test_bgp_multiview_topo1 test_bgp_routingTable (0.343 s)
/root/share/topotests/bgp_multiview_topo1/test_bgp_multiview_topo1.py:216: Memory leak test/report is disabled
✔️ bgp_multiview_topo1.test_bgp_multiview_topo1 test_shutdown_check_memleak (7.738 s)
✔️ bgp_multiview_topo1.test_bgp_multiview_topo1 test_shutdown_check_memleak (7.738 s)
✔️ bgp_path_attribute_discard.test_bgp_path_attribute_discard test_bgp_path_attribute_discard (10.023 s)
/root/share/topotests/bgp_path_attribute_discard/test_bgp_path_attribute_discard.py:147: Memory leak test/report is disabled
✔️ bgp_path_attribute_discard.test_bgp_path_attribute_discard test_memory_leak (1.045 s)
✔️ bgp_path_attribute_discard.test_bgp_path_attribute_discard test_memory_leak (1.045 s)
✔️ bgp_path_attribute_treat_as_withdraw.test_bgp_path_attribute_treat_as_withdraw test_bgp_path_attribute_treat_as_withdraw (8.811 s)
/root/share/topotests/bgp_path_attribute_treat_as_withdraw/test_bgp_path_attribute_treat_as_withdraw.py:142: Memory leak test/report is disabled
✔️ bgp_path_attribute_treat_as_withdraw.test_bgp_path_attribute_treat_as_withdraw test_memory_leak (1.928 s)
✔️ bgp_path_attribute_treat_as_withdraw.test_bgp_path_attribute_treat_as_withdraw test_memory_leak (1.928 s)
✔️ bgp_path_attributes_topo1.test_bgp_path_attributes test_next_hop_attribute (22.539 s)
✔️ bgp_path_attributes_topo1.test_bgp_path_attributes test_aspath_attribute (11.072 s)
✔️ bgp_path_attributes_topo1.test_bgp_path_attributes test_localpref_attribute (11.152 s)
✔️ bgp_path_attributes_topo1.test_bgp_path_attributes test_weight_attribute (11.175 s)
✔️ bgp_path_attributes_topo1.test_bgp_path_attributes test_origin_attribute (5.966 s)
✔️ bgp_path_attributes_topo1.test_bgp_path_attributes test_med_attribute (12.979 s)
✔️ bgp_path_attributes_topo1.test_bgp_path_attributes test_admin_distance (14.136 s)
✔️ bgp_path_selection.test_bgp_path_selection test_bgp_path_selection_ecmp (7.861 s)
✔️ bgp_path_selection.test_bgp_path_selection test_bgp_path_selection_vpn_ecmp (1.937 s)
✔️ bgp_path_selection.test_bgp_path_selection test_bgp_path_selection_metric (0.268 s)
✔️ bgp_path_selection.test_bgp_path_selection test_bgp_path_selection_vpn_metric (2.069 s)
✔️ bgp_peer_graceful_shutdown.test_bgp_peer_graceful_shutdown test_bgp_orf (10.636 s)
✔️ bgp_peer_group.test_bgp_peer-group test_bgp_peer_group (7.656 s)
✔️ bgp_peer_type_multipath_relax.test_bgp_peer-type_multipath-relax test_bgp_peer_type_multipath_relax (25.451 s)
/root/share/topotests/bgp_peer_type_multipath_relax/test_bgp_peer-type_multipath-relax.py:365: Memory leak test/report is disabled
✔️ bgp_peer_type_multipath_relax.test_bgp_peer-type_multipath-relax test_memory_leak (1.013 s)
✔️ bgp_peer_type_multipath_relax.test_bgp_peer-type_multipath-relax test_memory_leak (1.013 s)
✔️ bgp_prefix_list_any.test_bgp_prefix_list_any test_bgp_route_map_prefix_list (19.360 s)
✔️ bgp_prefix_list_topo1.test_prefix_lists test_ip_prefix_lists_in_permit (12.804 s)
✔️ bgp_prefix_list_topo1.test_prefix_lists test_ip_prefix_lists_out_permit (3.118 s)
✔️ bgp_prefix_list_topo1.test_prefix_lists test_ip_prefix_lists_in_deny_and_permit_any (0.686 s)
✔️ bgp_prefix_list_topo1.test_prefix_lists test_delete_prefix_lists (0.775 s)
✔️ bgp_prefix_list_topo1.test_prefix_lists test_ip_prefix_lists_out_deny_and_permit_any (3.083 s)
✔️ bgp_prefix_list_topo1.test_prefix_lists test_modify_prefix_lists_in_permit_to_deny (9.355 s)
✔️ bgp_prefix_list_topo1.test_prefix_lists test_modify_prefix_lists_in_deny_to_permit (9.348 s)
✔️ bgp_prefix_list_topo1.test_prefix_lists test_modify_prefix_lists_out_permit_to_deny (9.374 s)
✔️ bgp_prefix_list_topo1.test_prefix_lists test_modify_prefix_lists_out_deny_to_permit (9.391 s)
✔️ bgp_prefix_list_topo1.test_prefix_lists test_ip_prefix_lists_implicit_deny (5.256 s)
✔️ bgp_prefix_list_topo1.test_prefix_modify test_bug_prefix_lists_deny_to_permit_p1 (36.404 s)
✔️ bgp_prefix_sid.test_bgp_prefix_sid test_r1_receive_and_advertise_prefix_sid_type1 (7.582 s)
✔️ bgp_prefix_sid.test_bgp_prefix_sid test_peer2_receive_prefix_sid_type1 (3.152 s)
✔️ bgp_prefix_sid2.test_bgp_prefix_sid2 test_r1_rib (11.269 s)
✔️ bgp_recursive_route_ebgp_multi_hop.test_bgp_recursive_route_ebgp_multi_hop test_recursive_routes_iBGP_peer_p1 (36.354 s)
✔️ bgp_recursive_route_ebgp_multi_hop.test_bgp_recursive_route_ebgp_multi_hop test_next_hop_as_self_ip_p1 (18.482 s)
✔️ bgp_recursive_route_ebgp_multi_hop.test_bgp_recursive_route_ebgp_multi_hop test_next_hop_with_recursive_lookup_p1 (48.800 s)
✔️ bgp_recursive_route_ebgp_multi_hop.test_bgp_recursive_route_ebgp_multi_hop test_BGP_path_attributes_default_values_p1 (10.848 s)
✔️ bgp_recursive_route_ebgp_multi_hop.test_bgp_recursive_route_ebgp_multi_hop test_BGP_peering_bw_loopback_and_physical_p1 (22.427 s)
✔️ bgp_recursive_route_ebgp_multi_hop.test_bgp_recursive_route_ebgp_multi_hop test_BGP_active_standby_preemption_and_ecmp_p1 (18.294 s)
✔️ bgp_recursive_route_ebgp_multi_hop.test_bgp_recursive_route_ebgp_multi_hop test_password_authentication_for_eBGP_and_iBGP_peers_p1 (24.835 s)
✔️ bgp_redistribute_table.test_bgp_redistribute_table test_step1_protocols_convergence (5.394 s)
✔️ bgp_redistribute_table.test_bgp_redistribute_table test_step2_add_kernel_route_on_table_2200 (0.316 s)
✔️ bgp_redistribute_table.test_bgp_redistribute_table test_step3_remove_kernel_route_on_table_2200 (0.317 s)
✔️ bgp_redistribute_table.test_bgp_redistribute_table test_step4_add_kernel_route_on_table_2200 (0.320 s)
✔️ bgp_redistribute_table.test_bgp_redistribute_table test_step5_no_redistribute_table_2200 (0.443 s)
✔️ bgp_redistribute_table.test_bgp_redistribute_table test_step6_redistribute_table_2200 (0.445 s)
✔️ bgp_redistribute_table.test_bgp_redistribute_table test_step7_reset_bgp_instance_add_kernel_route_and_add_bgp (2.684 s)
/root/share/topotests/bgp_redistribute_table/test_bgp_redistribute_table.py:299: Memory leak test/report is disabled
✔️ bgp_redistribute_table.test_bgp_redistribute_table test_memory_leak (1.882 s)
✔️ bgp_redistribute_table.test_bgp_redistribute_table test_memory_leak (1.882 s)
✔️ bgp_reject_as_sets.test_bgp_reject_as_sets test_bgp_reject_as_sets (9.952 s)
✔️ bgp_remove_private_as.test_bgp_remove_private_as test_bgp_remove_private_as (21.471 s)
✔️ bgp_remove_private_as_route_map.test_bgp_remove_private_as_route_map test_bgp_remove_private_as_route_map (12.201 s)
/root/share/topotests/lib/ltemplate.py:197: Memory leak test/report is disabled
✔️ bgp_rfapi_basic_sanity.test_bgp_rfapi_basic_sanity test_memory_leak (10.724 s)
✔️ bgp_rfapi_basic_sanity.test_bgp_rfapi_basic_sanity test_memory_leak (10.724 s)
✔️ bgp_rfapi_basic_sanity.test_bgp_rfapi_basic_sanity test_add_routes (1.434 s)
✔️ bgp_rfapi_basic_sanity.test_bgp_rfapi_basic_sanity test_adjacencies (16.893 s)
✔️ bgp_rfapi_basic_sanity.test_bgp_rfapi_basic_sanity test_check_routes (1.541 s)
✔️ bgp_rfapi_basic_sanity.test_bgp_rfapi_basic_sanity test_check_close (0.823 s)
✔️ bgp_rfapi_basic_sanity.test_bgp_rfapi_basic_sanity test_check_timeout (0.291 s)
✔️ bgp_rfapi_basic_sanity.test_bgp_rfapi_basic_sanity test_cleanup_all (4.697 s)
/root/share/topotests/lib/ltemplate.py:197: Memory leak test/report is disabled
✔️ bgp_rfapi_basic_sanity_config2.test_bgp_rfapi_basic_sanity_config2 test_memory_leak (8.429 s)
✔️ bgp_rfapi_basic_sanity_config2.test_bgp_rfapi_basic_sanity_config2 test_memory_leak (8.429 s)
✔️ bgp_rfapi_basic_sanity_config2.test_bgp_rfapi_basic_sanity_config2 test_add_routes (1.436 s)
✔️ bgp_rfapi_basic_sanity_config2.test_bgp_rfapi_basic_sanity_config2 test_adjacencies (16.348 s)
✔️ bgp_rfapi_basic_sanity_config2.test_bgp_rfapi_basic_sanity_config2 test_check_routes (1.518 s)
✔️ bgp_rfapi_basic_sanity_config2.test_bgp_rfapi_basic_sanity_config2 test_check_close (0.767 s)
✔️ bgp_rfapi_basic_sanity_config2.test_bgp_rfapi_basic_sanity_config2 test_check_timeout (0.301 s)
✔️ bgp_rfapi_basic_sanity_config2.test_bgp_rfapi_basic_sanity_config2 test_cleanup_all (2.986 s)
✔️ bgp_route_aggregation.test_bgp_aggregation test_route_summarisation_with_summary_only_p1 (29.503 s)
✔️ bgp_route_aggregation.test_bgp_aggregation test_route_summarisation_with_as_set_p1 (16.316 s)