[Details Revamp] Allow Editing Report Title from Details Page #44671

cdOut · 2024-07-01T10:03:29Z

Details

Moved the option to rename the money report title field from the report view into the new report details.

Fixed Issues

$ #44149
PROPOSAL:

Tests

Create a workspace.
Submit two separate expenses for said workspace.
Go into the money report view of those workspace expenses.
Confirm that the title editable field is gone and is instead modifiable when pressing on the report header (Only members, approvers and admins should be able to edit it, invitees should not have that option).

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

ANDROID-NATIVE.mov

Android: mWeb Chrome

ANDROID-CHROME.mov

iOS: Native

IOS-NATIVE.mov

iOS: mWeb Safari

IOS-SAFARI.mov

MacOS: Chrome / Safari

WEB.mov

MacOS: Desktop

DESKTOP.mov

kosmydel

Lint is failing, but overall it LGTM

melvin-bot · 2024-07-02T09:40:09Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2024-07-02T11:32:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Record_2024-07-02-18-44-52.mp4

Android: mWeb Chrome

VIDEO-2024-07-02-18-52-49.mp4

iOS: Native

Screen.Recording.2024-07-02.at.6.22.33.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-07-02.at.6.33.04.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-07-02.at.6.13.05.PM.mov

MacOS: Desktop

Screen.Recording.2024-07-03.at.10.02.14.PM.mov

ishpaul777 · 2024-07-02T12:24:52Z

approvers and admins should be able to edit it, invitees should not have that option

@cdOut Does that mean if user A invited user B to a workspace (as member only) and user B submit 2 expenses. user should not be able to edit the expense report title? Asking because user B seems to be able to edit the title

cc @trjExpensify

cdOut · 2024-07-02T12:52:11Z

I'm fairly sure that user B should still be able to change the title, you can check the requirements here.

The direct quote is here:

So for example, members, approvers and admins can change the report title. Anyone added to the room, not part of the approval workfllow, should not be able to change the report title.

trjExpensify · 2024-07-02T12:52:30Z

I believe "Invitee" being referenced here is just a random user that might be @-mentioned on an expense report and then has the report shared with them. It doesn't mean the submitter of the expense report. The submitter should be able to edit the title of their expense report (so long as default report titles aren't enforced on the workspace, in which case nobody can edit the titles).

trjExpensify · 2024-07-02T12:53:17Z

I'm fairly sure that user B should still be able to change the title, you can check the requirements here.

The direct quote is here:

So for example, members, approvers and admins can change the report title. Anyone added to the room, not part of the approval workfllow, should not be able to change the report title.

Haha, jinx.

ishpaul777 · 2024-07-02T12:59:15Z

I believe "Invitee" being referenced here is just a random user that might be @-mentioned on an expense report and then has the report shared with them.

For such user, The title seems missing is this a bug ?

Screen.Recording.2024-07-02.at.6.27.32.PM.mov

@cdOut

cdOut · 2024-07-02T13:13:05Z

I believe "Invitee" being referenced here is just a random user that might be @-mentioned on an expense report and then has the report shared with them.

For such user, The title seems missing is this a bug ?

It is a bug, I'll let you know when I fix it.

cdOut · 2024-07-02T17:29:14Z

@ishpaul777 I've pushed a fix, let me know if it works for all cases (member, admin, invitee).

src/pages/ReportDetailsPage.tsx

grgia · 2024-07-03T09:10:44Z

Triggered test build

merge main into @cdOut/money-report-rename

src/libs/ReportUtils.ts

grgia · 2024-07-03T10:26:06Z

@cdOut let me know when you're ready for a new build

cdOut · 2024-07-03T10:35:18Z

@grgia should be ready for a new build now.

ishpaul777 · 2024-07-03T12:30:42Z

I'll rereview in ~1 hour.

src/pages/ReportDetailsPage.tsx

This reverts commit 25f59de.

grgia

LGTM

OSBotify · 2024-07-05T08:10:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-08T09:58:01Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.0.5-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-08T10:54:24Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.0.5-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-07-10T11:05:11Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T20:23:38Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

jayeshmangwani · 2024-07-21T08:21:08Z

src/pages/ReportDetailsPage.tsx

+                    titleStyle={styles.newKansasLarge}
+                    shouldCheckActionAllowedOnPress={false}
+                    description={Str.UCFirst(titleField.name)}
+                    onPress={() => Navigation.navigate(ROUTES.EDIT_REPORT_FIELD_REQUEST.getRoute(report.reportID, report.policyID ?? '-1', titleField.fieldID ?? '-1'))}


Coming from this #44963, After editing the title, the user should be returned to the Details RHP instead of dismissing the RHP modal.

cdOut added 2 commits July 1, 2024 12:00

add an option to rename money report in details

9946cbe

fix prettier

384abe8

kosmydel approved these changes Jul 1, 2024

View reviewed changes

cdOut added 2 commits July 1, 2024 12:35

fix lint errors and slightly refactor MenuItem

51cbec4

fix prettier

c1b7187

cdOut marked this pull request as ready for review July 2, 2024 09:40

cdOut requested a review from a team as a code owner July 2, 2024 09:40

melvin-bot bot requested review from ishpaul777 and removed request for a team July 2, 2024 09:40

grgia self-requested a review July 2, 2024 10:36

add conditional for name section edit and invitees

e8ad22e

cdOut added 2 commits July 2, 2024 20:52

fix typecheck with correct participant arguments

5fa274a

remove faulty conditional

b2531dc

grgia reviewed Jul 3, 2024

View reviewed changes

src/pages/ReportDetailsPage.tsx Show resolved Hide resolved

grgia added the Ready To Build label Jul 3, 2024

cdOut added 3 commits July 3, 2024 11:18

fix faulty conditional for expense title

b9adf74

Merge branch 'main' into @cdOut/money-report-rename

a1d526d

merge main into @cdOut/money-report-rename

remove leftover code and fix lint

2e13e10

ishpaul777 reviewed Jul 3, 2024

View reviewed changes

src/libs/ReportUtils.ts Outdated Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

cdOut added 2 commits July 3, 2024 11:50

add approver check into title conditional

a6861ac

unify nameSectionExpenseIOU and nameSectionTitleField

25f59de

ishpaul777 reviewed Jul 3, 2024

View reviewed changes

src/pages/ReportDetailsPage.tsx Outdated Show resolved Hide resolved

ishpaul777 reviewed Jul 3, 2024

View reviewed changes

src/pages/ReportDetailsPage.tsx Outdated Show resolved Hide resolved

Revert "unify nameSectionExpenseIOU and nameSectionTitleField"

f2d192e

This reverts commit 25f59de.

ishpaul777 approved these changes Jul 3, 2024

View reviewed changes

melvin-bot bot requested a review from grgia July 3, 2024 16:38

grgia approved these changes Jul 5, 2024

View reviewed changes

grgia merged commit 610a367 into Expensify:main Jul 5, 2024
15 of 20 checks passed

github-actions bot mentioned this pull request Jul 8, 2024

Deploy Checklist: New Expensify 2024-07-08 #44947

Closed

86 tasks

iwiznia mentioned this pull request Jul 8, 2024

IOU - Details modal is dismissed after editing title #44963

Closed

6 tasks

Julesssss mentioned this pull request Jul 8, 2024

[HOLD FOR PAYMENT 2024-07-15] Expense - Missing report title in report details page after the expense is paid #44959

Closed

6 tasks

melvin-bot bot mentioned this pull request Jul 10, 2024

[$250] [HOLD for payment] [Details Revamp] Allow Editing Report Title from Details Page #44149

Closed

fedirjh mentioned this pull request Jul 17, 2024

[HOLD for payment 2024-08-02] [$250] Expense - Title field is not grayed out when edited offline #45072

Closed

6 tasks

jayeshmangwani reviewed Jul 21, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Details Revamp] Allow Editing Report Title from Details Page #44671

[Details Revamp] Allow Editing Report Title from Details Page #44671

cdOut commented Jul 1, 2024 •

edited

Loading

kosmydel left a comment

melvin-bot bot commented Jul 2, 2024

ishpaul777 commented Jul 2, 2024 •

edited

Loading

ishpaul777 commented Jul 2, 2024

cdOut commented Jul 2, 2024

trjExpensify commented Jul 2, 2024

trjExpensify commented Jul 2, 2024

ishpaul777 commented Jul 2, 2024 •

edited

Loading

cdOut commented Jul 2, 2024

cdOut commented Jul 2, 2024

grgia commented Jul 3, 2024

This comment was marked as outdated.

grgia commented Jul 3, 2024

cdOut commented Jul 3, 2024

ishpaul777 commented Jul 3, 2024

grgia left a comment

OSBotify commented Jul 5, 2024

OSBotify commented Jul 8, 2024

OSBotify commented Jul 8, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 15, 2024

jayeshmangwani Jul 21, 2024

[Details Revamp] Allow Editing Report Title from Details Page #44671

[Details Revamp] Allow Editing Report Title from Details Page #44671

Conversation

cdOut commented Jul 1, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

kosmydel left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Jul 2, 2024

ishpaul777 commented Jul 2, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

ishpaul777 commented Jul 2, 2024

cdOut commented Jul 2, 2024

trjExpensify commented Jul 2, 2024

trjExpensify commented Jul 2, 2024

ishpaul777 commented Jul 2, 2024 • edited Loading

cdOut commented Jul 2, 2024

cdOut commented Jul 2, 2024

grgia commented Jul 3, 2024

This comment was marked as outdated.

grgia commented Jul 3, 2024

cdOut commented Jul 3, 2024

ishpaul777 commented Jul 3, 2024

grgia left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 5, 2024

OSBotify commented Jul 8, 2024

OSBotify commented Jul 8, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 15, 2024

jayeshmangwani Jul 21, 2024

Choose a reason for hiding this comment

cdOut commented Jul 1, 2024 •

edited

Loading

ishpaul777 commented Jul 2, 2024 •

edited

Loading

ishpaul777 commented Jul 2, 2024 •

edited

Loading