-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Details Revamp] Allow Editing Report Title from Details Page #44671
Merged
grgia
merged 13 commits into
Expensify:main
from
software-mansion-labs:@cdOut/money-report-rename
Jul 5, 2024
Merged
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
9946cbe
add an option to rename money report in details
cdOut 384abe8
fix prettier
cdOut 51cbec4
fix lint errors and slightly refactor MenuItem
cdOut c1b7187
fix prettier
cdOut e8ad22e
add conditional for name section edit and invitees
cdOut 5fa274a
fix typecheck with correct participant arguments
cdOut b2531dc
remove faulty conditional
cdOut b9adf74
fix faulty conditional for expense title
cdOut a1d526d
Merge branch 'main' into @cdOut/money-report-rename
cdOut 2e13e10
remove leftover code and fix lint
cdOut a6861ac
add approver check into title conditional
cdOut 25f59de
unify nameSectionExpenseIOU and nameSectionTitleField
cdOut f2d192e
Revert "unify nameSectionExpenseIOU and nameSectionTitleField"
cdOut File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coming from this #44963, After editing the title, the user should be returned to the Details RHP instead of dismissing the RHP modal.