[$250] [HOLD for payment] [Details Revamp] Allow Editing Report Title from Details Page

[grgia]

Problem

We currently display the report title as shown above. This is now inconsistent with our new details revamp project.

Solution

Make the report title editor available from the details page for those with correct permissions. Remove it from the report body as shown in the previous screenshot.

So for example, members, approvers and admins can change the report title. Anyone added to the room, not part of the approval workfllow, should not be able to change the report title.

We will use our typical push to page pattern for this change.

Slack thread

https://expensify.slack.com/archives/C036QM0SLJK/p1718830874704809?thread_ts=1718719187.256049&cid=C036QM0SLJK

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cc27f37e79795306
• Upwork Job ID: 1813753312852314259
• Last Price Increase: 2024-07-18

Issue Owner

Current Issue Owner: @ishpaul777

[melvin-bot]

Triggered auto assignment to @kadiealexander (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

[cdOut]

Hi, I’m Tymoteusz from Software Mansion, the expert agency, and I’ll be working on this issue.

[ishpaul777]

I am low on issues, just incase we need a c+ for this issue i'd love to help

[trjExpensify]

Assigning @ishpaul777 for C+.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @cdOut is from an agency-contributor and not due payment
• Reviewer: @ishpaul777 paid $250 via Upwork (offer)

BugZero Checklist (@kadiealexander)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cc27f37e79795306

[melvin-bot]

Current assignee @ishpaul777 is eligible for the External assigner, not assigning anyone new.

[kadiealexander]

@ishpaul777 please propose the regression test steps here.

[melvin-bot]

@grgia, @kadiealexander, @cdOut, @ishpaul777, @dubielzyk-expensify Huh... This is 4 days overdue. Who can take care of this?

[ishpaul777]

Regression Test proposal:

1. Create a workspace.
2. Submit two separate expenses for said workspace.
3. Go into the money report view of those workspace expenses.
4. Click on the report header.
5. Verify the report title field is editable.

6. Verify only members, approvers and admins of workspace be able to edit it, report invitees should not have that option

Do we agree 👍 or 👎

[kadiealexander]

@ishpaul777 please accept the upwork offer.

[ishpaul777]

Hey @kadiealexander Would you please hold my payment for few days, i have had my payments on HOLD across issues i'll bump once i am ready to accept payment.

Reason: #44029 (comment)

[kadiealexander]

No worries!

[ishpaul777]

Still hold

[ishpaul777]

Thanks for patience here @kadiealexander, please release payment when you get the chance