fix: tapping assignee and mark as complete quickly navigates to not found page #41667

tienifr · 2024-05-06T11:36:26Z

Details

Tapping assignee then marking the task as complete at the same time navigates to not found page. This PR fixes that.

Fixed Issues

$ #38577
PROPOSAL: #38577 (comment)

Tests

Open a task report
Tap Assignee then quickly tap Mark as complete
Verify that user is navigated to Assignee page only and task is not marked as completed
Tap Description then quickly tap Mark as complete
Verify that user is navigated to Description page only and task is not marked as completed

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Open a task report
Tap Assignee then quickly tap Mark as complete
Verify that user is navigated to Assignee page only and task is not marked as completed
Tap Description then quickly tap Mark as complete
Verify that user is navigated to Description page only and task is not marked as completed

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

video_2024-06-20_18-22-11.mp4

Android: mWeb Chrome

video_2024-06-20_17-42-16.mp4

iOS: Native

Screen.Recording.2024-05-06.at.19.01.42-compressed.mov

iOS: mWeb Safari

Screen.Recording.2024-05-06.at.19.02.24-compressed.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-06.at.18.38.03-compressed.mov

MacOS: Desktop

Screen.Recording.2024-05-06.at.18.38.03-compressed.mov

…ound page

…regression

melvin-bot · 2024-06-20T11:22:41Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tienifr · 2024-06-20T11:44:05Z

@mananjadhav After tapping Assignee, if we quickly tap Mark as completed many times, when we went back from Assignee page, the Mark as completed button will be dimmed but it's still functioning if we tap it (just dim, not disabled).

Root cause is because the onPressOut callback is not triggered when we quickly press the button many times:

App/src/components/Pressable/PressableWithFeedback.tsx

Lines 80 to 81 in 6dc6f81

    
           onPressOut={(event) => { 
        
               setIsPressed(false);

causing it to misunderstand that we're long pressing and dim the button:

App/src/components/Pressable/PressableWithFeedback.tsx

Line 52 in 6dc6f81

shouldDim={!!(!rest.disabled && (isPressed || isHovered))}

I think this issue has a different root cause and out of scope of this PR because it happens in many places like the Invite member button in Workspace:

video_2024-06-20_18-42-09.mp4

tienifr · 2024-06-26T10:22:23Z

Bump @mananjadhav.

mananjadhav · 2024-06-26T22:31:17Z

Will review this today/tomorrow.

mananjadhav · 2024-07-01T07:41:18Z

@mananjadhav After tapping Assignee, if we quickly tap Mark as completed many times, when we went back from Assignee page, the Mark as completed button will be dimmed but it's still functioning if we tap it (just dim, not disabled).

I think we can treat it separately. You can report it on the bug channel.

@tienifr Can you update the PR body to remove singleExecution now that the code logic is changed. Overall the code looks fine. I'll test and work on the checklist today.

mananjadhav · 2024-07-01T08:34:07Z

Also @tienifr Can you please add a comment on why we're adding these route checks?

tienifr · 2024-07-02T06:59:34Z

src/components/ReportActionItem/TaskView.tsx

+                                                    Navigation.isActiveRoute(ROUTES.TASK_ASSIGNEE.getRoute(report.reportID)) ||
+                                                    Navigation.isActiveRoute(ROUTES.REPORT_DESCRIPTION.getRoute(report.reportID))
+                                                ) {
+                                                    return;


If we're already navigating to these task editing pages, early return not to mark as completed, otherwise we would have not found page.

@tienifr I mean comment in the code.

Thanks. Updated.

mananjadhav · 2024-07-02T16:26:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-assignee-complee.mov

Android: mWeb Chrome

mweb-chrome-assignee-complete.mov

iOS: Native

ios-assignee-complete.mov

iOS: mWeb Safari

mweb-safari-assignee-complete.mov

MacOS: Chrome / Safari

web-assignee-complete.mov

MacOS: Desktop

desktop-assignee-complete.mov

mananjadhav · 2024-07-02T16:26:44Z

I am getting build errors on this branch for Native apps.


 BUNDLE  ./index.js

error: Error: Unable to resolve module react-compiler-runtime from /Users/manan/dumpd/expensify/App/src/components/ActiveWorkspaceProvider/index.tsx: react-compiler-runtime could not be found within the project or in these directories:
  node_modules
> 1 | import React, {useMemo, useState} from 'react';

@tienifr Did you face this issue? I am getting this only for this branch. Can you sync with the latest main?

mananjadhav · 2024-07-07T23:49:15Z

@tienifr Quick bump on the previous message. Can you sync your code to latest main? Syncing to main resolves the earlier error for me.

…regression

tienifr · 2024-07-08T10:28:04Z

@mananjadhav I synced main.

rlinoz · 2024-07-08T22:14:07Z

src/components/TaskHeaderActionButton.tsx

-                onPress={Session.checkIfActionIsAllowed(() => (ReportUtils.isCompletedTaskReport(report) ? Task.reopenTask(report) : Task.completeTask(report)))}
+                onPress={Session.checkIfActionIsAllowed(() => {
+                    // If we're already navigating to these task editing pages, early return not to mark as completed, otherwise we would have not found page.
+                    if (Navigation.isActiveRoute(ROUTES.TASK_ASSIGNEE.getRoute(report.reportID)) || Navigation.isActiveRoute(ROUTES.REPORT_DESCRIPTION.getRoute(report.reportID))) {


I think we have to add the TASK_TITLE route here as well, only click I am getting the 404 now.

Please trigger another build so we can retest it.

…regression

rlinoz · 2024-07-10T13:08:27Z

Just triggered a new build

github-actions · 2024-07-10T13:43:25Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/41667/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/41667/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/41667/NewExpensify.dmg	https://41667.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

rlinoz

It tests well, thanks!

rlinoz · 2024-07-10T14:29:03Z

@mananjadhav just missing one item in the checklist now 🚀

mananjadhav · 2024-07-10T14:51:16Z

Done @rlinoz

OSBotify · 2024-07-10T15:06:48Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-15T21:03:38Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.0.7-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T22:12:22Z

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 9.0.7-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-17T00:17:31Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-07-18T13:48:50Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.8-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

tienifr added 8 commits May 6, 2024 18:35

fix: tapping assignee and mark as complete quickly navigates to not f…

3f01909

…ound page

Merge branch 'main' of https://github.com/tienifr/App into fix/38577-…

35e7a98

…regression

Merge branch 'main' of https://github.com/tienifr/App into fix/38577-…

10a282f

…regression

revert singleExecution approach

9b6b699

Merge branch 'main' of https://github.com/tienifr/App into fix/38577-…

3c1d2ca

…regression

Merge branch 'main' of https://github.com/tienifr/App into fix/38577-…

dcdff40

…regression

check active route approach

6d91057

remove redundant changes

0308f12

tienifr marked this pull request as ready for review June 20, 2024 11:22

tienifr requested a review from a team as a code owner June 20, 2024 11:22

melvin-bot bot requested review from mananjadhav and removed request for a team June 20, 2024 11:22

tienifr mentioned this pull request Jun 20, 2024

[HOLD for payment 2024-07-24] [$500] Android - Task - Tapping assignee and quickly tapping mark as complete directed to hmm not here #38577

Closed

6 tasks

tienifr commented Jul 2, 2024

View reviewed changes

mananjadhav approved these changes Jul 8, 2024

View reviewed changes

melvin-bot bot requested a review from rlinoz July 8, 2024 00:11

tienifr added 2 commits July 8, 2024 17:25

Merge branch 'main' of https://github.com/tienifr/App into fix/38577-…

34ce439

…regression

add explanative comments

8dc6389

rlinoz added the Ready To Build label Jul 8, 2024

This comment has been minimized.

Sign in to view

rlinoz requested changes Jul 8, 2024

View reviewed changes

tienifr added 2 commits July 10, 2024 18:50

Merge branch 'main' of https://github.com/tienifr/App into fix/38577-…

b6cc4bd

…regression

include task title route

9b7af88

rlinoz approved these changes Jul 10, 2024

View reviewed changes

rlinoz merged commit def0da8 into Expensify:main Jul 10, 2024
14 of 16 checks passed

github-actions bot mentioned this pull request Jul 15, 2024

Deploy Checklist: New Expensify 2024-07-15 #45421

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: tapping assignee and mark as complete quickly navigates to not found page #41667

fix: tapping assignee and mark as complete quickly navigates to not found page #41667

tienifr commented May 6, 2024 •

edited

Loading

melvin-bot bot commented Jun 20, 2024

tienifr commented Jun 20, 2024

tienifr commented Jun 26, 2024

mananjadhav commented Jun 26, 2024

mananjadhav commented Jul 1, 2024

mananjadhav commented Jul 1, 2024

tienifr Jul 2, 2024

mananjadhav Jul 2, 2024

tienifr Jul 8, 2024

mananjadhav commented Jul 2, 2024 •

edited

Loading

mananjadhav commented Jul 2, 2024 •

edited

Loading

mananjadhav commented Jul 7, 2024

tienifr commented Jul 8, 2024

This comment has been minimized.

rlinoz Jul 8, 2024

tienifr Jul 10, 2024

tienifr Jul 10, 2024

rlinoz commented Jul 10, 2024

github-actions bot commented Jul 10, 2024

rlinoz left a comment

rlinoz commented Jul 10, 2024

mananjadhav commented Jul 10, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 17, 2024

OSBotify commented Jul 18, 2024

fix: tapping assignee and mark as complete quickly navigates to not found page #41667

fix: tapping assignee and mark as complete quickly navigates to not found page #41667

Conversation

tienifr commented May 6, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 20, 2024

tienifr commented Jun 20, 2024

tienifr commented Jun 26, 2024

mananjadhav commented Jun 26, 2024

mananjadhav commented Jul 1, 2024

mananjadhav commented Jul 1, 2024

tienifr Jul 2, 2024

Choose a reason for hiding this comment

mananjadhav Jul 2, 2024

Choose a reason for hiding this comment

tienifr Jul 8, 2024

Choose a reason for hiding this comment

mananjadhav commented Jul 2, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

mananjadhav commented Jul 2, 2024 • edited Loading

mananjadhav commented Jul 7, 2024

tienifr commented Jul 8, 2024

This comment has been minimized.

rlinoz Jul 8, 2024

Choose a reason for hiding this comment

tienifr Jul 10, 2024

Choose a reason for hiding this comment

tienifr Jul 10, 2024

Choose a reason for hiding this comment

rlinoz commented Jul 10, 2024

github-actions bot commented Jul 10, 2024

rlinoz left a comment

Choose a reason for hiding this comment

rlinoz commented Jul 10, 2024

mananjadhav commented Jul 10, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 17, 2024

OSBotify commented Jul 18, 2024

tienifr commented May 6, 2024 •

edited

Loading

mananjadhav commented Jul 2, 2024 •

edited

Loading

mananjadhav commented Jul 2, 2024 •

edited

Loading