[HOLD for payment 2024-07-24] [$500] Android - Task - Tapping assignee and quickly tapping mark as complete directed to hmm not here

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.54.0
Reproducible in staging?: y
Reproducible in production?: y
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch app
2. Tap fab --- assign task
3. Enter title
4. Tap next
5. Select share somewhere
6. Confirm task
7. Open task to open task details page
8. Tap assignee and quickly tap mark as complete button on header

Expected Result:

When user taps assignee and quickly taps mark as complete button on header, user must not be directed to hhm not here page.

Actual Result:

When user taps assignee and quickly taps mark as complete button on header, user directed to hhm not here page.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6418378_1710795369359.aaj.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01efbf5aa31beec5a5
• Upwork Job ID: 1772302127195226112
• Last Price Increase: 2024-03-25
• Automatic offers:
• tienifr | Contributor | 0

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[kbecciv]

@adelekennedy I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[kbecciv]

We think that this bug might be related to #vip-vsb

[adelekennedy]

task related

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01efbf5aa31beec5a5

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When user taps assignee and quickly taps mark as complete button on header, user directed to hhm not here page.

What is the root cause of that problem?

When we tap on Assignee and mark the task as completed at the same time, at the time we navigate to the assignee selection page, the task was already completed, so we see not found page.

What changes do you think we should make in order to solve the problem?

It should not be possible to click on Assignee and mark task as completed at the same time. We can use singleExecution to limit this, this is an approach widely used in the app. We should make sure the Mark as complete button and the Assignee menu item share the same singleExecution context, so only one of them can execute at a time.

There're many ways to do this, here's an example:

• use useSingleExecution in ReportScreen to create a single execution context
• pass the singleExecution to the TaskHeaderActionButton, and wrap it around the onPress event callback
• pass the same singleExecution to the menu items of the TaskView, and and wrap it around the onPress event callback

What alternative solutions did you explore? (Optional)

Same approach but a few different implementations:

• use context to pass the singleExecution down from ReportScreen to child components
• Or we can refactor useSingleExecution to accept a params indication which single execution, like executionId, then we stored the single execution contexts based on those ids and return the correct one when useSingleExecution(executionId) is used, this can help 2 different components to share the same single execution context by using the same executionId

[mananjadhav]

it should not be possible to click on Assignee and mark task as completed at the same time. We can use singleExecution to limit this, this is an approach widely used in the app.

🎀 👀 🎀 confirming with @rlinoz if we are okay with the blocking behavior.

[melvin-bot]

Triggered auto assignment to @rlinoz, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[rlinoz]

I think we should be good with the blocking behavior

[mananjadhav]

Cool. Then @tienifr’s proposal looks good to me.

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mananjadhav]

@tienifr following up on this, otherwise let's open this for new proposals. It's been open for more than a month now.

[tienifr]

I found one feasible solution is when we press mark as complete, we could check whether the current active route is the assignee page then early return. I'll open PR today.

[mananjadhav]

@tienifr Waiting for an update.

[tienifr]

PR ready for review #41667.

[rlinoz]

PR is merged awaiting deploy.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: tapping assignee and mark as complete quickly navigates to not found page #41667

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @tienifr requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[adelekennedy]

Payouts due:

• Contributor: $500 @tienifr (Newdot)
• Contributor+: $500 @mananjadhav (NewDot)

[adelekennedy]

@mananjadhav I think the final step here is the checklist?

[adelekennedy]

bump @mananjadhav

[mananjadhav]

@adelekennedy @rlinoz There was a regression on this task. But I would like to request if we can pay the full price here. This was a bit weird case, where we use useSingleExecution and couldn't get it working on mobile web. Then @tienifr found an alternative way of solving this.

I don't have an offending PR for this one as this was a part of the navigation issue. I couldn't pinpoint if this came from a specific PR. I also feel we should add a regression test to this one.

Regression Test steps:

1. Open a task report
2. Tap Assignee then quickly tap Mark as complete.
3. Verify that user is navigated to Assignee page only and task is not marked as completed.
4. Tap Description then quickly tap Mark as complete.
5. Verify that user is navigated to Description page only and task is not marked as completed.
6. Verify during the navigation you don't see Not found page.

[mananjadhav]

@adelekennedy Did you get a chance to look at my previous comment?

[adelekennedy]

hey! I'm back from ooo - that reasoning makes sense to me, I think we should move forward with the full amount.

[adelekennedy]

https://github.com/Expensify/Expensify/issues/416801

[mananjadhav]

Thanks @adelekennedy. Appreciate it.

[JmillsExpensify]

$500 approved for @mananjadhav

[JmillsExpensify]

$500 approved for @tienifr