[HOLD for payment 2024-05-02] Task - "Mark as complete' button grays out briefly when selecting Delete/Pin

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.64-0
Reproducible in staging?: y
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch New Expensify app.
2. Create a task.
3. Go to task report.
4. Tap 3-dot menu.
5. Select Delete or Pin.

Expected Result:

"Mark as complete' button will not gray out briefly.

Actual Result:

"Mark as complete' button grays out briefly.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6457681_1713804925993.RPReplay_Final1713804758.1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @cead22 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #vip-vsb

[ZhenjaHorbach]

Regression from this PR
#39397

[mountiny]

@tienifr @rlinoz @mananjadhav can you please address this?

[mountiny]

@cead22 if you have time, could yo please check if reverting #39397 fixes the issue? thank you 🙇

[rlinoz]

Not sure how to fix this, the button is gray while if you click on it there will be no action. That comes from us not wanting to allow tapping on something and tapping on Mark as complete at the same time.

I think there is the option to not gray it out, but if you click on it nothing will happen.

[rlinoz]

Running a build to check if a revert fixes this.

[ZhenjaHorbach]

Actually problem related with this line
3d12941#diff-e7be94a3eea9790dc0c74f91b6194cd14cb799d00d9692ea4be7f2136a19fb11R43

If we want we can just add
innerStyles={isExecuting ? {opacity: 1} : null}

To override the default disable styles when isExecuting is true

[rlinoz]

Yeah, I was going for something similar, but there will be the problem of not being clear that you can't perform the action at that exact moment. With that said, I think it should be fine since it is such a brief moment and it is better than having the button blinking gray.

[rlinoz]

Reverting here #40729 since it was reported that it did not fix the main issue #39397 (comment)

[rlinoz]

Asked for CP: https://expensify.slack.com/archives/C07J32337/p1713821522369469

[mountiny]

Thanks!

[rlinoz]

I believe we can close this one

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Block edit assignee and mark as complete simultaneously" #40729

If no regressions arise, payment will be issued on 2024-05-02. 🎊