-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tapping assignee and mark as complete quickly navigates to not found page #41667
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3f01909
fix: tapping assignee and mark as complete quickly navigates to not f…
tienifr 35e7a98
Merge branch 'main' of https://github.com/tienifr/App into fix/38577-…
tienifr 10a282f
Merge branch 'main' of https://github.com/tienifr/App into fix/38577-…
tienifr 9b6b699
revert singleExecution approach
tienifr 3c1d2ca
Merge branch 'main' of https://github.com/tienifr/App into fix/38577-…
tienifr dcdff40
Merge branch 'main' of https://github.com/tienifr/App into fix/38577-…
tienifr 6d91057
check active route approach
tienifr 0308f12
remove redundant changes
tienifr 34ce439
Merge branch 'main' of https://github.com/tienifr/App into fix/38577-…
tienifr 8dc6389
add explanative comments
tienifr b6cc4bd
Merge branch 'main' of https://github.com/tienifr/App into fix/38577-…
tienifr 9b7af88
include task title route
tienifr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're already navigating to these task editing pages, early return not to mark as completed, otherwise we would have not found page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tienifr I mean comment in the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Updated.