Show historical OldDot Report Actions in Plain text #38013

eh2077 · 2024-03-09T01:43:30Z

Details

This PR incorporates commits from #37022 and works on them.

Fixed Issues

$ #36023
$ #34968
$ #34783
$ #32602
PROPOSAL:

Tests

Pre-testing steps

Create a new collect policy on OldDot and;
i. Enable scheduled submit with a frequency of Instant (this should happen by default with Expensify accounts, or accounts on paidPolicyInstantSubmit beta)
ii. Make sure the approval mode is "Submit & Approve"
iii. Invite an additional user to the policy to play the member role in these testing flows

Run the following script in the chrome console (in OldDot, when the workspace Settings page is open) to enable the

policy for workspace creation for a paid plan.
p = Policy.getCurrent();
p.policy.isPolicyExpenseChatEnabled = "true";
p.save();

Test steps

In OldDot: As submitter, make sure ^ new workspace is your "Active" / default workspace
In OldDot: As submitter, create a report and add an expense
In OldDot: As Admin, approve the report - then Unapprove the report
In NewDot: As both accounts, view the expense report & verify you can see both of these report actions:

i. final approved this report
ii. unapproved this report
Verify that unapproved this report report action appear.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

0-web.mp4

MacOS: Desktop

melvin-bot · 2024-03-12T06:03:58Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

eh2077 · 2024-03-12T06:07:58Z

@twisterdotcom Kindly help to review if all oldDot actions needed are included, thanks! You can just comment here if there're other types need to add. I'll help update them then.

twisterdotcom · 2024-03-12T10:05:48Z

@eh2077 - I checked yesterday when chatting this through with @dylanexpensify - the only one missing was the EXPORTEDTOCSV one which I pushed above. Other than that, we're good to go!

Edit, ah wait you did it, great! No, nothing left to do here except review and get it merged.

src/libs/ReportActionsUtils.ts

src/pages/home/report/ReportActionItem.tsx

hoangzinh · 2024-03-14T14:29:08Z

Oh no, perf-tests is failing. Try to re-run it @eh2077

hoangzinh · 2024-03-14T14:29:22Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Beamanator · 2024-03-14T14:35:23Z

Re-running it 👍

hoangzinh · 2024-03-14T15:24:12Z

Bug 1: Olddot messages aren't updated in LHN

eh2077 · 2024-03-15T06:32:14Z

@hoangzinh Good catch. Yes, in this test case, the approved message is shown in LHN but the unapproved msg is not. See

App/src/libs/ReportActionsUtils.ts

Lines 912 to 914 in 4e599b2

    
           function isApprovedOrSubmittedReportAction(action: OnyxEntry<ReportAction> | EmptyObject) { 
        
               return [CONST.REPORT.ACTIONS.TYPE.APPROVED, CONST.REPORT.ACTIONS.TYPE.SUBMITTED].some((type) => type === action?.actionName); 
        
           }

@twisterdotcom Do we need to show those system messages from oldDot actions in LHN? If we want to show them, then I think we need to sort out them case by case because many of them may need corresponding Spanish translations. Or I guess we can just omit showing them in LHN because they're legacy actions which won't be added to newDot?

twisterdotcom · 2024-03-15T10:10:08Z

@eh2077 - we can omit them from the LHN for now. We have plans to slowly migrate these all to native newDot actions - this is more a temporary fix to resolve confusion before we build them into newDot with Spanish translations and better wording to fit the chat flow.

hoangzinh

LGTM

Beamanator

LGTM!

melvin-bot · 2024-03-15T11:48:36Z

@Beamanator looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

Beamanator · 2024-03-15T11:51:14Z

Uhhh the checklist point failed even though it was filled out here - #38013 (comment)

OSBotify · 2024-03-15T11:55:08Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-18T16:30:28Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.4.54-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-19T23:11:32Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.54-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

arosiclair · 2024-05-15T19:21:16Z

src/CONST.ts

+                DELETEDACCOUNT: 'DELETEDACCOUNT', // OldDot Action
+                DONATION: 'DONATION', // OldDot Action
+                EXPORTEDTOCSV: 'EXPORTEDTOCSV', // OldDot Action
+                EXPORTEDTOINTEGRATION: 'EXPORTEDTOINTEGRATION', // OldDot Action


Noticed the value for this one is off. It should just be EXPORTINTEGRATION (src). @Beamanator can you update that? We're going to need it for the QBO doc I'm working on.

Good catch @arosiclair ! fixed here: #42242

Beamanator and others added 9 commits February 21, 2024 16:33

Initial historical action to show

a8097cd

Merge branch 'main' into beaman-showHistoricalOldDotActions

6506ff2

Add relevant oldDot messages we're missing in newDot to const

75cd434

Render oldDot messages from const

9c8833f

Update CONST.ts

53f4289

Merge branch 'main' into beaman-showHistoricalOldDotActions

b3b877f

Merge branch 'main' into beaman-showHistoricalOldDotActions

f36b381

solve conflicts and add method getMarkedReimbursedMessage back

9329f83

fix lint and improve comment and naming

a85e541

eh2077 force-pushed the 37022-showHistoricalOldDotActions branch from 757cf77 to a85e541 Compare March 9, 2024 02:06

add oldDot action type EXPORTEDTOCSV

a3cbc26

eh2077 marked this pull request as ready for review March 12, 2024 06:03

eh2077 requested a review from a team as a code owner March 12, 2024 06:03

melvin-bot bot removed the request for review from a team March 12, 2024 06:03

melvin-bot bot requested a review from hoangzinh March 12, 2024 06:03

hoangzinh reviewed Mar 12, 2024

View reviewed changes

src/libs/ReportActionsUtils.ts Show resolved Hide resolved

src/pages/home/report/ReportActionItem.tsx Outdated Show resolved Hide resolved

Beamanator self-requested a review March 13, 2024 07:39

extract check to method isOldDotReportAction

ea29ad9

eh2077 requested a review from hoangzinh March 14, 2024 07:41

hoangzinh approved these changes Mar 15, 2024

View reviewed changes

Beamanator approved these changes Mar 15, 2024

View reviewed changes

Beamanator merged commit e9c112a into Expensify:main Mar 15, 2024
16 of 17 checks passed

melvin-bot bot added the Emergency label Mar 15, 2024

Beamanator removed the Emergency label Mar 15, 2024

github-actions bot mentioned this pull request Mar 18, 2024

Deploy Checklist: New Expensify 2024-03-18 #38489

Closed

65 tasks

allgandalf mentioned this pull request Mar 19, 2024

Scan - Detach receipt message mentions (none) as merchant for scan request with merchant #38541

Closed

6 tasks

arosiclair reviewed May 15, 2024

View reviewed changes

Beamanator mentioned this pull request May 16, 2024

[NO QA] Fix values of EXPORTED_* actions #42242

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show historical OldDot Report Actions in Plain text #38013

Show historical OldDot Report Actions in Plain text #38013

eh2077 commented Mar 9, 2024 •

edited

Loading

melvin-bot bot commented Mar 12, 2024

eh2077 commented Mar 12, 2024

twisterdotcom commented Mar 12, 2024 •

edited

Loading

hoangzinh commented Mar 14, 2024

hoangzinh commented Mar 14, 2024 •

edited

Loading

Beamanator commented Mar 14, 2024

hoangzinh commented Mar 14, 2024

eh2077 commented Mar 15, 2024

twisterdotcom commented Mar 15, 2024

hoangzinh left a comment

Beamanator left a comment

melvin-bot bot commented Mar 15, 2024

Beamanator commented Mar 15, 2024

OSBotify commented Mar 15, 2024

OSBotify commented Mar 18, 2024

OSBotify commented Mar 19, 2024

arosiclair May 15, 2024

Beamanator May 16, 2024

Show historical OldDot Report Actions in Plain text #38013

Show historical OldDot Report Actions in Plain text #38013

Conversation

eh2077 commented Mar 9, 2024 • edited Loading

Details

Fixed Issues

Tests

Pre-testing steps

Test steps

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 12, 2024

eh2077 commented Mar 12, 2024

twisterdotcom commented Mar 12, 2024 • edited Loading

hoangzinh commented Mar 14, 2024

hoangzinh commented Mar 14, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

Beamanator commented Mar 14, 2024

hoangzinh commented Mar 14, 2024

eh2077 commented Mar 15, 2024

twisterdotcom commented Mar 15, 2024

hoangzinh left a comment

Choose a reason for hiding this comment

Beamanator left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Mar 15, 2024

Beamanator commented Mar 15, 2024

OSBotify commented Mar 15, 2024

OSBotify commented Mar 18, 2024

OSBotify commented Mar 19, 2024

arosiclair May 15, 2024

Choose a reason for hiding this comment

Beamanator May 16, 2024

Choose a reason for hiding this comment

eh2077 commented Mar 9, 2024 •

edited

Loading

twisterdotcom commented Mar 12, 2024 •

edited

Loading

hoangzinh commented Mar 14, 2024 •

edited

Loading