Deploy Checklist: New Expensify 2024-03-18

[github-actions]

Release Version: 1.4.54-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

• [TS migration] Migrate 'Onfido' component to TypeScript #31378
• Remove MoneyRequestSelectorPage.js and copy any changes since Nov 27 into IOURequestStartPage.js. #35455
• Fix: add Noto Color Emoji to support flags on Windows #35790
• Fix: Infinite loading in policy expense chat when changing from auditor to employee #35923
• [TS migration] Migrate 'ReimbursementAccount' to TypeScript #36495
• Image Web/Desktop: Add support for http headers #36560
• [TS migration] Migrate 'Desktop' files to TypeScript #37615
• Fix a failed-to-add workspace member is hidden #37895
• [Simplified Collect][Taxes] Creating new taxes #37967
• Show historical OldDot Report Actions in Plain text #38013
• feat: policy add distance rate #38035
• [New architecture] Replace @oguzhnatly/react-native-image-manipulator with expo-image-manipulator [v2] #38145
• [NoQA][Audit][Implementation] - Remove Intl Polyfills which are supported by Hermes on native platforms #38228
• [NoQA] Add performance tests for getMemberAccountIDsForWorkspace #38271
• Fix visibility of back button in Workspaces #38278
• Fix: The selected sub-category does not show in one line format for small list #38279
• Clean up the PersonalDetails type #38306
• Fix connect option page is shown instead of bank selection page #38330
• Create TagSettingsPage #38335
• Refactor FlagCommentPage to access parent report directly from Onyx #38356
• fix: allow suggestion menu to close once a mention is chosen #38361
• switch to all workspace view when workspace is deleted #38365
• [Simplified Collect][Taxes] Create WorkspaceTaxesSettingsPage and subpages #38373
• Fix area around bottom tab avatar isn't clickable #38380
• Fix numpad buttons size #38385
• [Reassure] Add measureFunction test for getOptions #38387
• Update "More features" page route #38396
• Use another navigation action to get back #38398
• [NoQA] dev(e2e): remove cancel option #38399
• [NoQA] Update the format of the string sent for reassure test dashboard #38405
• Revert "Merge pull request #35790 from dragnoir/33653-fix" #38408
• Updating check to only set status as online if we're sure we're online #38409
• Unselect all categories when editing #38416
• Fix right caret and routes #38417
• Revert "get rid of PR check that always fails for help dot" #38422
• Fix category decode #38426
• fix: add optimistic data once disable workflow #38432
• [No QA] Update call to server to use previousUpdateIDFromServer on GetMissingOnyxMessages #38475
• [CP Staging] Revert "[NoQA][Audit][Implementation] - Remove Intl Polyfills which are supported by Hermes on native platforms" #38508
• [CP Staging] fix concierge avatar not showing in preview #38554
• Fix: Parent category not show selected state in category tree #38592
• Remove prop that's not needed #38646

Deploy Blockers:

• [HOLD for payment 2024-04-03] [$500] [Simplified Collect][Taxes] - Unable to add custom tax name after clearing the custom tax name #38496
• [HOLD for payment 2024-05-22] [$250] [Simplified Collect][Taxes] - Save button does not move above the keyboard when keyboard is up #38497
• [HOLD for payment 2024-04-05] [HOLD for payment 2024-04-03] [Simplified Collect][Taxes] Value row shows decimal point with no digit when saving amount with a dot and with no digit after  #38499
• [HOLD for payment 2024-04-05] [HOLD for payment 2024-03-29] [HOLD for payment 2024-03-26] [Simplified Collect][Taxes] iOS - Taxes - App crashes tapping tax value #38502
• [HOLD for payment 2024-04-05] [HOLD for payment 2024-03-29] [HOLD for payment 2024-03-26] iOS - App Crashed when tap on request money #38504
• [Simplified Collect][Distance Rates] Distance rates - Enter key does not save distance rate #38509
• [$500] [HOLD for payment 2024-03-29] [HOLD for payment 2024-03-26] Profile - Avatar is blank when viewed in full screen #38516
• iOS - Workspace - App crashes when tapping Reimbursements #38517
• Distance rates - Saving rate by enter key redirects to the previous page after rate is saved #38519
• [Simplified Collect][Taxes] It crashes if you try to add a custom name without having any taxes #38528
• Expense - LHN for expense report shows user email instead of detach receipt message #38532
• Scan - Detach receipt message mentions (none) as merchant for scan request with merchant #38541
• [Taxes] Tax rate deleted on Old Dot is not removed from New Dot #38559
• [$500] [HOLD for payment 2024-03-29] [HOLD for payment 2024-03-26] Category - Parent category is not checked above subcategories when there is <8 categories #38564
• [HOLD for payment 2024-04-05] [HOLD App#38428] [$250] [Workflows] - Page loads infinitely after toggling on Make or track payments #38566
• [HOLD for payment 2024-04-05] [Simplified Collect][Taxes] Android - Workspace - Tax name field isn't auto focused the keyboard isn't visible #38572
• Android - Distance - Location access not asking every time #38573
• [HOLD for payment 2024-04-15] [$250] Bank account - Company's website field is missing https:// #38585
• [HOLD for payment 2024-03-29] [HOLD for payment 2024-03-26] [$250] Desktop/Web - User Status - Unable to enter a custom time for user status using the keyboard #38595
• Workspace - Deleted bank account appears if you add a new after disconnecting #38598

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.54-0 🚀

[luacmartins]

Checking off #38496. Demoted to NAB

[luacmartins]

Checking off #38497. Demoted to NAB.

[luacmartins]

Checking off #38499. Demoted to NAB.

[luacmartins]

Checking off #38502. Demoted to NAB.

[mountiny]

#38504 straight revert PR being CPed

[luacmartins]

Checking off #38509. Demoted to NAB.

[luacmartins]

Checking off #38519. Demoted to NAB.

[luacmartins]

Checking off #38528. Demoted to NAB.

[kavimuru]

Regression is 62% completed.
#38385 failing with #38504

[jasperhuangg]

Checking off #38532 NAB since the fix is in the back-end

[kavimuru]

Regression is down to 3%

unchecked PRs

#35923 is failing with #38580, repro in PROD checking it off
#38385 failing with #38504
#31378 failing with known bug #38201 checking it off
#35790 failing with #33653. Bug is not fixed in windows- Ok to check it off? comment
#38373 failing with #38528

We are working on the following PRs
#36560 - Desktop validation is pending
#38013 - Desktop, mweb and iOS validations are pending
#38279 - Desktop validation is pending
#38356 - iOS validation is pending
#38361 - mweb, desktop,android and iOS validations are pending

[kavimuru]

Regression is just 1% left.

Unchecked PRs:
#38385 and #38279 failing with #38504
#35790 failing with #33653. Bug is not fixed in windows- Ok to check it off? #35790 (comment)
#38373 failing with #38528

Open blockers:
#38516
#38564
#38572
#38585
#38595
#38598

[cristipaval]

Checking off #38585. NAB - it's a super minor UI thing

[luacmartins]

Checking off #38572. Demoted to NAB

[kavimuru]

Regression is completed.

Unchecked PRs:
#38385 and #38279 failing with #38504
#35790 failing with #33653. Bug is not fixed in windows- Ok to check it off? #35790 (comment)
#38373 failing with #38528

Open blockers:
#38516
#38564
#38595
#38598

[AndrewGable]

Blockers have been resolved, checking unchecked PRs now

[AndrewGable]

#35790 is OK as it was reverted

[AndrewGable]

#38279 is OK now that we CP-ed the fix

[AndrewGable]

#38385 was reverted, so we are OK there

[AndrewGable]

#38373 seems OK as pages are behind a beta

[AndrewGable]