Share Code page update #36120

filip-solecki · 2024-02-08T11:04:42Z

Details

Fixed Issues

$ #35605
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Log in to the app
Open Account Settings
Choose "Share Code"
Check if everything looks and works fine

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

src/components/ContextMenuItem.tsx

Co-authored-by: Jakub Kosmydel <[email protected]>

melvin-bot · 2024-02-08T12:42:49Z

@blimpich Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

filip-solecki · 2024-02-08T12:43:07Z

Hi! @shawnborton @trjExpensify , please have a look at designs here!

shawnborton · 2024-02-08T15:19:58Z

cc @Expensify/design too!

shawnborton · 2024-02-08T15:20:36Z

For mobile, part of me thinks we might as well make the share code take up as much horizontal space as possible:

Thoughts on that?

shawnborton · 2024-02-08T15:21:15Z

Otherwise lookin' good to me! Let's see if Danny and Jon have feedback too though.

mountiny · 2024-02-08T20:18:55Z

build running here https://github.com/Expensify/App/actions/runs/7835465556

mountiny · 2024-02-08T20:19:07Z

@situchan can you prioritize this one tomorrow? thanks!

github-actions · 2024-02-08T20:41:32Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/36120/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/36120/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/36120/NewExpensify.dmg	https://36120.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

dubielzyk-expensify · 2024-02-08T23:33:36Z

Agree. I think the whole QR code should fill 100% of the horizontal space. Until it gets too big

filip-solecki · 2024-02-09T09:12:15Z

Updated - now on small screens QR Code fill 100% of the space as it was before

filip-solecki · 2024-02-09T09:32:58Z

This is how it looks like right now: @shawnborton @dubielzyk-expensify

dannymcclain · 2024-02-09T15:13:37Z

Lookin' good to me! And I totally agree about the share code width.

@shawnborton @dubielzyk-expensify can y'all help me verify if we want there to be 0px of padding on the content area (like in Figma) or 12px (like in the current build). I saw that Jon mentioned something about this on a different issue as well, so I just want to make sure we're all aligned.

kosmydel · 2024-02-09T15:18:08Z

Lookin' good to me! And I totally agree about the share code width.

@shawnborton @dubielzyk-expensify can y'all help me verify if we want there to be 0px of padding on the content area (like in Figma) or 12px (like in the current build). I saw that Jon mentioned something about this on a different issue as well, so I just want to make sure we're all aligned.

The padding was already removed in this PR, just the build is not updated.

dannymcclain · 2024-02-09T15:22:35Z

Ok cool! Thanks for clarifying!

situchan · 2024-02-09T16:22:12Z

src/languages/en.ts

@@ -1984,7 +1988,7 @@ export default {
        parentNavigationSummary: ({rootReportName, workspaceName}: ParentNavigationSummaryParams) => `From ${rootReportName}${workspaceName ? ` in ${workspaceName}` : ''}`,
    },
    qrCodes: {
-        copy: 'Copy',
+        copy: 'Copy URL',


Is this discussed?
Seems like "Copy" was approved by marketing team here

Taken from Figma cc @shawnborton @dubielzyk-expensify

Also ccing @jamesdeanexpensify

Got it, I guess we should go with Copy. Though I feel like "Copy URL" is more appropriate, because that's what actually happens. You don't copy the image, you copy the url (I think). cc @trjExpensify @dannymcclain for thoughts too

That's fair. If it just says "Copy" I'd personally expect it to copy the full image somehow, but that's what "Download" does already, so I can see us being a bit more specific there.

Cool, let's do Copy URL then. Thanks James!

shawnborton · 2024-02-09T16:50:10Z

can y'all help me verify if we want there to be 0px of padding on the content area (like in Figma) or 12px (like in the current build). I saw that Jon mentioned something about this on a different issue as well, so I just want to make sure we're all aligned.

Oh boy I don't have strong feelings there. I can see an argument that we should just standardize on 12px everywhere, no matter what? Personally I like the little bit of extra fluffiness, so my vote would be 12px!

situchan · 2024-02-09T17:00:52Z

@filip-solecki let's just add 12px. Then I think we can ship. Also apply to Profile page to be consistent

filip-solecki · 2024-02-09T17:25:57Z

@situchan - Added!

situchan

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

shawnborton · 2024-02-09T18:50:08Z

Feels good to me!

filip-solecki · 2024-02-09T20:11:00Z

@blimpich I guess it is all yours! 😄

blimpich

OSBotify · 2024-02-09T20:27:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-12T14:22:40Z

🚀 Deployed to staging by https://github.com/blimpich in version: 1.4.40-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	failure ❌

OSBotify · 2024-02-13T18:28:01Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.40-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	failure ❌

Share Code page adjustments

ad1bb7d

filip-solecki changed the title ~~Share Code page adjustments~~ Share Code page update Feb 8, 2024

Fix transaltions

9c17c44

kosmydel reviewed Feb 8, 2024

View reviewed changes

src/components/ContextMenuItem.tsx Outdated Show resolved Hide resolved

Update src/components/ContextMenuItem.tsx

e753e3d

Co-authored-by: Jakub Kosmydel <[email protected]>

filip-solecki marked this pull request as ready for review February 8, 2024 12:42

filip-solecki requested a review from a team as a code owner February 8, 2024 12:42

melvin-bot bot removed the request for review from a team February 8, 2024 12:42

melvin-bot bot requested a review from blimpich February 8, 2024 12:42

kosmydel approved these changes Feb 8, 2024

View reviewed changes

blimpich requested a review from situchan February 8, 2024 18:57

mountiny self-requested a review February 8, 2024 20:18

mountiny assigned filip-solecki Feb 8, 2024

mountiny added the Ready To Build label Feb 8, 2024

Full width QRCode

f2fb11d

Remove top margin

29c9d4e

situchan reviewed Feb 9, 2024

View reviewed changes

shawnborton mentioned this pull request Feb 9, 2024

[Update Account Settings] Preferences, About, Security #35672

Merged

58 tasks

Add top padding for profile i shareCode

f565b02

situchan approved these changes Feb 9, 2024

View reviewed changes

blimpich approved these changes Feb 9, 2024

View reviewed changes

blimpich merged commit 73731f1 into Expensify:main Feb 9, 2024
16 checks passed

github-actions bot mentioned this pull request Feb 12, 2024

Deploy Checklist: New Expensify 2024-02-12 #36335

Closed

90 tasks

melvin-bot bot mentioned this pull request Feb 13, 2024

[HOLD for payment 2024-02-20] [Wave8] [Account Settings] Update Share Code page #35605

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Share Code page update #36120

Share Code page update #36120

filip-solecki commented Feb 8, 2024 •

edited by mountiny

Loading

melvin-bot bot commented Feb 8, 2024

filip-solecki commented Feb 8, 2024

shawnborton commented Feb 8, 2024

shawnborton commented Feb 8, 2024

shawnborton commented Feb 8, 2024

mountiny commented Feb 8, 2024

mountiny commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

dubielzyk-expensify commented Feb 8, 2024

filip-solecki commented Feb 9, 2024

filip-solecki commented Feb 9, 2024

dannymcclain commented Feb 9, 2024

kosmydel commented Feb 9, 2024

dannymcclain commented Feb 9, 2024

situchan Feb 9, 2024

filip-solecki Feb 9, 2024

situchan Feb 9, 2024

shawnborton Feb 9, 2024

jamesdeanexpensify Feb 9, 2024

shawnborton Feb 9, 2024

shawnborton commented Feb 9, 2024

situchan commented Feb 9, 2024 •

edited

Loading

filip-solecki commented Feb 9, 2024

situchan left a comment

shawnborton commented Feb 9, 2024

filip-solecki commented Feb 9, 2024

blimpich left a comment

OSBotify commented Feb 9, 2024

OSBotify commented Feb 12, 2024

OSBotify commented Feb 13, 2024

Share Code page update #36120

Share Code page update #36120

Conversation

filip-solecki commented Feb 8, 2024 • edited by mountiny Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 8, 2024

filip-solecki commented Feb 8, 2024

shawnborton commented Feb 8, 2024

shawnborton commented Feb 8, 2024

shawnborton commented Feb 8, 2024

mountiny commented Feb 8, 2024

mountiny commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

dubielzyk-expensify commented Feb 8, 2024

filip-solecki commented Feb 9, 2024

filip-solecki commented Feb 9, 2024

dannymcclain commented Feb 9, 2024

kosmydel commented Feb 9, 2024

dannymcclain commented Feb 9, 2024

situchan Feb 9, 2024

Choose a reason for hiding this comment

filip-solecki Feb 9, 2024

Choose a reason for hiding this comment

situchan Feb 9, 2024

Choose a reason for hiding this comment

shawnborton Feb 9, 2024

Choose a reason for hiding this comment

jamesdeanexpensify Feb 9, 2024

Choose a reason for hiding this comment

shawnborton Feb 9, 2024

Choose a reason for hiding this comment

shawnborton commented Feb 9, 2024

situchan commented Feb 9, 2024 • edited Loading

filip-solecki commented Feb 9, 2024

situchan left a comment

Choose a reason for hiding this comment

Reviewer Checklist

Screenshots/Videos

shawnborton commented Feb 9, 2024

filip-solecki commented Feb 9, 2024

blimpich left a comment

Choose a reason for hiding this comment

OSBotify commented Feb 9, 2024

OSBotify commented Feb 12, 2024

OSBotify commented Feb 13, 2024

filip-solecki commented Feb 8, 2024 •

edited by mountiny

Loading

situchan commented Feb 9, 2024 •

edited

Loading