[Update Account Settings] Preferences, About, Security #35672

kosmydel · 2024-02-02T14:59:11Z

Details

Update all pages in AccountSettings that use illustrations according to the new designs:

Preferences,
Security,
About.

It also this minor regression.

And it also adds missing icons in the Account Settings.

Fixed Issues

$ #35606
$ #35607
$ #35608
$ #35905
$ #36246
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console
Go to Account Settings and verify.
- Preferences Page
- Security Page
- About Page
- Link icons on the LHN menu (Help & Go to Expensify Classic).
Verify the new designs.
Verify the translations (Spanish and English).

Offline tests

N/A

QA Steps

Verify that no errors appear in the JS console
Tests from above

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

src/languages/en.ts

src/components/LottieAnimations/index.tsx

src/pages/settings/Preferences/PreferencesPage.js

kosmydel · 2024-02-08T10:45:48Z

The PR is ready for review.

However, I found one issue with StatusBar:

The StatusBar is not updating after the theme is changed. Previously it worked, because we didn't have to change the status bar color when changing the theme (both light and dark themes used the blue status bar color to match the illustration background). Now, as the illustration is no longer stuck to the header, we need to switch the colors of the status bar, which apparently doesn't work.

I can see that there are some other issues related to StatusBar, maybe someone who worked with this component closer could have a look?
cc @hayata-suenaga, @mountiny

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-02-08.at.11.16.48.mp4

…t' into update-account-settings/preferences

kosmydel · 2024-02-09T17:45:07Z

@kosmydel This #35672 (comment) has not been addressed

0375e27

mountiny

Thanks for thorough testing, moving this ahead

mountiny · 2024-02-10T16:22:09Z

src/components/LottieAnimations/index.tsx

@@ -26,6 +27,7 @@ const DotLottieAnimations: Record<string, DotLottieAnimation> = {
        file: require('@assets/animations/PreferencesDJ.lottie'),
        w: 375,
        h: 240,
+        backgroundColor: colors.blue500,


I tmight be nice to add this as a follow up but I would say once we will need this dynamic which we dont right now as far as I know

src/components/CustomStatusBarAndBackground/index.tsx

mountiny

SignInPage tests need to be updated to mock the Navigation correctly after the updateStatusBarStyle change

ishpaul777 · 2024-02-11T19:02:59Z

Changes Suggested to resolve the Statusbar background color issue (not adding proposal because new changes needed are straightforward i belive can be done in the PR)

Remove these

App/src/styles/theme/themes/light.ts

Lines 95 to 98 in bfae5b2

    
           [SCREENS.HOME]: { 
        
               backgroundColor: colors.productLight200, 
        
               statusBarStyle: CONST.STATUS_BAR_STYLE.DARK_CONTENT, 
        
           },

App/src/styles/theme/themes/dark.ts

Lines 95 to 98 in bfae5b2

    
           [SCREENS.HOME]: { 
        
               backgroundColor: colors.productDark200, 
        
               statusBarStyle: CONST.STATUS_BAR_STYLE.LIGHT_CONTENT, 
        
           },

and adding this (for sign in page status bar)

[NAVIGATORS.BOTTOM_TAB_NAVIGATOR]: {
        backgroundColor: colors.productDark200,
        statusBarStyle: CONST.STATUS_BAR_STYLE.DARK_CONTENT,
}

and merging #34409 which solves #35672 (comment), #35672 (comment) and minor suggestions from Rory #34154 (comment)

Currently, the home screen has also wrong status bar color, but changing it breaks the insets on android.

Refreshing preference page on mWeb does not have correct status bar color

kosmydel · 2024-02-12T09:47:55Z

The performance tests are fixed. cc @mountiny

mountiny

Thank you

mountiny · 2024-02-12T23:09:22Z

Sorry for not getting to this sooner, please ping me in slack once you resolve conflicts

filip-solecki · 2024-02-13T07:53:25Z

@mountiny conflicts resolved

kosmydel · 2024-02-13T09:19:46Z

Changes Suggested to resolve the Statusbar background color issue (not adding proposal because new changes needed are straightforward i belive can be done in the PR)

@ishpaul777 I believe that this is out of the scope of this original issue. If we have dedicated PR (#34409) for handling the StatusBar we should focus on fixing all related issues there.

kosmydel · 2024-02-13T09:55:04Z

Some PR introduced "Mute all sounds from Expensify" switch. Can someone confirm if it looks ok? The Figma designs doesn't cover this case. If needed, please update the designs.

cc @shawnborton , @trjExpensify , @dubielzyk-expensify , @mountiny

mountiny

That looks good thank you

OSBotify · 2024-02-13T10:49:09Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

ishpaul777 · 2024-02-13T22:40:15Z

src/styles/theme/themes/light.ts

@@ -105,7 +105,7 @@ const lightTheme = {
            statusBarStyle: CONST.STATUS_BAR_STYLE.LIGHT_CONTENT,
        },
        [SCREENS.SETTINGS.PREFERENCES.ROOT]: {
-            backgroundColor: colors.blue500,
+            backgroundColor: colors.productLight100,
            statusBarStyle: CONST.STATUS_BAR_STYLE.LIGHT_CONTENT,


this should be in dark mode i think

statusBarStyle: CONST.STATUS_BAR_STYLE.DARK_CONTENT,

Screen.Recording.2024-02-14.at.4.08.20.AM.mov

@kosmydel

OSBotify · 2024-02-15T05:24:10Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.41-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

redesign preferences page

0f80d69

kosmydel changed the title ~~Update account settings/preferences~~ [Update Account Settings] Preferences Feb 2, 2024

kosmydel added 2 commits February 5, 2024 12:47

Merge branch 'Expensify:main' into update-account-settings/preferences

d836214

new about page design

bd0d930

kosmydel commented Feb 5, 2024

View reviewed changes

src/languages/en.ts Outdated Show resolved Hide resolved

trjExpensify assigned kosmydel Feb 5, 2024

kosmydel added 4 commits February 6, 2024 08:36

add english copy

beebe04

add Spanish copy

1b2d2a7

Merge branch 'main' into update-account-settings/preferences

9571905

rename

4397fc5

kosmydel mentioned this pull request Feb 7, 2024

[Update Account Settings] Header: icons, height, and font changes #35564

Merged

62 tasks

kosmydel added 6 commits February 7, 2024 19:05

small fixes

3124444

fix icon

3a8cd2d

fix illustration height

330fb72

Merge branch 'main' into update-account-settings/preferences

9f2b8f8

fix statusbar color on mWeb iOS

1d0e5a9

fix lint

c74a873

blazejkustra reviewed Feb 8, 2024

View reviewed changes

src/components/LottieAnimations/index.tsx Outdated Show resolved Hide resolved

src/pages/settings/Preferences/PreferencesPage.js Outdated Show resolved Hide resolved

improve types

715eacd

kosmydel requested a review from blazejkustra February 8, 2024 10:28

kosmydel added 2 commits February 8, 2024 11:37

fix workspace list empty state

426632c

fix

b6d1789

kosmydel mentioned this pull request Feb 8, 2024

[HOLD for payment 2024-02-19] [$500] [Wave 8] [Ideal Nav] The color of Status Bar (top part of the background) is not consistent #35632

Closed

6 tasks

blazejkustra approved these changes Feb 8, 2024

View reviewed changes

kosmydel added 2 commits February 8, 2024 12:37

Merge remote-tracking branch 'origin-swm/update-account-settings/abou…

3601b3f

…t' into update-account-settings/preferences

fix About page status bar

3e44c6f

kosmydel changed the title ~~[Update Account Settings] Preferences~~ [Update Account Settings] Preferences, About, Security Feb 8, 2024

filip-solecki and others added 2 commits February 8, 2024 12:49

Security page update

3769321

fix lint issues

028d355

s77rt approved these changes Feb 9, 2024

View reviewed changes

melvin-bot bot requested a review from marcochavezf February 9, 2024 17:52

Merge branch 'main' into update-account-settings/preferences

a9ef0cc

mountiny approved these changes Feb 10, 2024

View reviewed changes

mountiny reviewed Feb 10, 2024

View reviewed changes

src/components/CustomStatusBarAndBackground/index.tsx Show resolved Hide resolved

mountiny requested changes Feb 10, 2024

View reviewed changes

kosmydel added 3 commits February 12, 2024 09:48

Merge branch 'Expensify:main' into update-account-settings/preferences

f2ca240

attempt to fix the SignInPage-perf test

5e5bce0

fix perf tests

4f30355

mountiny previously approved these changes Feb 12, 2024

View reviewed changes

Merge branch 'main' into update-account-settings/preferences

404b3c5

filip-solecki dismissed mountiny’s stale review via 404b3c5 February 13, 2024 07:32

ZhenjaHorbach mentioned this pull request Feb 13, 2024

[HOLD for payment 2024-03-07] [$500] Top part of the page becomes darker when user goes to the chats page #36385

Closed

6 tasks

mountiny approved these changes Feb 13, 2024

View reviewed changes

mountiny merged commit 4f1521c into Expensify:main Feb 13, 2024
16 checks passed

github-actions bot mentioned this pull request Feb 13, 2024

Deploy Checklist: New Expensify 2024-02-13 #36429

Closed

ishpaul777 reviewed Feb 13, 2024

View reviewed changes

tgolen mentioned this pull request Feb 13, 2024

[HOLD for payment 2024-02-26] [$500] About - Footer text has no bottom margin #36444

Closed

6 tasks

filip-solecki mentioned this pull request Feb 14, 2024

[CP Staging] Add bottom margin to About Page and fix Status Bar color on Preferences Page #36452

Merged

50 tasks

TMisiukiewicz mentioned this pull request Feb 14, 2024

feat: Troubleshooting page & resetting Onyx state #35306

Merged

50 tasks

s77rt mentioned this pull request Feb 21, 2024

[Awaiting Payment 20th Feb] [Wave8] [Account Settings] Update Preferences page #35606

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Update Account Settings] Preferences, About, Security #35672

[Update Account Settings] Preferences, About, Security #35672

kosmydel commented Feb 2, 2024 •

edited by marcochavezf

Loading

kosmydel commented Feb 8, 2024

kosmydel commented Feb 9, 2024

mountiny left a comment

mountiny Feb 10, 2024

mountiny left a comment

ishpaul777 commented Feb 11, 2024 •

edited

Loading

kosmydel commented Feb 12, 2024

mountiny left a comment

mountiny commented Feb 12, 2024

filip-solecki commented Feb 13, 2024

kosmydel commented Feb 13, 2024 •

edited

Loading

Changes Suggested to resolve the Statusbar background color issue (not adding proposal because new changes needed are straightforward i belive can be done in the PR)

kosmydel commented Feb 13, 2024

mountiny left a comment

OSBotify commented Feb 13, 2024

ishpaul777 Feb 13, 2024 •

edited

Loading

filip-solecki Feb 14, 2024

OSBotify commented Feb 15, 2024

[Update Account Settings] Preferences, About, Security #35672

[Update Account Settings] Preferences, About, Security #35672

Conversation

kosmydel commented Feb 2, 2024 • edited by marcochavezf Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

kosmydel commented Feb 8, 2024

kosmydel commented Feb 9, 2024

mountiny left a comment

Choose a reason for hiding this comment

mountiny Feb 10, 2024

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

ishpaul777 commented Feb 11, 2024 • edited Loading

Changes Suggested to resolve the Statusbar background color issue (not adding proposal because new changes needed are straightforward i belive can be done in the PR)

kosmydel commented Feb 12, 2024

mountiny left a comment

Choose a reason for hiding this comment

mountiny commented Feb 12, 2024

filip-solecki commented Feb 13, 2024

kosmydel commented Feb 13, 2024 • edited Loading

Changes Suggested to resolve the Statusbar background color issue (not adding proposal because new changes needed are straightforward i belive can be done in the PR)

kosmydel commented Feb 13, 2024

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Feb 13, 2024

ishpaul777 Feb 13, 2024 • edited Loading

Choose a reason for hiding this comment

filip-solecki Feb 14, 2024

Choose a reason for hiding this comment

OSBotify commented Feb 15, 2024

kosmydel commented Feb 2, 2024 •

edited by marcochavezf

Loading

ishpaul777 commented Feb 11, 2024 •

edited

Loading

kosmydel commented Feb 13, 2024 •

edited

Loading

ishpaul777 Feb 13, 2024 •

edited

Loading