Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] [HOLD for payment 2023-12-28] [Wave 6: Referral Program] Move "Download" above "Get $250" on "Share code" screen #32282

Closed
jamesdeanexpensify opened this issue Nov 30, 2023 · 18 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors NewFeature Something to build that is a new item.

Comments

@jamesdeanexpensify
Copy link
Contributor

jamesdeanexpensify commented Nov 30, 2023

Background

Based on this conversation, we'd like to adjust the order of the options on the "Share code" screen. More specifically, let's:

  • Keep "Copy URL to clipboard" in first position
  • Move "Download" to second position
  • Move "Get $250" to third position

image

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0146d9e7fec0e7dec0
  • Upwork Job ID: 1742049375416360960
  • Last Price Increase: 2024-01-02
@waterim
Copy link
Contributor

waterim commented Nov 30, 2023

Hey, Im Artem from Callstack and would like to help with this issue

@puneetlath puneetlath added the NewFeature Something to build that is a new item. label Nov 30, 2023
Copy link

melvin-bot bot commented Nov 30, 2023

@sakluger
Copy link
Contributor

Thanks @waterim!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Dec 1, 2023
Copy link

melvin-bot bot commented Dec 1, 2023

Triggered auto assignment to @dangrous, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@jamesdeanexpensify
Copy link
Contributor Author

In this same issue, is it also possible to update "Copy URL to clipboard" to just say "Copy"? Thanks!

@dangrous
Copy link
Contributor

dangrous commented Dec 5, 2023

@waterim since we already merged your PR, can you raise another to update the text as above ^ ? Thank you!

@dangrous
Copy link
Contributor

bump @waterim if you think you might have time! If not I can grab this quickly later this week

@waterim
Copy link
Contributor

waterim commented Dec 13, 2023

@dangrous I can take it today!

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Dec 13, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 21, 2023
@melvin-bot melvin-bot bot changed the title [Wave 6: Referral Program] Move "Download" above "Get $250" on "Share code" screen [HOLD for payment 2023-12-28] [Wave 6: Referral Program] Move "Download" above "Get $250" on "Share code" screen Dec 21, 2023
Copy link

melvin-bot bot commented Dec 21, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 21, 2023
Copy link

melvin-bot bot commented Dec 21, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Dec 21, 2023

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@aimane-chnaif] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Dec 27, 2023
Copy link

melvin-bot bot commented Jan 1, 2024

@dangrous, @sakluger, @waterim, @aimane-chnaif Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Jan 1, 2024

@dangrous, @sakluger, @waterim, @aimane-chnaif Huh... This is 4 days overdue. Who can take care of this?

@sakluger sakluger added the External Added to denote the issue can be worked on by a contributor label Jan 2, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-12-28] [Wave 6: Referral Program] Move "Download" above "Get $250" on "Share code" screen [$500] [HOLD for payment 2023-12-28] [Wave 6: Referral Program] Move "Download" above "Get $250" on "Share code" screen Jan 2, 2024
Copy link

melvin-bot bot commented Jan 2, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0146d9e7fec0e7dec0

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 2, 2024
Copy link

melvin-bot bot commented Jan 2, 2024

Current assignee @aimane-chnaif is eligible for the External assigner, not assigning anyone new.

@sakluger
Copy link
Contributor

sakluger commented Jan 2, 2024

@aimane-chnaif I've sent you an offer via Upwork. Could you please let me know once you've accepted the offer? Thanks!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 2, 2024
@sakluger
Copy link
Contributor

sakluger commented Jan 4, 2024

@aimane-chnaif friendly bump.

@melvin-bot melvin-bot bot removed the Overdue label Jan 4, 2024
@sakluger
Copy link
Contributor

sakluger commented Jan 5, 2024

All paid, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors NewFeature Something to build that is a new item.
Projects
No open projects
Development

No branches or pull requests

6 participants