Deploy Checklist: New Expensify 2024-10-03

[github-actions]

Release Version: 9.0.44-12
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Map upwork data #45100
• De-dupe ReconnectApp in the persisted requests queue #47913
• fix: apply optimistic updates from READ requests immediately #48057
• fix: requires validate when opening bank account #49230
• fix: migrate withFullTransactionOrNotFound to useOnyx #49248
• Migrate AccessOrNotFoundWrapper from withOnyx to useOnyx #49251
• [No QA] Callable buildAndroid workflow #49434
• Refactor on missing details flow #49452
• Add recent serches and recent chats in Search router #49457
• fix: Combined report is more grayed #49633
• Fix task title is overflown and align the checkbox and arrow correctly #49686
• fix: Sluggish animation when selecting a different type #49736
• Invoicing verify that the user has the feature enabled on the page  #49843
• Bump Onyx to v2.0.71 #49857
• Fix - Saved search - Unable to delete saved search using Enter key #49864
• Add the workspace name to the title of the workspace chats #49911
• fix: Web - Settings is opened on the left with a conversation opened on the right. #49914
• Feat: Retain the option to Pay elsewhere on processing/submitted reports when payments get disabled #49967
• Fix holding on a message in search page scrolls the page #49970
• Add files for Billing pages on ND #50005
• Create Adding-a-payment-card and subscription-management.md #50007
• Search highlight and scroll animation refactoring for 49457 #50028
• Move Switch to Expensify Classic Button down #50029
• [Snyk] Upgrade electron-updater from 6.3.4 to 6.3.5 #50036
• Update Set-up-workflows.md with Images  #50041
• Fix failed to load pdf when the file name contains accented character #50043
• [NoQA] Update e2e dev instructions #50049
• [Guided Setup Stage 3] Onboarding message not sent when VBBA selected #50052
• Create Finland-per-diem.csv #50054
• [CP] don't show just track it option unless coming from CREATE flow #50068
• [Fix] Search - Expenses are not highlighted when selected #50089
• Update issue template to have a proper expand/collapse for screenshots #50102
• [No QA] Callable buildIOS workflow #50123
• Fix performance of SearchRouter #50143
• [HybridApp] Adjust NewDot to new boot behaviour on iOS #50144
• fix: error not shown, redirect incorrectly on add bank account #50171
• [CP Staging] prevent removing waypoint if it is unnecessary #50184
• [No QA] Use keystore in build job, json key in upload job #50189
• [CP Staging] Fix categories settings page always show loader when open the page #50226
• Revert "Fix task title is overflown and align the checkbox and arrow correctly" #50255
• Revert "fix: migrate withFullTransactionOrNotFound to useOnyx" #50266
• [CP Staging] Revert "[No QA] Callable buildIOS workflow" #50268

Deploy Blockers:

• [HOLD for payment 2024-10-11] [HOLD for payment 2024-10-10] Bank account - Company website field appears empty on company info confirmation page #50086
• [HOLD for payment 2024-10-14] [HOLD for payment 2024-10-11] [Performance] Investigate performance regression to app open time (reported by e2e system) #50141
• Fix performance of SearchRouter #50143
• Sign up - App freezes after logging in with a new Expensifail account #50149
• [HOLD for payment 2024-10-14] [HOLD for payment 2024-10-11] Sign up - No error indicating that magic code is incorrect when validating account via Wallet #50150
• [HOLD for payment 2024-10-14] Task - Green dot is not on the same line as the caret #50151
• [HOLD for payment 2024-10-14] [HOLD for payment 2024-10-11] [Payment due] Sign up - Validate your account page opens after validating account and adding bank account #50153
• [HOLD for payment 2024-10-14] [HOLD for payment 2024-10-11] RHP across the app cannot be closed by ESC key #50156
• [HOLD for payment 2024-10-16] [$250] Expense - Add receipt modal disappears and then reappears after the receipt is deleted #50159
• [HOLD for payment 2024-11-28] IOU - Web - Console error when selecting pay with Business bank account as recipient #50166
• Status- Date "Clear After" of Status is Unstable #50170
• "ReconnectApp" isn't showing up in Chrome network tab when switching chats #50172
• [HOLD for payment 2024-10-14] [HOLD for payment 2024-10-11] [$250] Distance - Waypoints change to duplicate waypoints after drag and drop waypoints #50176
• [$250] Task - Task name not updated in chat when it got changed offline #50209
• [HOLD for payment 2024-10-14] [HOLD for payment 2024-10-11] Categories - Settings RHP shows spinner briefly when it is opened #50212
• [$250] [HOLD for payment 2024-10-17] Xero - Accounting page reloads when 2FA setup RHP opens #50213
• [HOLD for payment 2024-10-24] Expense - Report view changes to Wallet page when Add bank account RHP opens #50214
• [HOLD for payment 2024-11-14] [$250] Track expense - Add receipt modal is missing on confirmation page when sharing with accountant #50246

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.0.44-0 🚀

[rlinoz]

Demoting #50151

[jasperhuangg]

Demoted #50159

[jasperhuangg]

Demoting #50166

[mvtglobally]

Regression is 30% complete

Blockers
#50141
#50149
#50150
#50153
#50156

[jasperhuangg]

Demoted #50149

[jasperhuangg]

Demoted #50170

[jasperhuangg]

#50156 was fixed

[roryabraham]

50172 is expected behavior

[mvtglobally]

Regression is 65% Completed

#47913 - failing with #50172
#49452 - Pending validation on mWeb/Native Apps
#49457 - failing, raising the issue in a bit
#49967 - Pending validation on IOS
#50052 - Is failing with #50166

Checking CPs

Blockers
#50141
#50150
#50153
#50176

[jasperhuangg]

#50141 was fixed

[mvtglobally]

Regression is at 20% left

[Beamanator]

checked off deploy blocker #50176 b/c it was fixed by #50184 in staging (checked off that one too)

[mvtglobally]

Regression is at last 1% left

PRs
#47913 - failing with #50172
#49457 - failing with #50220. Repro in PROD, we are blocked for this. Are we ok to check it off?
#49967 - failing #50180. Repro in PROD. checking off
#50052 - Is failing with #50166
#50143 - is failing with #50220. unable to verify as router is not present

[jasperhuangg]

Demoting #50213

[jasperhuangg]

#50214 was demoted

[mvtglobally]

Regression is completed

Blockers
#50209
#50212
#50246

Unchecked PRs
#47913 - failing with #50172
#49457 - failing with #50220. Repro in PROD, we are blocked for this. Are we ok to check it off?
#50052 - Is failing with #50166
#50143 - is failing with #50220. unable to verify as router is not present
checking CP #50226

[jasperhuangg]

#50212
#50209

Both were fixed

[jasperhuangg]