fix: error not shown, redirect incorrectly on add bank account #50171

daledah · 2024-10-03T16:56:21Z

Details

Fixed Issues

$ #50150
$ #50153
PROPOSAL:

Tests

Navigate to Wallet page -> add bank account
Enter a wrong code
Verify that: error appears
Clear error, enter correct code
Finish add bank account flow
Verify that: user is navigated to wallet page.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Navigate to Wallet page -> add bank account
Enter a wrong code
Verify that: error appears
Clear error, enter correct code
Finish add bank account flow
Verify that: user is navigated to wallet page.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-04.at.00.06.22.mp4

Android: mWeb Chrome

Screen.Recording.2024-10-04.at.00.13.18.mp4

iOS: Native

Screen.Recording.2024-10-04.at.00.17.18.mp4

iOS: mWeb Safari

Screen.Recording.2024-10-04.at.00.31.52.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-10-03.at.23.53.15.mp4

MacOS: Desktop

Screen.Recording.2024-10-04.at.00.35.59.mp4

src/components/ValidateCodeActionModal/ValidateCodeForm/BaseValidateCodeForm.tsx

daledah · 2024-10-03T17:43:31Z

@jasperhuangg I'm having trouble in connecting bank account in IOS native, as plaid always redirect me to the main bank page instead of first platypus bank. Can you help resolve this or should we open the PR anyway?

arosiclair · 2024-10-03T17:54:38Z

I can start the checklist if you think everything is ready

daledah · 2024-10-03T17:56:19Z

@arosiclair Do you think the ios screenshot would be a problem? I believe the changes should work but I can't have a screenshot for it. The current ios screenshot provided only has the fix for the error bug.

arosiclair · 2024-10-03T17:59:51Z

I'll give it a test on iOS. It's probably easier for me to test bank account flows. If it works on my end we're good 👍

melvin-bot · 2024-10-03T18:00:07Z

@abdulrahuman5196 @jasperhuangg One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

daledah · 2024-10-03T18:00:13Z

@arosiclair Thanks! Opening the PR now!

jasperhuangg · 2024-10-03T18:32:09Z

@arosiclair Any luck with that iOS test?

arosiclair · 2024-10-03T18:45:11Z

It's probably easier for me to test bank account flows.

Maybe this isn't true 😅. I'm stuck on this throttling message:

This shouldn't happen in dev, but nothing I change prevents it. We can get a C+ to test or @jasperhuangg you can give it a try if you want.

arosiclair · 2024-10-03T18:55:27Z

@ishpaul777 should be able to finish the checklist 🙏

ishpaul777 · 2024-10-03T18:55:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-04.at.1.15.08.AM.mov

Screen.Recording.2024-10-04.at.1.13.29.AM.mov

Android: mWeb Chrome

WhatsApp.Video.2024-10-04.at.1.13.35.AM.mp4

.08 AM.mov…

iOS: Native

Screen.Recording.2024-10-04.at.1.07.11.AM.mov

Screen.Recording.2024-10-04.at.1.01.42.AM.mov

iOS: mWeb Safari

trim.29D71717-587A-4897-8C51-EBA148845952.MOV

trim.634F19B7-F3FA-40DC-B96E-6C2455A4C10C.MOV

MacOS: Chrome / Safari

Screen.Recording.2024-10-04.at.12.48.19.AM.mov

Screen.Recording.2024-10-04.at.12.49.14.AM.mov

MacOS: Desktop

Screen.Recording.2024-10-04.at.1.23.17.AM.mov

Screen.Recording.2024-10-04.at.1.25.01.AM.mov

ishpaul777

lgtm!

jasperhuangg · 2024-10-03T19:59:22Z

Something is wrong with that check, the checklist is clearly right here

OSBotify · 2024-10-03T20:09:45Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

fix: error not shown, redirect incorrectly on add bank account (cherry picked from commit 238f978) (CP triggered by jasperhuangg)

arosiclair · 2024-10-03T21:01:50Z

This looks good on staging!

Screen.Recording.2024-10-03.at.4.55.22.PM.mov

Screen.Recording.2024-10-03.at.4.58.10.PM.mov

github-actions · 2024-10-03T21:14:54Z

🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.0.44-5 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2024-10-04T20:59:25Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.44-12 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: error not shown, redirect incorrectly on add bank account

4d02e0b

daledah mentioned this pull request Oct 3, 2024

[HOLD for payment 2024-10-14] [HOLD for payment 2024-10-11] Sign up - No error indicating that magic code is incorrect when validating account via Wallet #50150

Closed

6 tasks

jasperhuangg requested review from arosiclair and jasperhuangg October 3, 2024 17:03

jasperhuangg requested changes Oct 3, 2024

View reviewed changes

src/components/ValidateCodeActionModal/ValidateCodeForm/BaseValidateCodeForm.tsx Outdated Show resolved Hide resolved

fix: remove eslint disable line

392d5d7

arosiclair marked this pull request as ready for review October 3, 2024 18:00

arosiclair requested a review from a team as a code owner October 3, 2024 18:00

melvin-bot bot requested review from abdulrahuman5196 and jasperhuangg and removed request for a team October 3, 2024 18:00

This comment was marked as duplicate.

Sign in to view

arosiclair removed the request for review from abdulrahuman5196 October 3, 2024 18:00

jasperhuangg approved these changes Oct 3, 2024

View reviewed changes

arosiclair requested a review from ishpaul777 October 3, 2024 18:55

arosiclair approved these changes Oct 3, 2024

View reviewed changes

ishpaul777 approved these changes Oct 3, 2024

View reviewed changes

melvin-bot bot requested a review from jasperhuangg October 3, 2024 19:52

jasperhuangg approved these changes Oct 3, 2024

View reviewed changes

jasperhuangg merged commit 238f978 into Expensify:main Oct 3, 2024
15 of 19 checks passed

OSBotify pushed a commit that referenced this pull request Oct 3, 2024

Merge pull request #50171 from daledah/fix/50150

75ea170

fix: error not shown, redirect incorrectly on add bank account (cherry picked from commit 238f978) (CP triggered by jasperhuangg)

github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Oct 3, 2024

github-actions bot mentioned this pull request Oct 3, 2024

Deploy Checklist: New Expensify 2024-10-03 #50125

Closed

63 tasks

melvin-bot bot mentioned this pull request Oct 4, 2024

[HOLD for payment 2024-10-14] [HOLD for payment 2024-10-11] [Payment due] Sign up - Validate your account page opens after validating account and adding bank account #50153

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: error not shown, redirect incorrectly on add bank account #50171

fix: error not shown, redirect incorrectly on add bank account #50171

daledah commented Oct 3, 2024 •

edited

Loading

daledah commented Oct 3, 2024 •

edited

Loading

arosiclair commented Oct 3, 2024

daledah commented Oct 3, 2024 •

edited

Loading

arosiclair commented Oct 3, 2024

melvin-bot bot commented Oct 3, 2024

daledah commented Oct 3, 2024

This comment was marked as duplicate.

jasperhuangg commented Oct 3, 2024

arosiclair commented Oct 3, 2024

arosiclair commented Oct 3, 2024

ishpaul777 commented Oct 3, 2024 •

edited by jasperhuangg

Loading

ishpaul777 left a comment

jasperhuangg commented Oct 3, 2024

OSBotify commented Oct 3, 2024

arosiclair commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

github-actions bot commented Oct 4, 2024

fix: error not shown, redirect incorrectly on add bank account #50171

fix: error not shown, redirect incorrectly on add bank account #50171

Conversation

daledah commented Oct 3, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

daledah commented Oct 3, 2024 • edited Loading

arosiclair commented Oct 3, 2024

daledah commented Oct 3, 2024 • edited Loading

arosiclair commented Oct 3, 2024

melvin-bot bot commented Oct 3, 2024

daledah commented Oct 3, 2024

This comment was marked as duplicate.

jasperhuangg commented Oct 3, 2024

arosiclair commented Oct 3, 2024

arosiclair commented Oct 3, 2024

ishpaul777 commented Oct 3, 2024 • edited by jasperhuangg Loading

Reviewer Checklist

Screenshots/Videos

ishpaul777 left a comment

Choose a reason for hiding this comment

jasperhuangg commented Oct 3, 2024

OSBotify commented Oct 3, 2024

arosiclair commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

github-actions bot commented Oct 4, 2024

daledah commented Oct 3, 2024 •

edited

Loading

daledah commented Oct 3, 2024 •

edited

Loading

daledah commented Oct 3, 2024 •

edited

Loading

ishpaul777 commented Oct 3, 2024 •

edited by jasperhuangg

Loading