Refactor on missing details flow #49452

shubham1206agra · 2024-09-19T09:46:25Z

Details

Fixed Issues

$ #48487

Tests

Issue Expensify card where personal details for workspace member who does not have all the personal details set
Observe you see a Add personal details button in Workspace chat.
Click on Add personal details, and fill the details.
Observe that your private personal details got filled, and you no longer see Add personal details button.

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2024-10-01.at.6.37.45.PM.mov

iOS: Native

Screen.Recording.2024-10-01.at.7.12.55.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-10-01.at.12.12.52.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-01.at.12.02.49.PM.mov

MacOS: Desktop

Screen.Recording.2024-10-01.at.7.00.10.PM.mov

shubham1206agra · 2024-09-19T10:40:05Z

@allgandalf Please start review here.

cc @mountiny

mountiny · 2024-09-21T08:10:27Z

Running a test build. @allgandalf are you going to be able to take this review and testing?

allgandalf · 2024-09-21T08:13:37Z

Running a test build. @allgandalf are you going to be able to take this review and testing?

For sure! I will review later today/tomorrow

github-actions · 2024-09-21T08:45:23Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/49452/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/49452/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/49452/NewExpensify.dmg	https://49452.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

allgandalf · 2024-09-24T07:59:12Z

@shubham1206agra what's your ETA for this PR?

allgandalf

Just overviewed the code, will review in depth once this is marked as ready for review

src/libs/Navigation/linkingConfig/config.ts

src/pages/MissingPersonalDetails/index.tsx

shubham1206agra · 2024-09-24T08:19:08Z

@shubham1206agra what's your ETA for this PR?

@allgandalf I need you to first go through entire flow for bugs. If no bugs are found, I will finish the checklist.

allgandalf · 2024-09-24T13:50:44Z

@shubham1206agra please fix the ESLint error

shubham1206agra · 2024-09-24T13:53:45Z

This error is unrelated to this PR

allgandalf · 2024-09-24T13:54:59Z

so are we going to suppress that error ?

shubham1206agra · 2024-09-24T13:57:37Z

Ignore the error

allgandalf · 2024-09-24T14:04:57Z

BUG: No address auto recommendation, we get `no result found`:

Screen.Recording.2024-09-24.at.7.33.41.PM.mov

shubham1206agra · 2024-09-24T14:07:11Z

BUG: No address auto recommendation, we get no result found:

Screen.Recording.2024-09-24.at.7.33.41.PM.mov

Have you confirmed this on main?

allgandalf · 2024-09-24T14:30:29Z

Bug: RHP gets dismissed if we refresh and press back button:

Screen.Recording.2024-09-24.at.7.59.03.PM.mov

allgandalf · 2024-09-24T14:30:47Z

Have you confirmed this on main?

Nope please check and let me know

allgandalf · 2024-09-24T14:58:24Z

This branch has conflicts @shubham1206agra

allgandalf · 2024-09-24T15:02:03Z

Can you also merge main @shubham1206agra , there is a infinite loader in personal details

Screen.Recording.2024-09-24.at.8.31.13.PM.mov

shubham1206agra · 2024-09-24T15:05:03Z

Bug: RHP gets dismissed if we refresh and press back button:

Screen.Recording.2024-09-24.at.7.59.03.PM.mov

Because you are on the first step

allgandalf · 2024-09-24T15:07:05Z

Because you are on the first step

Actual Bug

Wait so the actual bug is that we get to the first page whenever we refresh, we should stay on the same page whenever we refresh, please update accordingly

allgandalf · 2024-09-24T15:15:07Z

Bug

Whitespaces are not trimmed for legal name:

Empty spaces are visible on the confirmation page as well.

src/pages/MissingPersonalDetails/substeps/DateOfBirth.tsx

mountiny · 2024-10-01T22:25:45Z

@shubham1206agra There are some conflicts, can you please address them and then we can try to get through the review asap

I am not sure since I copied this spacing from VBBA flow.

While it's the same, can you help Jon by checking what is the spacing in the code? then we can adjust it in some future task (not here)

shubham1206agra · 2024-10-02T02:11:31Z

@shubham1206agra There are some conflicts, can you please address them and then we can try to get through the review asap

I am not sure since I copied this spacing from VBBA flow.

While it's the same, can you help Jon by checking what is the spacing in the code? then we can adjust it in some future task (not here)

@dubielzyk-expensify I am seeing marginTop: 24 being used.

dubielzyk-expensify · 2024-10-02T02:25:06Z

Can we change that to marginTop: 20 instead?

shubham1206agra · 2024-10-02T06:45:24Z

@dubielzyk-expensify Done

allgandalf · 2024-10-02T09:50:23Z

@shubham1206agra merge main, android build is broken on your branch

allgandalf · 2024-10-02T13:05:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-02.at.6.48.51.PM.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-10-02.at.6.40.06.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-10-02.at.6.42.22.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-02.at.6.34.39.PM.mov

MacOS: Desktop

Screen.Recording.2024-10-02.at.6.38.09.PM.mov

allgandalf

flow works.

@mountiny I leave the call to you if we want to merge this one with the failing workflow or we should fix that

mountiny

Just some small comments @shubham1206agra

src/hooks/usePersonalDetailsFormSubmit.ts

src/pages/MissingPersonalDetails/substeps/Confirmation.tsx

mountiny

Thanks!

src/components/ReportActionItem/IssueCardMessage.tsx

mountiny

Thanks!

OSBotify · 2024-10-02T15:12:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-03T03:53:55Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

isagoico · 2024-10-04T15:40:26Z

We tested this one and if this specifically for the Physical Card flow it's a pass 🎉 I'm checking in #qa if this should still happen when issuing a virtual card (my theory is not but just to be safe)

github-actions · 2024-10-04T20:58:01Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.44-12 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mountiny · 2024-10-06T20:08:57Z

Correct only physical!

shubham1206agra added 6 commits September 19, 2024 15:15

Refactor on missing details flow

67c8663

Fix minor bug

b10b565

Fixing wrong values

9d64d85

Fixing start index

3b30451

Fixing draft clearing

593ff73

Fix interactive substep

4e0b111

Removed useless code

2c64dc3

mountiny added the Ready To Build label Sep 21, 2024

allgandalf reviewed Sep 24, 2024

View reviewed changes

src/libs/Navigation/linkingConfig/config.ts Show resolved Hide resolved

src/pages/MissingPersonalDetails/index.tsx Outdated Show resolved Hide resolved

Merge branch 'main' into missing-details-flow-part2

a8fafb3

allgandalf reviewed Sep 24, 2024

View reviewed changes

src/pages/MissingPersonalDetails/substeps/DateOfBirth.tsx Show resolved Hide resolved

Merge main

97f01ff

shubham1206agra added 2 commits October 2, 2024 12:12

Fix margins

6ceff88

Fix margins

992745d

Merge branch 'Expensify:main' into missing-details-flow-part2

7042d0a

allgandalf approved these changes Oct 2, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny October 2, 2024 13:23

mountiny previously approved these changes Oct 2, 2024

View reviewed changes

Fix name of component

1be2186

shubham1206agra dismissed mountiny’s stale review via 1be2186 October 2, 2024 14:08

mountiny previously approved these changes Oct 2, 2024

View reviewed changes

mountiny reviewed Oct 2, 2024

View reviewed changes

src/components/ReportActionItem/IssueCardMessage.tsx Show resolved Hide resolved

Fix lint

9e424cb

shubham1206agra dismissed mountiny’s stale review via 9e424cb October 2, 2024 14:42

mountiny approved these changes Oct 2, 2024

View reviewed changes

mountiny merged commit 05dcac8 into Expensify:main Oct 2, 2024
18 checks passed

github-actions bot mentioned this pull request Oct 3, 2024

Deploy Checklist: New Expensify 2024-10-03 #50125

Closed

63 tasks

melvin-bot bot mentioned this pull request Oct 4, 2024

[$750] [HOLD for payment 2024-10-11] [Workspace Feeds] Create a new form for adding missing address and personal information data to ship a card #48487

Closed

allgandalf mentioned this pull request Oct 5, 2024

[HOLD for payment 2024-11-11] [$750] Netsuite - App navigates to the first flow when refreshing the page while adding custom list #49986

Closed

6 tasks

IuliiaHerets mentioned this pull request Oct 5, 2024

[$250] Card - 10 digit phone number isn't accepted when the member adds shipping details #50282

Closed

6 tasks

Refactor on missing details flow #49452

Refactor on missing details flow #49452

Conversation

shubham1206agra commented Sep 19, 2024 • edited by mountiny Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

shubham1206agra commented Sep 19, 2024

mountiny commented Sep 21, 2024

allgandalf commented Sep 21, 2024

github-actions bot commented Sep 21, 2024

allgandalf commented Sep 24, 2024

allgandalf left a comment

Choose a reason for hiding this comment

shubham1206agra commented Sep 24, 2024

allgandalf commented Sep 24, 2024

shubham1206agra commented Sep 24, 2024

allgandalf commented Sep 24, 2024

shubham1206agra commented Sep 24, 2024

allgandalf commented Sep 24, 2024

BUG: No address auto recommendation, we get no result found:

shubham1206agra commented Sep 24, 2024

BUG: No address auto recommendation, we get no result found:

allgandalf commented Sep 24, 2024

Bug: RHP gets dismissed if we refresh and press back button:

allgandalf commented Sep 24, 2024

allgandalf commented Sep 24, 2024

allgandalf commented Sep 24, 2024

shubham1206agra commented Sep 24, 2024

Bug: RHP gets dismissed if we refresh and press back button:

allgandalf commented Sep 24, 2024 • edited Loading

Actual Bug

allgandalf commented Sep 24, 2024

Bug

mountiny commented Oct 1, 2024

shubham1206agra commented Oct 2, 2024

dubielzyk-expensify commented Oct 2, 2024

shubham1206agra commented Oct 2, 2024

allgandalf commented Oct 2, 2024

allgandalf commented Oct 2, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

allgandalf left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 2, 2024

github-actions bot commented Oct 3, 2024

isagoico commented Oct 4, 2024 • edited Loading

github-actions bot commented Oct 4, 2024

mountiny commented Oct 6, 2024

shubham1206agra commented Sep 19, 2024 •

edited by mountiny

Loading

BUG: No address auto recommendation, we get `no result found`:

BUG: No address auto recommendation, we get `no result found`:

allgandalf commented Sep 24, 2024 •

edited

Loading

allgandalf commented Oct 2, 2024 •

edited

Loading

isagoico commented Oct 4, 2024 •

edited

Loading