[HOLD for payment 2024-10-11] [HOLD for payment 2024-10-10] Bank account - Company website field appears empty on company info confirmation page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.43-1
Reproducible in staging?: Y
Reproducible in production?: Unable to validate in Prod because of Bank Setup
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5032805
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Pre-requisite: with Expensifail account, user must have created a workspace and have enabled Workflows.

1. Go to Settings > Workspaces > Workspace > Workflows.
2. Click on "Connect bank account".
3. Select "Connect online with Plaid", use Regions bank and testing credentials.
4. Go trough the add bank account flow until you reach the Company info section.
5. Keep going trough the flow, when you reach the company website page, leave it as it is and click "Next".
6. Reach the confirmation page.

Expected Result:

Company website filed should be filled with default value on the confirmation page.

Actual Result:

Company website filed appears empty on the confirmation page.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6622243_1727882739579.bandicam_2024-10-02_11-15-32-633.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[gijoe0295]

Regression from #49957.

Remove the useEffect here got the default website value not being saved because the FormProvider wouldn't save default input value.

[jasperhuangg]

Thanks @gijoe0295, gonna get a revert up for that PR since it sounds like the proposal on that one is flawed.

[pecanoro]

I am reverting already 😄

[allgandalf]

We can close this issue once we CP the fix and re-test, this issue must be fixed now

[jasperhuangg]

PR is on staging, asking for retest here

[kavimuru]

Bug is not repro anymore

bandicam.2024-10-02.16-33-45-674.mp4

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.43-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging]: Fix: Company website field appears empty on company info confirmation page #50097

If no regressions arise, payment will be issued on 2024-10-10. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@pecanoro] The PR that introduced the bug has been identified. Link to the PR:
• [@pecanoro] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@pecanoro] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@pecanoro] Determine if we should create a regression test for this bug.
• [@pecanoro] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mallenexpensify]

Thanks, closing.
Posted on the other review and linked to this issue.

[allgandalf]

@mallenexpensify i guess you reopened this issue instead of closing 😅

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.44-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging]: Fix: Company website field appears empty on company info confirmation page #50097

If no regressions arise, payment will be issued on 2024-10-11. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@pecanoro] The PR that introduced the bug has been identified. Link to the PR:
• [@pecanoro] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@pecanoro] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@pecanoro] Determine if we should create a regression test for this bug.
• [@pecanoro] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[allgandalf]

bump @mallenexpensify to close this one 🙇

[mallenexpensify]

Thanks @allgandalf , closing, for real....