QBO – Unable to change preferred exporter in QBO connection

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.40-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5006859
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause Internal Team

Slack conversation:

Action Performed:

Prerequisite
Workspace is connected to QBO
Another Admin is added to the workspace

1. Navigate to Accounting
2. Click on Export
3. Click Preferred Exporter
4. Select the unchecked workspace admin
5. Wait for the connection to sync and check the preferred exporter

Expected Result:

The newly selected exporter is displayed with a checkmark

Actual Result:

The selected exporter does not stay selected and the exporter is reverted back to the previous one

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6615731_1727334878461.2024-09-26_10_05_27.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @Beamanator (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mvtglobally]

We think this is related to #wave-collect - Release 2

[mananjadhav]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Unable to update the QBO Preferred exporter

What is the root cause of that problem?

• In QuickbooksPreferredExporterConfigurationPage we are using qboConfig?.export.exporter as the fallback value for optimistic update. But qboConfig.export can be undefined when we first sync.

App/src/pages/workspace/accounting/qbo/export/QuickbooksPreferredExporterConfigurationPage.tsx

Lines 56 to 58 in b5a0a29

	if (row.value !== qboConfig?.export?.exporter) {
	QuickbooksOnline.updateQuickbooksOnlinePreferredExporter(policyID, {exporter: row.value}, {exporter: qboConfig?.export.exporter ?? ''});
	}

What changes do you think we should make in order to solve the problem?

• In QuickbooksPreferredExporterConfigurationPage update code to qboConfig?.export?.exporter.

We should also check if there are any other such instances for the update.

What alternative solutions did you explore? (Optional)

[mananjadhav]

Proposal updated.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The selected exporter does not stay selected and the exporter is reverted back to the previous one

What is the root cause of that problem?

This is a Pusher Backend bug, as the Onyx data is updated correctly when we select the second admin, but the Pusher data updates the preferred exporter to the original account, as shown below:

Screen.Recording.2024-09-26.at.23.44.40.mp4

When investigating the issue, I found another bug, in which we can't select the second admin as preferred exporter:

Screen.Recording.2024-09-26.at.23.36.23.mov

This bug happened because we don't use optional chaining in

App/src/pages/workspace/accounting/qbo/export/QuickbooksPreferredExporterConfigurationPage.tsx

Line 57 in b5a0a29

QuickbooksOnline.updateQuickbooksOnlinePreferredExporter(policyID, {exporter: row.value}, {exporter: qboConfig?.export.exporter ?? ''});

And qboConfig?.export doesn't exist in the first sync yet.

What changes do you think we should make in order to solve the problem?

For the original issue, we should update Backend to not reset the data to the original exporter.

For the other bug mentioned, we can add optional chaining to here

QuickbooksOnline.updateQuickbooksOnlinePreferredExporter(policyID, {exporter: row.value}, {exporter: qboConfig?.export?.exporter ?? ''});

What alternative solutions did you explore? (Optional)

[Beamanator]

Oh dang, thanks for the proposals so far! Anyone know which PR the bug may have come from??

[mananjadhav]

@Beamanator Likely https://github.com/Expensify/App/pull/48080/files#diff-afb3647e9a1c6b4d00a7047f997bffa23c873bbd6807e726807f48ebef608bcaR57

[Beamanator]

Yaaa i was kinda thinking that too ^

[Beamanator]

@shubham1206agra @dangrous @rushatgabhane @aldo-expensify can y'all look at this?

[aldo-expensify]

Investigating...

[dangrous]

I think this is probably due to https://github.com/Expensify/Expensify/issues/431392#issuecomment-2377490529 which I just noticed today - basically I think we're ending up trying to update the export object to {exporter: {exporter: [actual value]}} but not 100% sure

[aldo-expensify]

The exporter is getting encoded and nested in a weird way:

This is a duplicate of https://github.com/Expensify/Expensify/issues/431392#issuecomment-2377490529.

[aldo-expensify]

This seems to fix it: #49818

cc @dangrous

[mananjadhav]

@aldo-expensify This might fix the API call but when I did a fresh connection, I could see the JS error for qboConfig?.export.exporter as qboConfig.export was undefined. May be we'll need to fix both?

[Beamanator]

Thanks so much for taking care of this since i had to peace out early yesterday @aldo-expensify 🙏

[johncschuster]

How's this one going, @aldo-expensify?

[mananjadhav]

@johncschuster I believe the PR was deployed to fix the Deploy blocker. I had helped with the PR review, and there would be a payout for me. Can you please update the payment summary for this one?

Also @aldo-expensify do you think it's worth solving the FE error in this issue?

[aldo-expensify]

How's this one going, @aldo-expensify?

The deploy blocker (this issue) was solved by this PR: #49818

@mananjadhav reviewed so we should pay

While we worked on that, another bug was found: #49797 (comment), but I would recommend creating a new clean issue for that with reproduction steps.

Also @aldo-expensify do you think it's worth solving the FE #49797 (comment) in this issue?

Yes, but I think we should open a new issue to avoid confusions. I'm not really sure about what kind of solution are we looking for... it sounds like we should maybe lock the inputs until we have received the data or something like that.

[aldo-expensify]

@mananjadhav the issue where the setting value is not available yet may be really the same root cause for this issue here: #49372 . In that issue, I understand that the setting reverts because of some updates that arrive late.

[mananjadhav]

Could be related. I can check that one if you'd like.

[melvin-bot]

@johncschuster @aldo-expensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[aldo-expensify]

@johncschuster the PR was deployed 2 weeks ago, we need to process @mananjadhav 's C+ payment.

[johncschuster]

Payment Summary:

Contributor+: @mananjadhav due $250 via NewDot

[johncschuster]

Sorry folks! I action all my payment issues every day by filtering my assignments by HOLD for payment in the title and I missed this. Thank you for the pings!

[mananjadhav]

Thanks @johncschuster for the help here.

[garrettmknight]

$250 approved for @mananjadhav

[johncschuster]

@aldo-expensify / @mananjadhav can you provide a regression test step list if we need one?

[aldo-expensify]

@aldo-expensify / @mananjadhav can you provide a regression test step list if we need one?

I don't think we need a new one. This bug was caught while running the existing test: https://expensify.testrail.io/index.php?/tests/view/5006859