Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2024-09-24 #49662

Closed
67 tasks done
github-actions bot opened this issue Sep 24, 2024 · 12 comments
Closed
67 tasks done

Deploy Checklist: New Expensify 2024-09-24 #49662

github-actions bot opened this issue Sep 24, 2024 · 12 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Sep 24, 2024

Release Version: 9.0.40-6
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Sep 24, 2024
@OSBotify
Copy link
Contributor

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.0.40-0 🚀

@blimpich
Copy link
Contributor

#49738 demoted and fix is already in deploy pipeline.

@francoisl
Copy link
Contributor

Demoting #49741 as NAB

@luacmartins
Copy link
Contributor

Demoted #49758. Couldn't reproduce

@mvtglobally
Copy link

mvtglobally commented Sep 26, 2024

Regression is at 95% completed

Open Blockers
#49514
#49739
#49749
#49751

PRs
#49379 - Is failing with #49785
#49463 - is failing with #49754
#49464 - Pending validation on IOS and failing with #49758
#49516 - Pending validation on IOS
#49135 - PROD QA. Ok to check off?

@mvtglobally
Copy link

Regression is completed

PRs
#49379 - Is failing with #49785. repro in PROD checking off
#49463 - is failing with #49754. repro in PROD checking off
#49464 - failing with #49758
#49135 - PROD QA. Ok to check off?
Checking CPs

Open Blockers
#49514
#49739
#49749
#49751
#49797
#49798

@aldo-expensify
Copy link
Contributor

aldo-expensify commented Sep 26, 2024

Checked off #49749, it was fixed here: #49760 (comment)

@stitesExpensify
Copy link
Contributor

Checked off #49739

@AndrewGable
Copy link
Contributor

#49464 - Seems OK to check off per #49758 (comment)
#49135 - Yes OK to check off.

@aldo-expensify
Copy link
Contributor

Checked off #49797, fixed here: #49818 (comment)

@AndrewGable
Copy link
Contributor

:shipit:

Copy link

melvin-bot bot commented Sep 28, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

9 participants