[HOLD for Payment 2024-10-04][$250] Update UpdatePolicyConnectionConfiguration to be 1:1:1 - Part 4

[dangrous]

Problem

Our UpdatePolicyConnectionConfiguration API command is not 1:1:1 - it is the same API call for all related user actions, when it should be split up for each connection (QBO, Xero, etc.) and configuration setting (autoSyncVendor, enableNewCategories, etc.). At the end of this we should not call that function anywhere.

This is polish for the Collect QBO project.

Solution

When we created the NetSuite commands, we followed the correct pattern, and so need to do so here too.

This requires backend and frontend work in tandem (to create the commands and then to use them), so we're looking for a contributor(s) to handle the frontend. You can see an example PR here - there is some extra prep work there that you can ignore, but adjusting all calls like this is what we're going for:

- Connections.updatePolicyConnectionConfig(policyID, CONST.POLICY.CONNECTIONS.NAME.QBO, CONST.QUICK_BOOKS_CONFIG.REIMBURSABLE_EXPENSES_ACCOUNT, row.value);
+ QuickbooksOnline.updateQuickbooksOnlineReimbursableExpensesAccount(policyID, row.value);

Here is a list of the commands handled in this issue:

• UpdateQuickbooksOnlineAutoSync
• UpdateQuickbooksOnlineSyncPeople
• UpdateQuickbooksOnlineReimbursementAccountID
• UpdateQuickbooksOnlineExport - We will need to split up this one even further, one for each piece of the object that it is updating. We can discuss this on the PRs.

If there are others that follow the same pattern as UpdateQuickbooksOnlineExport (same object, different keys) we will need to split those as well.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01eef0bc66034bca70
• Upwork Job ID: 1825578317140040932
• Last Price Increase: 2024-08-19
• Automatic offers:
• shubham1206agra | Contributor | 103590186

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dangrous]

Sorry @zanyrenney forgot to remove Bug from this one - you can ignore until we're ready for a payment

[zanyrenney]

Sounds good, thanks for the update @dangrous

[dangrous]

@shubham1206agra @rushatgabhane can you comment here so I can assign you? Thanks!

[rushatgabhane]

@dangrous fyi, we don't need to comment for getting assigned as we're on exfy org in GitHub

[shubham1206agra]

Here

[dangrous]

oh whoops! sorry about that.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01eef0bc66034bca70

[melvin-bot]

Current assignee @rushatgabhane is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[zanyrenney]

any update here please @shubham1206agra

[shubham1206agra]

I am done with the code. I just figuring out a way to test this flow.

[zanyrenney]

cool!

[dangrous]

fyi backend pr is deployed now so should be able to test the new commands!

[shubham1206agra]

@dangrous, I am getting 404 here. Can you please check this?

[dangrous]

back end PR is up on staging!

[melvin-bot]

@dangrous, @rushatgabhane, @zanyrenney, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

[shubham1206agra]

The PR has pending review from @rushatgabhane

[melvin-bot]

This issue has not been updated in over 15 days. @dangrous, @rushatgabhane, @zanyrenney, @shubham1206agra eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[dangrous]

Shush Melvin this was just merged!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[dangrous]

Why no automationnnnnnn - went to prod 3 days ago according to the comment on the PR

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[zanyrenney]

Hi! I will be OOO until 7th october, please can you handle the final stage here of the payment @RachCHopkins thanks!

[RachCHopkins]

Payment Summary:

• Contributor: @shubham1206agra to be paid $250 via Upwork
• Contributor+: @rushatgabhane to be paid $250 NewDot Manual Requests

Upwork job here

@rushatgabhane I'm late to the party here - can you confirm that's correct please?

[RachCHopkins]

Ok, I see that @dangrous updated the GH title last week, so I assume if the pricetag was wrong, it would have been corrected. Going to go ahead and pay this as it's due.

[RachCHopkins]

@shubham1206agra the original offer had expired, so I have sent you a new manual offer.

[shubham1206agra]

@RachCHopkins Offer accepted

[zanyrenney]

Payment Summary:

Contributor: @shubham1206agra paid $250 via Upwork - completed.
Contributor+: @rushatgabhane to be paid $250 NewDot Manual Requests

Thanks for the new manual offer sent @RachCHopkins I have paid it out.

[garrettmknight]

$250 approved for @rushatgabhane