feat: followers settings schema and behavior #1211

juliannemarik · 2023-09-13T18:50:09Z

7621

Description

adds IWithFollowersBehavior which exposes getFollowers and setFollowersAccess on all item-backed entities
adds a new SiteUiSchemaFollowers and adds the toEditor/fromEditor logic
adds convertFeaturesToLegacyCapabilities and migrateLegacyCapabilitiesToFeatures functions that get executed when we call updateSite and fetchSite respectively - this allows us to start leveraging the permissions system/features for existing site capabilities while maintaining functionality in the current application

Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide
used semantic commit messages
PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)
updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

…iSchema

codecov · 2023-09-13T18:57:10Z

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (88cdd2b) 100.00% compared to head (6d251c5) 100.00%.
Report is 10 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##            master     #1211    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          732       738     +6     
  Lines        13110     13227   +117     
  Branches      2237      2257    +20     
==========================================
+ Hits         13110     13227   +117

Files Changed	Coverage Δ
...mon/src/core/schemas/shared/HubItemEntitySchema.ts	`100.00% <ø> (ø)`
...es/common/src/sites/_internal/SiteBusinessRules.ts	`100.00% <ø> (ø)`
...ges/common/src/sites/_internal/SiteUiSchemaEdit.ts	`100.00% <ø> (ø)`
packages/common/src/core/HubItemEntity.ts	`100.00% <100.00%> (ø)`
...rc/core/schemas/internal/getEntityEditorSchemas.ts	`100.00% <100.00%> (ø)`
...s/common/src/core/schemas/internal/subsetSchema.ts	`100.00% <100.00%> (ø)`
packages/common/src/sites/HubSite.ts	`100.00% <100.00%> (ø)`
packages/common/src/sites/HubSites.ts	`100.00% <100.00%> (ø)`
packages/common/src/sites/_internal/SiteSchema.ts	`100.00% <100.00%> (ø)`
...ommon/src/sites/_internal/SiteUiSchemaFollowers.ts	`100.00% <100.00%> (ø)`
... and 4 more

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…acy capability transforms

tannerjt · 2023-09-14T16:16:48Z

packages/common/src/core/schemas/shared/HubItemEntitySchema.ts

@@ -30,6 +30,19 @@ export const HubItemEntitySchema: IConfigurationSchema = {
    categories: ENTITY_CATEGORIES_SCHEMA,
    isDiscussable: ENTITY_IS_DISCUSSABLE_SCHEMA,
    _thumbnail: ENTITY_IMAGE_SCHEMA,
+    _followers: {


Does _followers need to be on the base schema, or should it only exist on SiteSchema?

That's a good callout - I put it here because although the concept of a followers group only exists for sites today, I think the idea is that any item-backed entity could have a followers group in the future. That's also why I've added the IWithFollowers and IWithFollowersBehavior to the IHubItemEntity and HubItemEntity respectively rather than just to the HubSite.

With that said, if you think it would make more sense to keep this scoped to sites until followers are actually implemented for other entities, I can move it for now

Thanks makes sense to leave it for potential future use cases. Looks good!

We will add followers for Initiative and Project - the only reason it's on now Site is b/c that was/is synonymous with "Initiative".

dbouwman · 2023-09-14T20:14:43Z

packages/common/src/sites/HubSite.ts

@@ -403,10 +403,15 @@ export class HubSite
   * @returns
   */
  toEditor(editorContext: IEntityEditorContext = {}): IHubSiteEditor {
-    // Cast the entity to it's editor
+    // 1. Cast entity to editor


btw- these incremental comments are great - I'm going to start doing this

packages/common/src/sites/_internal/capabilities/capabilityToFeatureMap.ts

packages/common/src/sites/_internal/capabilities/types.ts

dbouwman · 2023-09-18T15:31:24Z

packages/common/src/sites/upgrade-site-schema.ts

@@ -25,6 +26,8 @@ export function upgradeSiteSchema(model: IModel) {
    model = _ensureTelemetry<IModel>(model);
    model = _migrateFeedConfig(model);
    model = _migrateEventListCardConfigs(model);
+    model = migrateLegacyCapabilitiesToFeatures(model);
+
    // WARNING - If you are writing a site schema migration,
    // you probably need to apply it to site drafts as well!


FYI capabilities are also in the DRAFT ->

hub.js/packages/sites/src/drafts/site-draft-include-list.ts

Line 19 in 4a9a1e5

"data.values.capabilities",

I think we need to address this... although I'm not deep enough in this to really know the impacts

Thanks for bringing this up. I discussed it with Jupe and we think drafts are a larger issue. We've added a meeting to the calendar to discuss. Going to get this merged in, and we can circle back to address drafts holistically.

dbouwman

This looks great - only thing is to assess if/how/where we integrate the migration into the Draft system. As noted, this is not an issue for the Version system, but that's not in production yet.

# @esri/hub-common [14.15.0](https://github.com/Esri/hub.js/compare/@esri/[email protected]...@esri/[email protected]) (2023-09-18) ### Features * followers settings schema and behavior ([#1211](#1211)) ([a8be73b](a8be73b))

# [26.1.0](https://github.com/Esri/hub.js/compare/@esri/[email protected]...@esri/[email protected]) (2023-10-08) ### Bug Fixes * update groups link from teams to groups ([#1262](#1262)) ([26dd47a](26dd47a)) * **hub-discussions:** add author and editor to isearchchannels ([#1257](#1257)) ([5d22e8b](5d22e8b)) * add featured content to initiatives edit ([#1208](#1208)) ([a3f0361](a3f0361)) * add Project to wellKnownColletions ([#1254](#1254)) ([82eb6a1](82eb6a1)) * added default empty quotes for computeProps ([#1204](#1204)) ([3c83e4a](3c83e4a)) * auto-populating groups in project creation ([#1225](#1225)) ([0b9465f](0b9465f)) * checkPermission and checkPrivileges first check isAuthenticated ([#1227](#1227)) ([b292131](b292131)) * ensure featured content catalogs are returned as an array ([#1207](#1207)) ([d28b56f](d28b56f)) * properly deserialize trustedOrgs from context ([#1256](#1256)) ([760b4ff](760b4ff)) * **hub-common:** content location should be of type extent, not polygon ([#1228](#1228)) ([c5539f4](c5539f4)) * **hub-common:** fix fetchHubContent does not support slugs ([#1216](#1216)) ([d3a4eba](d3a4eba)) * **hub-common:** re-adds the discussion permissions to validPermissions array ([#1223](#1223)) ([9db7245](9db7245)) * **hub-common:** workspace route for content is /workspace/content/:id not /workspace/contents/:id ([#1250](#1250)) ([f2c6679](f2c6679)) * uiSchema translation keys ([#1224](#1224)) ([a55292f](a55292f)) ### Features * **hub-common:** adds followers group discussion settings on site wo… ([#1251](#1251)) ([e0beb59](e0beb59)) * Add Initiative and Project Associations ([#1213](#1213)) ([7cb0298](7cb0298)) * add links hash for project, initiative, and group entities ([#1226](#1226)) ([aba8f7b](aba8f7b)) * add new polling util ([#1265](#1265)) ([e36c142](e36c142)) * add option to enrich an entity ([#1220](#1220)) ([0b57ff5](0b57ff5)) * add supporting groups to sites property map ([#1205](#1205)) ([2d473d6](2d473d6)) * add workspaceRelative to enrichGroupSearchResult ([#1206](#1206)) ([f6d2016](f6d2016)) * addGroupMembers ([#1230](#1230)) ([3a7c900](3a7c900)) * adds entity discussion settings ([#1221](#1221)) ([5e25a43](5e25a43)) * adds getChannelUsersQuery method, bumps to @esri/arcgis-rest-port… ([#1210](#1210)) ([320d6d8](320d6d8)) * collaborator pane for content workspace ([#1259](#1259)) ([e00e624](e00e624)) * initiative template entity ([#1229](#1229)) ([f5a995a](f5a995a)) * initiative template workspace ([#1246](#1246)) ([cb385e5](cb385e5)) * scaffold solution template entity ([#1253](#1253)) ([54d1fe6](54d1fe6)) * **hub-common:** add application type content edit link ([#1217](#1217)) ([82ceec4](82ceec4)) * **hub-common:** add blocked as a possible PostStatus ([#1222](#1222)) ([11c8a58](11c8a58)) * **hub-common:** add content settings schemas and derive props from server definitions ([#1209](#1209)) ([1721285](1721285)) * **hub-common:** add hub:[entity]:manage permission for all entities ([#1202](#1202)) ([71191b7](71191b7)) * **hub-discussions:** adding ability to update the groups of a channel ([#1218](#1218)) ([7bc2117](7bc2117)) * followers settings schema and behavior ([#1211](#1211)) ([a8be73b](a8be73b)) * item extent now selectable, savable, and reflects in old and new view ([#1212](#1212)) ([5dbe3bb](5dbe3bb)) * partnered orgs added to context ([#1214](#1214)) ([7979571](7979571)) * refactor entity schema implementation ([#1203](#1203)) ([88cdd2b](88cdd2b))

# [14.1.0](https://github.com/Esri/hub.js/compare/@esri/[email protected]...@esri/[email protected]) (2023-10-08) ### Bug Fixes * update groups link from teams to groups ([#1262](#1262)) ([26dd47a](26dd47a)) * **hub-discussions:** add author and editor to isearchchannels ([#1257](#1257)) ([5d22e8b](5d22e8b)) * account for index values that are 0 in card view models ([#1196](#1196)) ([bbc1928](bbc1928)) * add featured content to initiatives edit ([#1208](#1208)) ([a3f0361](a3f0361)) * add Project to wellKnownColletions ([#1254](#1254)) ([82eb6a1](82eb6a1)) * add shareContent group permission and minor hub group clean up ([#1194](#1194)) ([9a90b6d](9a90b6d)) * added default empty quotes for computeProps ([#1204](#1204)) ([3c83e4a](3c83e4a)) * auto-populating groups in project creation ([#1225](#1225)) ([0b9465f](0b9465f)) * checkPermission and checkPrivileges first check isAuthenticated ([#1227](#1227)) ([b292131](b292131)) * ensure featured content catalogs are returned as an array ([#1207](#1207)) ([d28b56f](d28b56f)) * properly deserialize trustedOrgs from context ([#1256](#1256)) ([760b4ff](760b4ff)) * **hub-common:** content location should be of type extent, not polygon ([#1228](#1228)) ([c5539f4](c5539f4)) * **hub-common:** fix fetchHubContent does not support slugs ([#1216](#1216)) ([d3a4eba](d3a4eba)) * **hub-common:** re-adds the discussion permissions to validPermissions array ([#1223](#1223)) ([9db7245](9db7245)) * **hub-common:** workspace route for content is /workspace/content/:id not /workspace/contents/:id ([#1250](#1250)) ([f2c6679](f2c6679)) * rollback stat migration ([#1193](#1193)) ([8465e15](8465e15)) * shouldClearEmptyFields now accounts for licenseInfo ([#1198](#1198)) ([3f4eb47](3f4eb47)) * uiSchema translation keys ([#1224](#1224)) ([a55292f](a55292f)) * **hub-discussions:** user can read channel if group is non-discussable ([#1201](#1201)) ([28d61f3](28d61f3)) ### Features * **hub-common:** adds followers group discussion settings on site wo… ([#1251](#1251)) ([e0beb59](e0beb59)) * add feature and entity flagging into checkPermission ([#1187](#1187)) ([b040283](b040283)) * Add Initiative and Project Associations ([#1213](#1213)) ([7cb0298](7cb0298)) * add invite users to hub group ([#1197](#1197)) ([014b2bd](014b2bd)) * add links hash for project, initiative, and group entities ([#1226](#1226)) ([aba8f7b](aba8f7b)) * add member role badges to user card model ([#1195](#1195)) ([e09608d](e09608d)) * add new polling util ([#1265](#1265)) ([e36c142](e36c142)) * add option to enrich an entity ([#1220](#1220)) ([0b57ff5](0b57ff5)) * add supporting groups to sites property map ([#1205](#1205)) ([2d473d6](2d473d6)) * add workspaceRelative to enrichGroupSearchResult ([#1206](#1206)) ([f6d2016](f6d2016)) * addGroupMembers ([#1230](#1230)) ([3a7c900](3a7c900)) * adding license picker to content workspace ([#1192](#1192)) ([312b333](312b333)) * adds entity discussion settings ([#1221](#1221)) ([5e25a43](5e25a43)) * adds getChannelUsersQuery method, bumps to @esri/arcgis-rest-port… ([#1210](#1210)) ([320d6d8](320d6d8)) * collaborator pane for content workspace ([#1259](#1259)) ([e00e624](e00e624)) * initiative template entity ([#1229](#1229)) ([f5a995a](f5a995a)) * initiative template workspace ([#1246](#1246)) ([cb385e5](cb385e5)) * scaffold solution template entity ([#1253](#1253)) ([54d1fe6](54d1fe6)) * **hub-common:** add application type content edit link ([#1217](#1217)) ([82ceec4](82ceec4)) * **hub-common:** add blocked as a possible PostStatus ([#1222](#1222)) ([11c8a58](11c8a58)) * **hub-common:** add content settings schemas and derive props from server definitions ([#1209](#1209)) ([1721285](1721285)) * **hub-common:** add getResultSiteRelativeLink so Hub Page results can have slugs in siteRelative l ([#1200](#1200)) ([27e0740](27e0740)) * **hub-common:** add hub:[entity]:manage permission for all entities ([#1202](#1202)) ([71191b7](71191b7)) * **hub-common:** add icon for Discussion content type ([#1185](#1185)) ([7ae927a](7ae927a)) * **hub-discussions:** adding ability to update the groups of a channel ([#1218](#1218)) ([7bc2117](7bc2117)) * followers settings schema and behavior ([#1211](#1211)) ([a8be73b](a8be73b)) * item extent now selectable, savable, and reflects in old and new view ([#1212](#1212)) ([5dbe3bb](5dbe3bb)) * partnered orgs added to context ([#1214](#1214)) ([7979571](7979571)) * refactor entity schema implementation ([#1203](#1203)) ([88cdd2b](88cdd2b)) * **hub-common:** add unified "links" hash as an optional property for all entities ([#1199](#1199)) ([ba14502](ba14502)) * site's followers pane permissions ([#1186](#1186)) ([90feec7](90feec7)) * ungate dashboard from projects ([#1188](#1188)) ([658b936](658b936))

# [14.1.0](https://github.com/Esri/hub.js/compare/@esri/[email protected]...@esri/[email protected]) (2023-10-08) ### Bug Fixes * update groups link from teams to groups ([#1262](#1262)) ([26dd47a](26dd47a)) * **hub-discussions:** add author and editor to isearchchannels ([#1257](#1257)) ([5d22e8b](5d22e8b)) * account for index values that are 0 in card view models ([#1196](#1196)) ([bbc1928](bbc1928)) * add featured content to initiatives edit ([#1208](#1208)) ([a3f0361](a3f0361)) * add Project to wellKnownColletions ([#1254](#1254)) ([82eb6a1](82eb6a1)) * add shareContent group permission and minor hub group clean up ([#1194](#1194)) ([9a90b6d](9a90b6d)) * added default empty quotes for computeProps ([#1204](#1204)) ([3c83e4a](3c83e4a)) * auto-populating groups in project creation ([#1225](#1225)) ([0b9465f](0b9465f)) * checkPermission and checkPrivileges first check isAuthenticated ([#1227](#1227)) ([b292131](b292131)) * ensure featured content catalogs are returned as an array ([#1207](#1207)) ([d28b56f](d28b56f)) * properly deserialize trustedOrgs from context ([#1256](#1256)) ([760b4ff](760b4ff)) * **hub-common:** content location should be of type extent, not polygon ([#1228](#1228)) ([c5539f4](c5539f4)) * **hub-common:** fix fetchHubContent does not support slugs ([#1216](#1216)) ([d3a4eba](d3a4eba)) * **hub-common:** re-adds the discussion permissions to validPermissions array ([#1223](#1223)) ([9db7245](9db7245)) * **hub-common:** workspace route for content is /workspace/content/:id not /workspace/contents/:id ([#1250](#1250)) ([f2c6679](f2c6679)) * shouldClearEmptyFields now accounts for licenseInfo ([#1198](#1198)) ([3f4eb47](3f4eb47)) * uiSchema translation keys ([#1224](#1224)) ([a55292f](a55292f)) * **hub-discussions:** user can read channel if group is non-discussable ([#1201](#1201)) ([28d61f3](28d61f3)) ### Features * **hub-common:** adds followers group discussion settings on site wo… ([#1251](#1251)) ([e0beb59](e0beb59)) * Add Initiative and Project Associations ([#1213](#1213)) ([7cb0298](7cb0298)) * add invite users to hub group ([#1197](#1197)) ([014b2bd](014b2bd)) * add links hash for project, initiative, and group entities ([#1226](#1226)) ([aba8f7b](aba8f7b)) * add member role badges to user card model ([#1195](#1195)) ([e09608d](e09608d)) * add new polling util ([#1265](#1265)) ([e36c142](e36c142)) * add option to enrich an entity ([#1220](#1220)) ([0b57ff5](0b57ff5)) * add supporting groups to sites property map ([#1205](#1205)) ([2d473d6](2d473d6)) * add workspaceRelative to enrichGroupSearchResult ([#1206](#1206)) ([f6d2016](f6d2016)) * addGroupMembers ([#1230](#1230)) ([3a7c900](3a7c900)) * adding license picker to content workspace ([#1192](#1192)) ([312b333](312b333)) * adds entity discussion settings ([#1221](#1221)) ([5e25a43](5e25a43)) * adds getChannelUsersQuery method, bumps to @esri/arcgis-rest-port… ([#1210](#1210)) ([320d6d8](320d6d8)) * collaborator pane for content workspace ([#1259](#1259)) ([e00e624](e00e624)) * initiative template entity ([#1229](#1229)) ([f5a995a](f5a995a)) * initiative template workspace ([#1246](#1246)) ([cb385e5](cb385e5)) * scaffold solution template entity ([#1253](#1253)) ([54d1fe6](54d1fe6)) * **hub-common:** add application type content edit link ([#1217](#1217)) ([82ceec4](82ceec4)) * **hub-common:** add blocked as a possible PostStatus ([#1222](#1222)) ([11c8a58](11c8a58)) * **hub-common:** add content settings schemas and derive props from server definitions ([#1209](#1209)) ([1721285](1721285)) * **hub-common:** add getResultSiteRelativeLink so Hub Page results can have slugs in siteRelative l ([#1200](#1200)) ([27e0740](27e0740)) * **hub-common:** add hub:[entity]:manage permission for all entities ([#1202](#1202)) ([71191b7](71191b7)) * **hub-discussions:** adding ability to update the groups of a channel ([#1218](#1218)) ([7bc2117](7bc2117)) * followers settings schema and behavior ([#1211](#1211)) ([a8be73b](a8be73b)) * item extent now selectable, savable, and reflects in old and new view ([#1212](#1212)) ([5dbe3bb](5dbe3bb)) * partnered orgs added to context ([#1214](#1214)) ([7979571](7979571)) * refactor entity schema implementation ([#1203](#1203)) ([88cdd2b](88cdd2b)) * **hub-common:** add unified "links" hash as an optional property for all entities ([#1199](#1199)) ([ba14502](ba14502))

# [14.1.0](https://github.com/Esri/hub.js/compare/@esri/[email protected]...@esri/[email protected]) (2023-10-08) ### Bug Fixes * update groups link from teams to groups ([#1262](#1262)) ([26dd47a](26dd47a)) * **hub-discussions:** add author and editor to isearchchannels ([#1257](#1257)) ([5d22e8b](5d22e8b)) * account for index values that are 0 in card view models ([#1196](#1196)) ([bbc1928](bbc1928)) * add featured content to initiatives edit ([#1208](#1208)) ([a3f0361](a3f0361)) * add Project to wellKnownColletions ([#1254](#1254)) ([82eb6a1](82eb6a1)) * add shareContent group permission and minor hub group clean up ([#1194](#1194)) ([9a90b6d](9a90b6d)) * added default empty quotes for computeProps ([#1204](#1204)) ([3c83e4a](3c83e4a)) * auto-populating groups in project creation ([#1225](#1225)) ([0b9465f](0b9465f)) * checkPermission and checkPrivileges first check isAuthenticated ([#1227](#1227)) ([b292131](b292131)) * ensure featured content catalogs are returned as an array ([#1207](#1207)) ([d28b56f](d28b56f)) * properly deserialize trustedOrgs from context ([#1256](#1256)) ([760b4ff](760b4ff)) * **hub-common:** content location should be of type extent, not polygon ([#1228](#1228)) ([c5539f4](c5539f4)) * **hub-common:** fix fetchHubContent does not support slugs ([#1216](#1216)) ([d3a4eba](d3a4eba)) * **hub-common:** re-adds the discussion permissions to validPermissions array ([#1223](#1223)) ([9db7245](9db7245)) * **hub-common:** workspace route for content is /workspace/content/:id not /workspace/contents/:id ([#1250](#1250)) ([f2c6679](f2c6679)) * rollback stat migration ([#1193](#1193)) ([8465e15](8465e15)) * shouldClearEmptyFields now accounts for licenseInfo ([#1198](#1198)) ([3f4eb47](3f4eb47)) * uiSchema translation keys ([#1224](#1224)) ([a55292f](a55292f)) * **hub-discussions:** user can read channel if group is non-discussable ([#1201](#1201)) ([28d61f3](28d61f3)) ### Features * **hub-common:** adds followers group discussion settings on site wo… ([#1251](#1251)) ([e0beb59](e0beb59)) * add feature and entity flagging into checkPermission ([#1187](#1187)) ([b040283](b040283)) * Add Initiative and Project Associations ([#1213](#1213)) ([7cb0298](7cb0298)) * add invite users to hub group ([#1197](#1197)) ([014b2bd](014b2bd)) * add links hash for project, initiative, and group entities ([#1226](#1226)) ([aba8f7b](aba8f7b)) * add member role badges to user card model ([#1195](#1195)) ([e09608d](e09608d)) * add new polling util ([#1265](#1265)) ([e36c142](e36c142)) * add option to enrich an entity ([#1220](#1220)) ([0b57ff5](0b57ff5)) * add supporting groups to sites property map ([#1205](#1205)) ([2d473d6](2d473d6)) * add workspaceRelative to enrichGroupSearchResult ([#1206](#1206)) ([f6d2016](f6d2016)) * addGroupMembers ([#1230](#1230)) ([3a7c900](3a7c900)) * adding license picker to content workspace ([#1192](#1192)) ([312b333](312b333)) * adds entity discussion settings ([#1221](#1221)) ([5e25a43](5e25a43)) * adds getChannelUsersQuery method, bumps to @esri/arcgis-rest-port… ([#1210](#1210)) ([320d6d8](320d6d8)) * collaborator pane for content workspace ([#1259](#1259)) ([e00e624](e00e624)) * initiative template entity ([#1229](#1229)) ([f5a995a](f5a995a)) * initiative template workspace ([#1246](#1246)) ([cb385e5](cb385e5)) * scaffold solution template entity ([#1253](#1253)) ([54d1fe6](54d1fe6)) * **hub-common:** add application type content edit link ([#1217](#1217)) ([82ceec4](82ceec4)) * **hub-common:** add blocked as a possible PostStatus ([#1222](#1222)) ([11c8a58](11c8a58)) * **hub-common:** add content settings schemas and derive props from server definitions ([#1209](#1209)) ([1721285](1721285)) * **hub-common:** add getResultSiteRelativeLink so Hub Page results can have slugs in siteRelative l ([#1200](#1200)) ([27e0740](27e0740)) * **hub-common:** add hub:[entity]:manage permission for all entities ([#1202](#1202)) ([71191b7](71191b7)) * **hub-common:** add icon for Discussion content type ([#1185](#1185)) ([7ae927a](7ae927a)) * **hub-discussions:** adding ability to update the groups of a channel ([#1218](#1218)) ([7bc2117](7bc2117)) * followers settings schema and behavior ([#1211](#1211)) ([a8be73b](a8be73b)) * item extent now selectable, savable, and reflects in old and new view ([#1212](#1212)) ([5dbe3bb](5dbe3bb)) * partnered orgs added to context ([#1214](#1214)) ([7979571](7979571)) * refactor entity schema implementation ([#1203](#1203)) ([88cdd2b](88cdd2b)) * **hub-common:** add unified "links" hash as an optional property for all entities ([#1199](#1199)) ([ba14502](ba14502)) * site's followers pane permissions ([#1186](#1186)) ([90feec7](90feec7)) * ungate dashboard from projects ([#1188](#1188)) ([658b936](658b936))

juliannemarik added 16 commits September 12, 2023 09:34

feat: add IWithFollowersBehavior and add to HubItemEntity

a7ae4c1

feat: extend IHubItemEntity with IWithFollowers trait

4c18854

feat: add followers properties to base item entity schema

af21fb9

feat: add new site followers uiSchema

dc8ddc5

chore: update IWithEditorBehavior toEditor method to be async

8a9dd0a

feat: add toEditor and fromEditor logic for site followers

a26576c

fix: refactor to use permissions and add legacy capability migration

0271d3f

fix: make followersGroupId optional

eda68a9

chore: add test for convertFeaturesToLegacyCapabilities

dd2cc98

fix: ensure required properties are subset when we filter schema to u…

0cfb057

…iSchema

chore: update IWithFollowersBehavior

81b11df

chore: revert async toEditor behavior for now

2d99b09

chore: cleanup

d06ce53

fix: update getFollowers function in IWithFollowersBehavior

0ebf8eb

chore: update tests

c0d6e4d

chore: add function comment to convertFeaturesToLegacyCapabilities

ef37951

juliannemarik added 5 commits September 13, 2023 15:15

fix: rename IWithFollowersBehavior methods

c707133

chore: rename feature flag

8d8fe5e

feat: add capabilities module that takes card of forward/backward leg…

f632210

…acy capability transforms

chore: add/update tests

9b8ff71

chore: comment cleanup

bebc3e8

juliannemarik requested review from dbouwman and tannerjt September 14, 2023 12:46

juliannemarik added 3 commits September 14, 2023 07:59

fix: change access to groupAccess on schema

dc0f2e4

fix: failing uiSchema test

4f61169

fix: minor cleanup

18ab559

tannerjt reviewed Sep 14, 2023

View reviewed changes

dbouwman reviewed Sep 14, 2023

View reviewed changes

packages/common/src/sites/_internal/capabilities/capabilityToFeatureMap.ts Show resolved Hide resolved

dbouwman reviewed Sep 14, 2023

View reviewed changes

packages/common/src/sites/_internal/capabilities/types.ts Show resolved Hide resolved

juliannemarik added 2 commits September 15, 2023 12:44

chore: add additional comments

3b85be3

fix: move migrateLegacyCapabilitiesToFeatures to upgrade-site-schema

6d251c5

dbouwman reviewed Sep 18, 2023

View reviewed changes

dbouwman approved these changes Sep 18, 2023

View reviewed changes

juliannemarik merged commit a8be73b into master Sep 18, 2023
7 checks passed

juliannemarik deleted the feat/7621-followers-settings-schema branch September 18, 2023 17:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: followers settings schema and behavior #1211

feat: followers settings schema and behavior #1211

juliannemarik commented Sep 13, 2023 •

edited

Loading

codecov bot commented Sep 13, 2023 •

edited

Loading

tannerjt Sep 14, 2023

juliannemarik Sep 14, 2023

tannerjt Sep 14, 2023

dbouwman Sep 14, 2023

dbouwman Sep 14, 2023

dbouwman Sep 18, 2023

juliannemarik Sep 18, 2023

dbouwman left a comment

feat: followers settings schema and behavior #1211

feat: followers settings schema and behavior #1211

Conversation

juliannemarik commented Sep 13, 2023 • edited Loading

Description

codecov bot commented Sep 13, 2023 • edited Loading

Codecov Report

tannerjt Sep 14, 2023

Choose a reason for hiding this comment

juliannemarik Sep 14, 2023

Choose a reason for hiding this comment

tannerjt Sep 14, 2023

Choose a reason for hiding this comment

dbouwman Sep 14, 2023

Choose a reason for hiding this comment

dbouwman Sep 14, 2023

Choose a reason for hiding this comment

dbouwman Sep 18, 2023

Choose a reason for hiding this comment

juliannemarik Sep 18, 2023

Choose a reason for hiding this comment

dbouwman left a comment

Choose a reason for hiding this comment

juliannemarik commented Sep 13, 2023 •

edited

Loading

codecov bot commented Sep 13, 2023 •

edited

Loading