fix(hub-common): re-adds the discussion permissions to validPermissio…

…ns array (#1223) affects: @esri/hub-common
Esri · Sep 20, 2023 · 9db7245 · 9db7245
1 parent ec37133
commit 9db7245
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 4 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/common/src/permissions/types/Permission.ts b/packages/common/src/permissions/types/Permission.ts
@@ -24,6 +24,7 @@ const validPermissions = [
   ...PagePermissions,
   ...PlatformPermissions,
   ...TempPermissions,
+  ...DiscussionPermissions,
 ] as const;
 
 /**
@@ -37,7 +38,8 @@ export type Permission =
   | (typeof GroupPermissions)[number]
   | (typeof PagePermissions)[number]
   | (typeof PlatformPermissions)[number]
-  | (typeof TempPermissions)[number];
+  | (typeof TempPermissions)[number]
+  | (typeof DiscussionPermissions)[number];
 
 /**
  * Validate a Permission

diff --git a/packages/common/test/permissions/types/isPermission.test.ts b/packages/common/test/permissions/types/isPermission.test.ts
@@ -1,8 +1,30 @@
 import { isPermission } from "../../../src";
+import { ProjectPermissions } from "../../../src/projects/_internal/ProjectBusinessRules";
+import { SitePermissions } from "../../../src/sites/_internal/SiteBusinessRules";
+import { InitiativePermissions } from "../../../src/initiatives/_internal/InitiativeBusinessRules";
+import { DiscussionPermissions } from "../../../src/discussions/_internal/DiscussionBusinessRules";
+import { ContentPermissions } from "../../../src/content/_internal/ContentBusinessRules";
+import { GroupPermissions } from "../../../src/groups/_internal/GroupBusinessRules";
+import { PagePermissions } from "../../../src/pages/_internal/PageBusinessRules";
+import { PlatformPermissions } from "../../../src/permissions/PlatformPermissionPolicies";
 
 describe("isPermission:", () => {
-  it("returns true for valid permission", () => {
-    expect(isPermission("hub:site:create")).toBe(true);
+  const allPermissions = [
+    ...SitePermissions,
+    ...ProjectPermissions,
+    ...InitiativePermissions,
+    ...ContentPermissions,
+    ...GroupPermissions,
+    ...PagePermissions,
+    ...PlatformPermissions,
+    ...DiscussionPermissions,
+    "temp:workspace:released",
+  ];
+
+  allPermissions.forEach((permission) => {
+    it(`returns true for ${permission} permission`, () => {
+      expect(isPermission(permission)).toBe(true);
+    });
   });
 
   it("returns fails for invalid permission", () => {