fix: ensure featured content catalogs are returned as an array (#1207)

Esri · Sep 12, 2023 · d28b56f · d28b56f
1 parent 9ab01ce
commit d28b56f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/packages/common/src/core/schemas/internal/getFeaturedContentCatalogs.ts b/packages/common/src/core/schemas/internal/getFeaturedContentCatalogs.ts
@@ -3,13 +3,14 @@ import {
   WellKnownCatalog,
   getWellKnownCatalog,
 } from "../../../search/wellKnownCatalog";
+import { IHubCatalog } from "../../../search/types/IHubCatalog";
 
 /**
  * Return a catalog structured for picking featured content.
  * @param user
  * @returns
  */
-export function getFeaturedContentCatalogs(user: IUser) {
+export function getFeaturedContentCatalogs(user: IUser): IHubCatalog[] {
   const catalogNames: WellKnownCatalog[] = [
     "myContent",
     "favorites",
@@ -27,5 +28,5 @@ export function getFeaturedContentCatalogs(user: IUser) {
     return catalog;
   });
 
-  return { catalogs };
+  return catalogs;
 }
diff --git a/packages/common/test/core/schemas/internal/getFeaturedContentCatalogs.test.ts b/packages/common/test/core/schemas/internal/getFeaturedContentCatalogs.test.ts
@@ -4,10 +4,10 @@ import { getFeaturedContentCatalogs } from "../../../../src/core/schemas/interna
 describe("getFeaturedContentCatalogs:", () => {
   it("adds user into catalog", () => {
     const user: IUser = { username: "darth" } as unknown as IUser;
-    const chk = getFeaturedContentCatalogs(user);
-    expect(chk.catalogs.length).toBe(4);
-    const myContent = chk.catalogs[0];
-    expect(myContent.scopes.item.filters[0].predicates[0]).toEqual({
+    const catalogs = getFeaturedContentCatalogs(user);
+    expect(catalogs.length).toBe(4);
+    const myContent = catalogs[0];
+    expect(myContent.scopes?.item?.filters[0].predicates[0]).toEqual({
       owner: "darth",
     });
   });