pyln-testing: fix catching of memleak/broken errors at exit. #7573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
test-ci-memleak
branch
from
44a2a39 to
9cf9024
Compare
rustyrussell
force-pushed
the
test-ci-memleak
branch
from
9cf9024 to
d60b801
Compare
Once we fix our broken log detection, we find some we were missing. Signed-off-by: Rusty Russell <[email protected]>
Commit 901342b ("pyln-testing: require explicit pattern for BROKEN messages.") changed to a manual scan of logs rather than using is_in_log, so it needs to manually refresh, otherwise we miss final log messages. This causes us to often miss memleak messages, which are printed only in the exit path! Reported-by: Lagrang3 Fixes: ElementsProject#7565 Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
test-ci-memleak
branch
from
d60b801 to
b07d903
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 901342b ("pyln-testing: require explicit pattern for BROKEN messages.") changed to a manual scan of logs rather than using is_in_log, so it needs to manually refresh, otherwise we miss final log messages.
This causes us to often miss memleak messages, which are printed only in the exit path!
Reported-by: Lagrang3
Fixes: #7565