Skip to content

Commit

Permalink
pyln-testing: fix catching of memleak/broken errors at exit.
Browse files Browse the repository at this point in the history
Commit 901342b ("pyln-testing: require
explicit pattern for BROKEN messages.") changed to a manual scan of
logs rather than using is_in_log, so it needs to manually refresh,
otherwise we miss final log messages.

This causes us to often miss memleak messages, which are printed
only in the exit path!

Reported-by: Lagrang3
Fixes: #7565
Signed-off-by: Rusty Russell <[email protected]>
  • Loading branch information
rustyrussell committed Aug 15, 2024
1 parent 74c906e commit b07d903
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions contrib/pyln-testing/pyln/testing/fixtures.py
Original file line number Diff line number Diff line change
Expand Up @@ -605,6 +605,7 @@ def checkBadGossip(node):


def checkBroken(node):
node.daemon.logs_catchup()
broken_lines = [l for l in node.daemon.logs if '**BROKEN**' in l]
if node.broken_log:
ex = re.compile(node.broken_log)
Expand Down

0 comments on commit b07d903

Please sign in to comment.