Is CI not checking for memory leaks? #7565
Milestone
Comments
Lagrang3
changed the title
|
Checking... |
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this issue
Aug 14, 2024
Commit 901342b ("pyln-testing: require explicit pattern for BROKEN messages.") changed to a manual scan of logs rather than using is_in_log, so it needs to manually refresh, otherwise we miss final log messages. This causes us to often miss memleak messages, which are printed only in the exit path! Reported-by: Lagrang3 Fixes: ElementsProject#7565 Signed-off-by: Rusty Russell <[email protected]>
|
Good catch! |
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this issue
Aug 14, 2024
Commit 901342b ("pyln-testing: require explicit pattern for BROKEN messages.") changed to a manual scan of logs rather than using is_in_log, so it needs to manually refresh, otherwise we miss final log messages. This causes us to often miss memleak messages, which are printed only in the exit path! Reported-by: Lagrang3 Fixes: ElementsProject#7565 Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this issue
Aug 15, 2024
Commit 901342b ("pyln-testing: require explicit pattern for BROKEN messages.") changed to a manual scan of logs rather than using is_in_log, so it needs to manually refresh, otherwise we miss final log messages. This causes us to often miss memleak messages, which are printed only in the exit path! Reported-by: Lagrang3 Fixes: ElementsProject#7565 Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this issue
Aug 15, 2024
Commit 901342b ("pyln-testing: require explicit pattern for BROKEN messages.") changed to a manual scan of logs rather than using is_in_log, so it needs to manually refresh, otherwise we miss final log messages. This causes us to often miss memleak messages, which are printed only in the exit path! Reported-by: Lagrang3 Fixes: ElementsProject#7565 Signed-off-by: Rusty Russell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After this issue #7560, it occurred to me that I have been pushing code that the CI have not checked for memory leaks.
As far as I know, I can enforce memory leak detection by setting the environment variable
LIGHTNING_DEV_MEMLEAK, at leastthat is what is written in
common/memleak.c.Locally I run pyln tests like this:
But CI is clearly not doing this check for memory leaks, otherwise #7560 would have been caught by it during PR review.
The text was updated successfully, but these errors were encountered: