-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Villager RNG Manipulation #642
base: fabric
Are you sure you want to change the base?
Conversation
Holy fuck nice! |
yooooo |
…ome reason it's not working, idk why
- i need to fix for ping tho - i can probably remove the clock requirement and use the day/night packets
- i can probably remove the clock requirement and use the day/night packets
…ager_rng_cracking
Add simulation for more actions and add trade cracking for levels above 1
… day, and held item in mainhand
…king # Conflicts: # src/main/java/net/earthcomputer/clientcommands/Configs.java
👍 |
can i test out build artifacts? |
Yeah you just unzip it, get the mod jar out of it and then install it like a regular mod. It's in a working state but I won't be providing support for using it. It needs to be made more user friendly before it can be merged. |
Ah sorry, I forgot artifacts are not built for PRs. You will have to clone the PR and build it yourself. But again, this channel is for development, it's best to join the discord and ask in support if you get stuck. |
src/main/java/net/earthcomputer/clientcommands/features/VillagerRngSimulator.java
Outdated
Show resolved
Hide resolved
src/main/java/net/earthcomputer/clientcommands/features/VillagerCracker.java
Outdated
Show resolved
Hide resolved
src/main/java/net/earthcomputer/clientcommands/features/VillagerCracker.java
Outdated
Show resolved
Hide resolved
src/main/java/net/earthcomputer/clientcommands/features/VillagerRngSimulator.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm having some issues running it, see Discord
src/main/java/net/earthcomputer/clientcommands/util/DebugRandom.java
Outdated
Show resolved
Hide resolved
} | ||
|
||
private static void sendInvalidSetupHelp() { | ||
ClientCommandHelper.sendHelp(Component.translatable("villagerManip.help.setup.prefix").append(Component.translatable("villagerManip.help.setup.here").withStyle(ChatFormatting.UNDERLINE).withStyle(style -> style.withClickEvent(new ClickEvent(ClickEvent.Action.OPEN_URL, "https://raw.githubusercontent.com/Earthcomputer/clientcommands/refs/heads/fabric/villager_rng_setup.png")))).append(Component.translatable("villagerManip.help.setup.suffix"))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be a permalink, otherwise we're committing to having this file in the repository forever. The problem is, we don't have a permalink pointing to my repo yet. I'll add something to the clientcommands buildscript that allows you to get the commit hash that clientcommands was built with
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
BlockState trapdoorPosState = level.getBlockState(trapdoorPos); | ||
if (!((airPosState.isAir() || direction != bedDirection) && trapdoorPosState.is(BlockTags.TRAPDOORS) && trapdoorPosState.getValue(TrapDoorBlock.HALF) == Half.TOP && trapdoorPosState.getValue(TrapDoorBlock.HALF) == Half.TOP && trapdoorPosState.getValue(TrapDoorBlock.OPEN) == Boolean.FALSE)) { | ||
if (!(trapdoorPosState.is(BlockTags.TRAPDOORS) && trapdoorPosState.getValue(TrapDoorBlock.HALF) == Half.TOP && trapdoorPosState.getValue(TrapDoorBlock.HALF) == Half.TOP && trapdoorPosState.getValue(TrapDoorBlock.OPEN) == Boolean.FALSE)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're checking the trapdoor half twice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed i am...
@@ -293,7 +287,7 @@ private static void checkVillagerSetup() { | |||
} | |||
|
|||
private static void sendInvalidSetupHelp() { | |||
ClientCommandHelper.sendHelp(Component.translatable("villagerManip.help.setup.prefix").append(Component.translatable("villagerManip.help.setup.here").withStyle(ChatFormatting.UNDERLINE).withStyle(style -> style.withClickEvent(new ClickEvent(ClickEvent.Action.OPEN_URL, "https://raw.githubusercontent.com/Earthcomputer/clientcommands/refs/heads/fabric/villager_rng_setup.png")))).append(Component.translatable("villagerManip.help.setup.suffix"))); | |||
ClientCommandHelper.sendHelp(Component.translatable("villagerManip.help.setup", Component.translatable("villagerManip.help.setup.link").withStyle(style -> style.withUnderlined(true).withClickEvent(new ClickEvent(ClickEvent.Action.OPEN_URL, "https://raw.githubusercontent.com/Earthcomputer/clientcommands/refs/heads/fabric/dpcs/villager_rng_setup.png"))))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo of docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bruh moment
|
||
"villagerManip.help.day": "Help: Villager RNG manipulation can only be done at night-time", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The villagerManip
translations shouldn't be in the middle of the commands, as that's not alphabetical
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, i'll move them
…king # Conflicts: # src/main/java/net/earthcomputer/clientcommands/util/DebugRandom.java
… in villager rng invalid setup help
…king # Conflicts: # src/main/java/net/earthcomputer/clientcommands/features/FishingCracker.java
Add Villager RNG Manipulation to brute-force optimal trades