Fix two pitch cracking and add three pitch cracking #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RealRTTV
requested changes
Jun 20, 2024
| private float firstPitch = Float.NaN; | ||
| private int ticksBetweenSounds = 0; | ||
| private float secondPitch = Float.NaN; | ||
| @Nullable | ||
| private long[] seedsFromTwoPitches = null; |
There was a problem hiding this comment.
can we rename this to filteredSeeds / remainingSeeds and make it so that the third pitch check is instead the nth pitch check that filters down the long[] and sets the random if there's precisely one seed left?
There was a problem hiding this comment.
I don't really see the point of making it work for more than 3 calls, most likely there's never going to be a seed where more than 3 pitches are needed since they already give much more than 48 bits of info
| @@ -333,7 +413,7 @@ public long[] crackSeed() { | |||
| } | |||
| rand.nextInt(100); | |||
| } | |||
| if (rand.nextInt(1000) >= ticksBetweenSounds) { | |||
| if (rand.nextInt(1000) >= ticksBetweenSounds - 80 - 1) { | |||
There was a problem hiding this comment.
Yes, it also makes much more sense with the comparisons the loop is doing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.