This repository has been archived by the owner on Nov 6, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- To move the plugin to a place where it's redirecting valid urls - Downgrading in case of major SSL issues has been addressed with EFForg#16546
- Many old redirects removed from the "www" poor redirection days - Old CDN urls removed - Redundancy removed - Removed inavlid or miscongigured cert URLs
- Mainly older rulesets that did not have enough tests, expired domains, or redundant tests
Bisaloo
reviewed
Oct 23, 2018
Bisaloo
reviewed
Oct 23, 2018
Bisaloo
reviewed
Oct 23, 2018
Bisaloo
reviewed
Oct 23, 2018
Bisaloo
reviewed
Oct 23, 2018
Bisaloo
reviewed
Oct 23, 2018
J0WI
reviewed
Oct 24, 2018
I did not yet review all files, but here are some things I noticed:
|
I can definitely go back and leave the ones that were already off. I must admit, I started these changes when I didn't fully get the default off feature, but now I do. So I can condense the PR some for that. I can go back over the rulesets that had wildcards and see what can be amended there as well. Thank you for the feedback. |
The changes here are not needed since these rules were previously turned off
zoracon
added a commit
to zoracon/https-everywhere
that referenced
this pull request
Nov 1, 2018
This follows up on the work in PR EFForg#16924
jsha
pushed a commit
that referenced
this pull request
Nov 2, 2018
This follows up on the work in PR #16924
69 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
There were quite a few older rules supporting HTTPS to HTTPS redirects that we generally would like to clean and move towards a safer and more reliable service as an extension.
The Concerns:
Reasoning:
Plan