This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

If possible, rewrite the rulesets in a way that does not require HTTPS->HTTPS rules. #10843

Closed

37 of 69 tasks

ghost opened this issue Jul 1, 2017 · 30 comments

Closed

37 of 69 tasks

If possible, rewrite the rulesets in a way that does not require HTTPS->HTTPS rules. #10843

ghost opened this issue Jul 1, 2017 · 30 comments

ghost commented Jul 1, 2017 •

edited by Bisaloo

Loading

ghost mentioned this issue

Only modify HTTP requests #10839

Closed

This was referenced Jul 1, 2017

[Stack-exchange] Simplify ruleset #10844

Merged

Update Ghostery related rulesets #10849

Merged

Collaborator

cschanaj commented Jul 2, 2017

Noted that the following rulesets do not rewrite HTTPS.

bfffe47dc9d0e3cc663ae55b4194150d7b2e7c996c753a16201aeece1ff526ae  Cato-Institute.xml
7a5412172a8a5c73ff51b177413b29539199397763dc5b11024ec0b7423df9c9  Epson.xml
f0da196f4b2f1f2a8fb0e7960c6e577b90781baf21e42dc677b041d13773f187  GoogleMaps.xml
b37bc0c3b107c55924fa5487231eab4004c6e6e6d581d7fac38ab2b1138c7d35  LiveJournal.xml
5f637cd0be002fb0f0cb2c3d13bc35d6baeef5ea76fccb62d93bf4d5b182bf9d  Tesco.xml
4a8a859f2bf60badb5d1f2363d4fb0c501ec63d8a5d11838e142afe913408375  Yandex.xml
667f0af26100508747674a3000fec0f25d4b73da00552894b743666bbba269c1  ZeniMax-Media.xml

This was referenced Jul 2, 2017

[Kiva.org] Update and reactivate ruleset #10232

Merged

[ZeniMax-Media] Split and fix rulesets #10853

Merged

Proposal: Consider removing https -> https/http rewrite rules? #1327

Closed

This was referenced Jul 17, 2017

[Linuxaria.com] Simplify ruleset #11188

Merged

[Unblocked] Add domains and simplify ruleset #11208

Merged

[Minijob-zentrale.de] Simplify rewrite rule #11209

Merged

[Agol.dk] Remove https rewrite #11210

Merged

[Mutterschaftsgeld.de] Remove https rewrite and update default_off #11212

Merged

[Stallman.org] Simplify ruleset #11213

Merged

This was referenced Jul 18, 2017

Update AdultShopping.com.xml #11215

Closed

Delete Austin_Fit_Magazine.com.xml #11216

Merged

Update BME.hu.xml #11217

Closed

Update CafePress.xml #11219

Closed

Delete Cashback.co.uk.xml #11220

Closed

Update Demonoid.xml #11221

Closed

This was referenced Jul 18, 2017

[Deutsche-Rentenversicherung.de] Simplify and reactivate ruleset #11227

Merged

[VirusBulletin.com] Simplify and reactivate ruleset #11228

Merged

Delete Sandbag.xml #11243

Merged

J0WI mentioned this issue

Do not process URLs that use file or ftp scheme #11231

Closed

Bisaloo mentioned this issue

[Ntop.org] Update and reactivate ruleset #10061

Merged

Collaborator

cschanaj commented Jul 24, 2017 •

edited

Loading

Please also note the following rulesets found by the following command in #11024 (review).

grep -Fl '^(?:http://(?:www\.)?|https://)' *.xml

fa3af743b1c53d079a9203e4876402e083fa4f5541b37aafbc916dc5c7c455e6  Care-Net.xml
961a6238a3fbb95a5f04b424843a8797185dd067488186944281f9b8c5314502  CA-State-Board-of-Equalization.xml
3bd8a37cd7bae417e479bfce375448bc0a557c7cd71dda1697a78fc250d4501c  EarthLink.xml
edbf455dd9b2344758f0e3861ebfe53c956596a2b71a36bb782cbb5a379bf527  HealthCheckUSA.xml
9ef73c2c7642cb622145154e9b86859f1b55598fd5a97f29a9bde51764528fe6  MyEdAccount.Com.xml
944ee1959b21eb47077b1bad494a3be3985c59f18b472b2ea0c9204c34ce5a2c  MYEDDEBT.com.xml
6579a09fbc23ca93ce9956cd0c8c250f5a007a687a836e4a0b62a919c5744eb7  Volgistics.xml

Also

grep -F 'http(s):' *.xml

1ef0c6ba2c29ec438decf608df47b2b325d19b3f9ced3f00c2e6e86201641661  sourcefoundry.org.xml

This was referenced Jul 24, 2017

Update EarthLink.xml #10804

Merged

Simply SourceFoundry.org.xml #11336

Merged

Update Unity.xml #11338

Merged

Collaborator

cschanaj commented Jul 28, 2017

Also note that the following ruleset

3d5bde747e8aaff058056b970800a53151f89006704db8cb2559e55f2ac8ef9b  ED.gov.xml

found by

grep -Fl '^(http://(www\.)?|https://)' *.xml

cschanaj mentioned this issue

Update ED.gov.xml #11455

Merged

Contributor

jeremyn commented Aug 21, 2017

I'm not sure how I would do that, if I wanted to. The project is almost entirely volunteer-driven except for a few paid EFF people who also have other responsibilities.

Bisaloo mentioned this issue

[Volgistics.com] Simplify ruleset #12055

Merged

cschanaj mentioned this issue

Update HealthCheckUSA.xml (disabled twice) #12099

Merged

This was referenced Sep 4, 2017

[Numergy.com] Simplify and reactivate ruleset #12453

Merged

[Parkerpen.com] Simplify ruleset #12454

Merged

Author

ghost commented Oct 30, 2017

Rewrite phoronix.com: https://www.phoronix.com/scan.php?page=news_item&px=HTTPS-Default-Everyone

https-everywhere-bot bot commented Oct 31, 2017

I still don't see the type of issue in your description. Can you edit your issue to add this (perhaps referring to the issue template?)

7 similar comments

https-everywhere-bot bot commented Oct 31, 2017

I still don't see the type of issue in your description. Can you edit your issue to add this (perhaps referring to the issue template?)

https-everywhere-bot bot commented Oct 31, 2017

I still don't see the type of issue in your description. Can you edit your issue to add this (perhaps referring to the issue template?)

https-everywhere-bot bot commented Oct 31, 2017

I still don't see the type of issue in your description. Can you edit your issue to add this (perhaps referring to the issue template?)

https-everywhere-bot bot commented Oct 31, 2017

I still don't see the type of issue in your description. Can you edit your issue to add this (perhaps referring to the issue template?)

https-everywhere-bot bot commented Oct 31, 2017

I still don't see the type of issue in your description. Can you edit your issue to add this (perhaps referring to the issue template?)

https-everywhere-bot bot commented Oct 31, 2017

I still don't see the type of issue in your description. Can you edit your issue to add this (perhaps referring to the issue template?)

https-everywhere-bot bot commented Oct 31, 2017

I still don't see the type of issue in your description. Can you edit your issue to add this (perhaps referring to the issue template?)

Contributor

jeremyn commented Oct 31, 2017

@strugee What's going on with the bot?

https-everywhere-bot bot commented Oct 31, 2017

Thanks! Your edit helped me out. I'll take it from here now.

Contributor

strugee commented Nov 1, 2017

@jeremyn yikes! That shouldn't be happening.

Did you (un)check a bunch of boxes? If so I bet GitHub sent a bunch of edit events to the bot when that happened and the bot complained due to the missing issue type metadata. In theory this shouldn't happen as of #13294 landing but I wrote that PR pretty late at night, and I think I forgot to test the date handling code.

If this sounds right to you I'll look into this and hopefully prepare a PR fixing it 👍

Contributor

jeremyn commented Nov 1, 2017

@strugee This isn't my PR, I just noticed the bot having trouble. Maybe @koops76 could give more diagnostic information.

Author

ghost commented Nov 1, 2017

@strugee Each time I check the checkbox it sends an edit event, this is why the bot posted many times.

Contributor

jeremyn commented Nov 1, 2017

@strugee See also issue #3069 which has a similar problem.

strugee mentioned this issue

Ignore edits to issues predating the bot #13460

Merged

Contributor

strugee commented Nov 2, 2017

Filed #13460 to fix this behavior.

This was referenced Mar 31, 2018

Delete 7Headlines.com.xml #15036

Merged

Update and combine Steam related rulesets #15087

Merged

This was referenced Apr 8, 2018

Allow only from=^http: in relaxng #15113

Closed

[YMLP.com] Simplify ruleset #15114

Closed

Delete California-STD-HIV-Training.xml #15115

Merged

jeremyn mentioned this issue

Redirect conflict with uBlock Origin #14961

Closed

Collaborator

Bisaloo commented Nov 8, 2018

This is fixed by #16924 and #17043

Bisaloo closed this as completed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.