Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Early return for URLS that are already HTTPS #17010

Merged
merged 1 commit into from
Nov 2, 2018

Conversation

zoracon
Copy link
Contributor

@zoracon zoracon commented Nov 1, 2018

This follows up on the work in PR #16924.

@cschanaj
Copy link
Collaborator

cschanaj commented Nov 2, 2018

This will bring significant performance improvement to HTTPSE. Thanks for the PR.

However, I am guessing that the users will no longer be able to disable certain rulesets from the UI. It might worth investigations. cc @Hainish @J0WI @Bisaloo

P.S. I am more inclined to merging this anyway

Copy link
Member

@jsha jsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: There are about four rulesets that still potentially rewrite HTTPS-to-HTTPS (that were missed in @zoracon's previous pass due to unusual regexes). However, we've reviewed those and the HTTPS-to-HTTPS rewrites aren't needed anymore, so we can merge this without waiting on the corresponding ruleset PR.

@jsha jsha merged commit b056c3d into EFForg:master Nov 2, 2018
Hainish added a commit that referenced this pull request Nov 26, 2018
@zoracon zoracon deleted the stop-rewriting-https branch May 15, 2020 00:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants