-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Conversation
<target host="steamrep.com" /> | ||
<target host="www.steamrep.com" /> | ||
|
||
<rule from="^http://(www\.)?steamrep\.com/" to="https://www.steamrep.com/" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this actually doesn't work with the full www.steamrep.com -- maybe remove the www prefix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just simplify to
<rule from="^http:"
to="https:" />
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @semenko's suggestion is better: Since only steamrep.com works over HTTPS, both steamrep.com and www.steamrep.com should redirect to the HTTPS version of steamrep.com.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @semenko's suggestion is better: Since only steamrep.com works over HTTPS, both steamrep.com and www.steamrep.com should redirect to the HTTPS version of steamrep.com.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://www.steamrep.com works fine (i.e. no SSL error). 2d1 prefers not to preempting server's redirect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I'm the author of this pull, I created a new account and I don't use the old one anymore, do I need to create new pull requests for this and the others pulls? Or if not how can I edit this pull with my new account? |
@Ekaris if you still can access your old account, I suggest closing this pull and create a new pull under your current account. or else, just create a new pull and reference this pull. |
Closed in favor of #3211 |
No description provided.