Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Create Steamrep.com.xml #1222

Closed
wants to merge 1 commit into from
Closed

Create Steamrep.com.xml #1222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/chrome/content/rules/Steamrep.com.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<ruleset name="Steamrep.com">
<target host="steamrep.com" />
<target host="www.steamrep.com" />

<rule from="^http://(www\.)?steamrep\.com/" to="https://www.steamrep.com/" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this actually doesn't work with the full www.steamrep.com -- maybe remove the www prefix?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just simplify to

<rule from="^http:"
    to="https:" />

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @semenko's suggestion is better: Since only steamrep.com works over HTTPS, both steamrep.com and www.steamrep.com should redirect to the HTTPS version of steamrep.com.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @semenko's suggestion is better: Since only steamrep.com works over HTTPS, both steamrep.com and www.steamrep.com should redirect to the HTTPS version of steamrep.com.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.steamrep.com works fine (i.e. no SSL error). 2d1 prefers not to preempting server's redirect.

Copy link
Member

@jsha jsha Jul 15, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

</ruleset>