-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Conversation
You may split this up in multiple PRs, that makes it easier to review. |
I will do that in future pulls thanks |
@@ -0,0 +1,6 @@ | |||
<ruleset name="Cp.pt"> | |||
<target host="cp.pt" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I just delete second line? It will be the same as third line that way I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a secure redirect this way.
You need to add the following line before the generic redirect:
<rule from="^http://cp\.pt/" to="https://www.cp.pt/" />
It is good now J0WI? I wasn't able to do the vendas.cp.pt redirect if you could tell me what to write I would be grateful, many thanks |
You don't need to add exclusions/test urls for hosts that are not in a target. |
https://sites.cp.pt/ | ||
http://amf.cp.pt/ | ||
|
||
You should add: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These comments are obsolete ;)
Remove some comments
@J0WI So basically what I need to do is remove all exclusions/test urls and its good now? |
Remove exclusion pattern
Remove exclusion pattern
Remove exclusion pattern
Remove exclusion pattern
Remove exclusion patterns
Add venda.cp.pt to target
lgtm |
🎆 whoooo! Thanks! :) |
Please pull and close #1222 and #879