Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Many new rules #3211

Merged
merged 51 commits into from Dec 17, 2015
Merged

Many new rules #3211

merged 51 commits into from Dec 17, 2015

Conversation

ghost
Copy link

@ghost ghost commented Nov 16, 2015

Please pull and close #1222 and #879

@ghost ghost changed the title Create Steamrep.com.xml Create Steamrep.com.xml Gamesrocket.de.xml Kinguin.net.xm Whosgamingnow.net.xml Nextpowerup.com.xml Nov 16, 2015
@ghost ghost changed the title Create Steamrep.com.xml Gamesrocket.de.xml Kinguin.net.xm Whosgamingnow.net.xml Nextpowerup.com.xml Create Steamrep.com.xml Gamesrocket.de.xml Kinguin.net.xml Whosgamingnow.net.xml Nextpowerup.com.xml Speedof.me.com.xml Nov 21, 2015
@ghost ghost changed the title Create Steamrep.com.xml Gamesrocket.de.xml Kinguin.net.xml Whosgamingnow.net.xml Nextpowerup.com.xml Speedof.me.com.xml Create Steamrep.com.xml Gamesrocket.de.xml Kinguin.net.xml Whosgamingnow.net.xml Nextpowerup.com.xml Speedof.me.xml Nov 21, 2015
@ghost ghost changed the title Create Steamrep.com.xml Gamesrocket.de.xml Kinguin.net.xml Whosgamingnow.net.xml Nextpowerup.com.xml Speedof.me.xml Many new rules Nov 21, 2015
@ghost ghost mentioned this pull request Nov 27, 2015
@J0WI
Copy link
Contributor

J0WI commented Nov 27, 2015

You may split this up in multiple PRs, that makes it easier to review.

@ghost
Copy link
Author

ghost commented Nov 28, 2015

I will do that in future pulls thanks

@@ -0,0 +1,6 @@
<ruleset name="Cp.pt">
<target host="cp.pt" />
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I just delete second line? It will be the same as third line that way I think

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a secure redirect this way.
You need to add the following line before the generic redirect:
<rule from="^http://cp\.pt/" to="https://www.cp.pt/" />

@ghost
Copy link
Author

ghost commented Dec 13, 2015

It is good now J0WI? I wasn't able to do the vendas.cp.pt redirect if you could tell me what to write I would be grateful, many thanks

@J0WI
Copy link
Contributor

J0WI commented Dec 15, 2015

You don't need to add exclusions/test urls for hosts that are not in a target.

https://sites.cp.pt/
http://amf.cp.pt/

You should add:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments are obsolete ;)

Remove some comments
@ghost
Copy link
Author

ghost commented Dec 15, 2015

@J0WI So basically what I need to do is remove all exclusions/test urls and its good now?

ekaris added 6 commits December 15, 2015 10:41
Remove exclusion pattern
Remove exclusion pattern
Remove exclusion pattern
Remove exclusion pattern
Remove exclusion patterns
Add venda.cp.pt to target
@J0WI
Copy link
Contributor

J0WI commented Dec 16, 2015

lgtm
cc @loveithateit

@semenko semenko mentioned this pull request Dec 17, 2015
@semenko
Copy link
Contributor

semenko commented Dec 17, 2015

🎆 whoooo! Thanks! :)

semenko added a commit that referenced this pull request Dec 17, 2015
@semenko semenko merged commit 6ac05b3 into EFForg:master Dec 17, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants