Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPStan のエラー修正 #563

Merged
merged 2 commits into from
Aug 3, 2022
Merged

Conversation

nanasess
Copy link
Contributor

  • PHP8 でNet_URL のコンストラクタを認識しないのを修正
  • MDB2 を事前にロードしておくよう修正

nanasess added 2 commits July 29, 2022 16:25
> Class Net_URL does not have a constructor and must be instantiated without any parameters.
@codecov-commenter
Copy link

Codecov Report

Merging #563 (70fc750) into master (87e2693) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #563      +/-   ##
==========================================
- Coverage   54.63%   54.61%   -0.03%     
==========================================
  Files          76       76              
  Lines        9058     9058              
==========================================
- Hits         4949     4947       -2     
- Misses       4109     4111       +2     
Flag Coverage Δ
tests 54.61% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
data/class/SC_Query.php 67.90% <0.00%> (-0.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87e2693...70fc750. Read the comment docs.

@chihiro-adachi
Copy link
Contributor

@nobuhiko
お手すきの際にPRのレビューお願いできればと思います。
問題なければApprovedお願いします。

@nobuhiko
Copy link
Contributor

nobuhiko commented Aug 3, 2022

@chihiro-adachi しましたー

@chihiro-adachi chihiro-adachi merged commit 1a24dff into EC-CUBE:master Aug 3, 2022
@chihiro-adachi
Copy link
Contributor

@nanasess @nobuhiko
ありがとうございます、マージしました。

@nanasess nanasess deleted the fix-phpstan branch October 3, 2022 08:10
@nanasess nanasess added this to the 2.18(仮) milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants