Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LC_Page_Admin_*_Ex のクラスパスが正常に取得できないのを修正 #553

Merged
merged 3 commits into from
Aug 3, 2022

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented May 6, 2022

LC_Page_Admin_Aaa_Bbb_Ex の場合、 class_extends/page_extends/aaa/bbb/LC_Page_Admin_Aaa_Bbb_Ex.php をロードしようとしてしまうのを修正

@nanasess nanasess changed the title [WIP] LC_Page_Admin_*_Ex のクラスパスが正常に取得できないのを修正 LC_Page_Admin_*_Ex のクラスパスが正常に取得できないのを修正 Aug 1, 2022
@nanasess nanasess marked this pull request as ready for review August 1, 2022 06:36
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2022

Codecov Report

Merging #553 (03664ad) into master (2f6eb97) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #553      +/-   ##
==========================================
+ Coverage   54.63%   54.64%   +0.01%     
==========================================
  Files          76       76              
  Lines        9058     9060       +2     
==========================================
+ Hits         4949     4951       +2     
  Misses       4109     4109              
Flag Coverage Δ
tests 54.64% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
data/class/SC_ClassAutoloader.php 80.64% <100.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f6eb97...03664ad. Read the comment docs.

@nanasess nanasess force-pushed the fix-admin-autoloader branch from 3a80cf4 to 03664ad Compare August 1, 2022 08:47
@nanasess
Copy link
Contributor Author

nanasess commented Aug 1, 2022

テストのエラーは #562, #563 で解消されます

@chihiro-adachi chihiro-adachi added this to the 2.17.3 milestone Aug 3, 2022
@chihiro-adachi chihiro-adachi merged commit c8b4836 into EC-CUBE:master Aug 3, 2022
@chihiro-adachi
Copy link
Contributor

@nanasess
ありがとうございます、マージしました

@nanasess nanasess deleted the fix-admin-autoloader branch October 3, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants