Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPStan のエラー修正 #563

Merged
merged 2 commits into from
Aug 3, 2022
Merged

PHPStan のエラー修正 #563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d64ecc6
Fix phpstan
nanasess Jul 29, 2022
70fc750
PHPStan が MDB2 を見つけてくれないのを修正
nanasess Jul 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions data/module/Net/URL.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,16 +106,6 @@ class Net_URL
*/
var $useBrackets;

/**
* PHP4 Constructor
*
* @see __construct()
*/
function Net_URL($url = null, $useBrackets = true)
{
$this->__construct($url, $useBrackets);
}

/**
* PHP5 Constructor
*
Expand All @@ -127,7 +117,7 @@ function Net_URL($url = null, $useBrackets = true)
* multiple querystrings with the same name
* exist
*/
function __construct($url = null, $useBrackets = true)
public function __construct($url = null, $useBrackets = true)
{
$this->url = $url;
$this->useBrackets = $useBrackets;
Expand Down
6 changes: 4 additions & 2 deletions tests/require.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,10 @@
exit(1);
}

class_exists('FPDI'); // XXX PHPStan が FPDI を見つけてくれないのでロードしておく
class_exists('Smarty'); // XXX PHPStan が Smarty を見つけてくれないのでロードしておく
// XXX PHPStan が見つけてくれないライブラリをロードしておく
class_exists('FPDI');
class_exists('Smarty');
class_exists('MDB2');

if (!class_exists('PHPUnit_Framework_TestCase')) {
class_alias('PHPUnit\Framework\TestCase', 'PHPUnit_Framework_TestCase');
Expand Down