Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use data (prescribed) ice-shelf melt fluxes in MPAS-Ocean #45

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Mar 29, 2023

This merge adds a new package and mode for data melt fluxes. When config_land_ice_flux_mode = 'data', land-ice freshwater and sensible-heat fluxes are assigned from the prescribed fields, which can be read in at initialization or from a stream.

rgknox added 25 commits March 27, 2023 10:13
…n up or down (current setting is 1.0, unchanged)
…ged during updates to fates-elm nutrient coupling
@xylar xylar requested a review from cbegeman March 29, 2023 13:19
@xylar
Copy link
Collaborator Author

xylar commented Mar 29, 2023

This branch can be used in conjunction with MPAS-Dev/compass#580 to create the necessary file for prescribing melt fluxes for a given mesh.

I need to stage the appropriate file for the existing ECwISC30to60E2r1 mesh so we can test this as a stealth feature.

@xylar
Copy link
Collaborator Author

xylar commented Mar 29, 2023

This needs to build on E3SM-Project#5464. Specifically, we need to add prescribed as a mode for ice-shelf melting in E3SM after the changes made there to fix incorrect values for non-ice-shelf meshes.

@xylar xylar force-pushed the mpas-ocean/add-prescribed-land-ice-fluxes branch from b1b2411 to c1bd30d Compare March 30, 2023 08:12
@xylar xylar changed the base branch from alternate to master April 29, 2023 15:03
darincomeau and others added 2 commits May 8, 2023 14:36
It fixed an error due to the obsolete use
of IF block for array allocation. No answer change
when the code is functioning.

BFB
@xylar xylar force-pushed the mpas-ocean/add-prescribed-land-ice-fluxes branch from d197276 to 4fd38d2 Compare May 15, 2023 21:26
@xylar xylar changed the base branch from master to alternate May 15, 2023 21:46
@xylar xylar changed the base branch from alternate to master May 15, 2023 21:46
@xylar xylar force-pushed the mpas-ocean/add-prescribed-land-ice-fluxes branch from 4fd38d2 to 4799591 Compare May 15, 2023 22:01
Updates BeTR submodule to fix an error due to the obsolete use of
an if-block for array allocation. The update hash for the BeTR submodule is 25c892a.

Fixes E3SM-Project#5539
[BFB]
@xylar xylar force-pushed the mpas-ocean/add-prescribed-land-ice-fluxes branch from 4799591 to 038793c Compare May 15, 2023 22:17
jonbob and others added 2 commits May 16, 2023 11:32
…oject#5630)

Corrects thin ice/snow treatment of enthalpy and other tracers

This fix redistributes enthalpy and other tracers evenly in snow and ice
when their respective thicknesses are < 1e-15 . Previously, these
tracers were zero'd non-conservatively.

Also corrects a bug in the zeroing of snow thicknesses, and removes snow
in thickness_changes if the ice vanishes.

Fixes E3SM-Project#5124

[non-BFB]
This set of changes refactors the logic behind N and P supplementation in land bgc.
Also, ecosystem (free-living) N fixation was enabled for fates runs.

[non-BFB]
@xylar
Copy link
Collaborator Author

xylar commented May 16, 2023

I ran a 5-year G-case with this branch. Results are here and look good to me:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xasay-davis/analysis/20230515.GMPAS-IAF-DISMF.T62_ECwISC30to60E2r1.chrysalis/

@xylar xylar force-pushed the mpas-ocean/add-prescribed-land-ice-fluxes branch from 038793c to a5b2366 Compare May 17, 2023 01:55
…#5669)

Change SOwISC12to60E2r4 ocn domain file to masked version

This changes the default ocean domain file for the SOwISC12to60E2r4 mesh
to be the masked version, consistent with the ECwISC30to60E2r1 mesh.
With the previous nomask version, D-cases with this mesh were failing.

Fixes E3SM-Project#5653

[BFB]
@xylar
Copy link
Collaborator Author

xylar commented May 17, 2023

Here are the analysis results for a 5-year SORRM G-case with data melt rates:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xasay-davis/analysis/20230516.GMPAS-IAF-DISMF.T62_SOwISC12to60E2r4.chrysalis/

Everything looks good and the melt rates averaged over regions on the SORRM mesh are more similar to the averages over the same regions from the original Adusumilli data than on the EC mesh (as expected because of the higher resolution). Even so, we consistently slightly underestimate the melt, presumably because of missing portions of the floating ice domain and/or interpolation artifacts.

@xylar
Copy link
Collaborator Author

xylar commented May 17, 2023

This is a stealth feature so I need to add a new test.

@xylar
Copy link
Collaborator Author

xylar commented May 17, 2023

It looks like we want the stealth test to run on the oQU240wLI mesh, so I'll need to create the data ISMF for that mesh.

@xylar
Copy link
Collaborator Author

xylar commented May 17, 2023

I actually don't think this counts as a stealth feature because you can set up and run both E3SM tests and cases right out of the box with DISMF. So I will add some extended tests for it following what we have for PISMF.

xylar added 6 commits May 17, 2023 17:57
This merge adds a new package and mode for prescribed melt fluxes.
When config_land_ice_flux_mode = 'data', land-ice freshwater
and sensible-heat fluxes are assigned from the prescirbed fields,
which can be read in at initializaiton or from a stream.
@xylar
Copy link
Collaborator Author

xylar commented May 18, 2023

Closed in favor of E3SM-Project#5698

@xylar xylar closed this May 18, 2023
xylar pushed a commit that referenced this pull request Nov 8, 2023
Move comments to Registry and update bld files to match
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants