Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix array allocation error in BeTR #5676

Merged
merged 1 commit into from
May 15, 2023
Merged

Conversation

jinyuntang
Copy link
Contributor

@jinyuntang jinyuntang commented May 9, 2023

Updates BeTR submodule to fix an error due to the obsolete use of
an if-block for array allocation. The update hash for the BeTR submodule is 25c892a.

Fixes #5539
[BFB]

It fixed an error due to the obsolete use
of IF block for array allocation. No answer change
when the code is functioning.

BFB
@jinyuntang jinyuntang requested a review from bishtgautam May 9, 2023 23:37
@jinyuntang
Copy link
Contributor Author

@ndkeen I have fixed the issue #5539. It is due to an obsolete use of IF block with the most recently fortran compilers. No answer change occurred. Please test.
@bishtgautam please review.

@ndkeen
Copy link
Contributor

ndkeen commented May 10, 2023

I can verify this fix does allow the test to run.

@rljacob
Copy link
Member

rljacob commented May 10, 2023

To fix this you must be updating the submodule for betr. Please mention which hash of betr is being used now in the PR description above.

@jinyuntang
Copy link
Contributor Author

To fix this you must be updating the submodule for betr. Please mention which hash of betr is being used now in the PR description above.
@rljacob
It is 25c892a, the most recent commit in the sbetr master branch.

@bishtgautam bishtgautam changed the title Fix array allocation error in betr, issue #5539 Fix array allocation error in BeTR May 10, 2023
@ndkeen
Copy link
Contributor

ndkeen commented May 10, 2023

With mention of changes to betr submodule, would it be possible for someone to make a change to the maint-1.0 branch in betr? I have copy of the file that needs to be replaced -- it's solely to get around issues discovered building with GCC version 10 and higher.

@bishtgautam
Copy link
Contributor

PR #5679 addresses @ndkeen's comment above.

bishtgautam added a commit that referenced this pull request May 10, 2023
Updates BeTR submodule to fix an error due to the obsolete use of
an if-block for array allocation. The update hash for the BeTR submodule is 25c892a.

Fixes #5539
[BFB]
@bishtgautam bishtgautam merged commit fed770a into master May 15, 2023
@bishtgautam bishtgautam deleted the jinyuntang/lnd/betr_SMS_D.fix branch May 15, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants