Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPAS-SI crashes on small timesteps #5124

Closed
mkstratos opened this issue Aug 10, 2022 · 0 comments · Fixed by #5630
Closed

MPAS-SI crashes on small timesteps #5124

mkstratos opened this issue Aug 10, 2022 · 0 comments · Fixed by #5630
Assignees

Comments

@mkstratos
Copy link
Contributor

See issue #5072: "MPAS-SI crashes when running in thermodynamic mode (F cases) with small time steps."
When dtime=1, as used in the time step convergence (TSC) test, an issue occurs with MPAS-SI at a particular time step.

It seems to depend on input data, as for different initial atmosphere / land conditions causes the problem to appear at different time steps (#5072 (comment)).

njeffery added a commit that referenced this issue Nov 10, 2022
To be tested as a possible fix to #5124 - mpas-si crashes on small timesteps
bug fix.
nonBFB
njeffery added a commit that referenced this issue Apr 12, 2023
To be tested as a possible fix to #5124 - mpas-si crashes on small timesteps bug fix

For snow/ice thicknesses < puny but > 0, enthalpy and other adjusted tracers are spread evenly among layers.
Non-BFB
jonbob added a commit that referenced this issue May 15, 2023
#5630)

Corrects thin ice/snow treatment of enthalpy and other tracers

This fix redistributes enthalpy and other tracers evenly in snow and ice
when their respective thicknesses are < 1e-15 . Previously, these
tracers were zero'd non-conservatively.

Also corrects a bug in the zeroing of snow thicknesses, and removes snow
in thickness_changes if the ice vanishes.

Fixes #5124

[non-BFB]
@jonbob jonbob closed this as completed in a0487df May 16, 2023
darincomeau pushed a commit to darincomeau/E3SM that referenced this issue Jun 2, 2023
To be tested as a possible fix to E3SM-Project#5124 - mpas-si crashes on small timesteps bug fix

For snow/ice thicknesses < puny but > 0, enthalpy and other adjusted tracers are spread evenly among layers.
Non-BFB
darincomeau pushed a commit that referenced this issue Jun 20, 2023
To be tested as a possible fix to #5124 - mpas-si crashes on small timesteps bug fix

For snow/ice thicknesses < puny but > 0, enthalpy and other adjusted tracers are spread evenly among layers.
Non-BFB
darincomeau pushed a commit that referenced this issue Jul 10, 2023
To be tested as a possible fix to #5124 - mpas-si crashes on small timesteps bug fix

For snow/ice thicknesses < puny but > 0, enthalpy and other adjusted tracers are spread evenly among layers.
Non-BFB
darincomeau pushed a commit that referenced this issue Jul 25, 2023
To be tested as a possible fix to #5124 - mpas-si crashes on small timesteps bug fix

For snow/ice thicknesses < puny but > 0, enthalpy and other adjusted tracers are spread evenly among layers.
Non-BFB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment