i#4328 AArch64 prefetch and flush instrs: Add trace types for prefetch instructions #4341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… prefetch instrs. Adds new trace types for AArch64 prfm and prfum instructions. These prefetch instructions have multiple variants based on: - prefetch target: this may be the L1, L2 or L3 cache - prefetch policy: either temporal or non-temporal - type: prefetch may be for load, instruction or store Also makes changes to account for these new prefetch trace types in drcachesim. Issue: #4328
Based on logs the aarch64-linux-gnu-gcc cross-compiler is missing, which is causing 'no such instruction' errors for AArch64 prfm/prfum instructions in prefetch_aarch64_app.c. Verified locally that it compiles with aarch64-linux-gnu-gcc. Also, remove macro added earlier which is not the solution.
This is required to fix the DYNAMORIO_A64_ON_X86_ONLY Travis build.
__builtin_prefetch is not invoked when the test is compiled with -m32. This leads to zero prefetch counts.
abhinav92003
commented
Jun 30, 2020
clients/drcachesim/tests/prefetch-aarch64-basic-counts.templatex
Outdated
Show resolved
Hide resolved
Didn't realise that I had used this before. Even though alternative operators are C++ standard, it might be better to avoid them for clarity.
|
Travis is failing for macOS: https://travis-ci.com/github/DynamoRIO/dynamorio/jobs/355707609. I couldn't find any useful information to debug this in the log, except that it exited with code 2. @derekbruening any idea what may be the cause? |
See #4223. Somehow when the Mac build/tests fail the output is truncated. Maybe a Travis bug. Do you have a Mac you could repro on? |
derekbruening
requested changes
Jun 30, 2020
clients/drcachesim/tests/prefetch-aarch64-basic-counts.templatex
Outdated
Show resolved
Hide resolved
This is an attempt to fix the truncated log issue for macOS on Travis. It was suggested as a workaround at travis-ci/travis-ci#8973
This reverts commit 18c2a9d.
…ed on AArch64. We expect that testing for exact prefetch counts will be flaky. Hence, we modify existing output templates to accept any non-zero value of prefetch counts. To test exact counts, we use a checked-in offline trace instead.
Some tests are unable to read the trace file, probably because zlib is absent.
abhinav92003
commented
Jul 6, 2020
…ounts. Also remote redundant AArch64 C inline asm test.
…types. This is in preparation to re-use trace types for prefetch instrs of different architectures, where possible.
abhinav92003
commented
Jul 10, 2020
This is required because these trace types got rearranged in a previous commit.
clients/drcachesim/tests/offline-allasm-aarch64-prefetch-counts.templatex
Outdated
Show resolved
Hide resolved
clients/drcachesim/tests/offline-builtin-prefetch-basic-counts.templatex
Outdated
Show resolved
Hide resolved
abhinav92003
commented
Jul 15, 2020
derekbruening
approved these changes
Jul 15, 2020
…h types. Based on documentation, some AArch64 prefetch encodings are not accessible using prfop.
derekbruening
added a commit
that referenced
this pull request
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new trace types for AArch64 prfm and prfum instructions. These prefetch instructions have multiple variants based on:
Also makes changes to account for these new prefetch trace types in drcachesim.
Issue: #4328