Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get token interface #80

Merged
merged 2 commits into from
Apr 21, 2023
Merged

get token interface #80

merged 2 commits into from
Apr 21, 2023

Conversation

mjkkirschner
Copy link
Member

@mjkkirschner mjkkirschner commented Apr 20, 2023

Purpose

https://jira.autodesk.com/browse/DYN-4771
add interface to allow integrators access to bearer token so it can be used to take advantage of single sign on within a graph.

update version number

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.

@mjkkirschner mjkkirschner changed the title Token get token interface Apr 20, 2023
/// <summary>
/// Implement this interface to provide direct access to the current bearer token.
/// </summary>
public interface IOAuth2AccessTokenProvider
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it help if this derives from IOAuth2AuthProvider?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is a big difference - I guess this is slightly more flexible, but it would be nice to break IOAuth2AuthProvider and merge these together in the near future - maybe at GL 25.

@mjkkirschner mjkkirschner merged commit 77f6bd7 into DynamoDS:master Apr 21, 2023
@mjkkirschner mjkkirschner deleted the token branch April 21, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants