Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get token interface #80

Merged
merged 2 commits into from
Apr 21, 2023
Merged

get token interface #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5995def
new interface
mjkkirschner Apr 20, 2023
1c30348
update vers
mjkkirschner Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/AssemblyInfoGenerator/AssemblyInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
// to distinguish one build from another. AssemblyFileVersion is specified
// in AssemblyVersionInfo.cs so that it can be easily incremented by the
// automated build process.
[assembly: AssemblyVersion("2.2.0.1056")]
[assembly: AssemblyVersion("2.4.0.4747")]


// By default, the "Product version" shown in the file properties window is
Expand All @@ -55,4 +55,4 @@
// You can specify all the values or you can default the Build and Revision Numbers
// by using the '*' as shown below:
// [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyFileVersion("2.2.0.1056")]
[assembly: AssemblyFileVersion("2.4.0.4747")]
2 changes: 1 addition & 1 deletion src/AssemblyInfoGenerator/AssemblyInfo.tt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ using System.Runtime.InteropServices;
[assembly: AssemblyFileVersion("<#= this.MajorVersion #>.<#= this.MinorVersion #>.<#= this.BuildNumber #>.<#= this.RevisionNumber #>")]
<#+
int MajorVersion = 2;
int MinorVersion = 3;
int MinorVersion = 4;
int BuildNumber = 0;
// The datetime baseline we choose using this algorithm will affect build number and all nuget packages uploaded
// Please only change when major or minor version got incremented
Expand Down
7 changes: 7 additions & 0 deletions src/GregClient/AuthProviders/IAuthProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,11 @@ public interface IOAuth2AuthProvider : IAuthProvider
/// <param name="client"></param>
new void SignRequest(ref RestRequest m, RestClient client);
}
/// <summary>
/// Implement this interface to provide direct access to the current bearer token.
/// </summary>
public interface IOAuth2AccessTokenProvider
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it help if this derives from IOAuth2AuthProvider?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is a big difference - I guess this is slightly more flexible, but it would be nice to break IOAuth2AuthProvider and merge these together in the near future - maybe at GL 25.

{
string GetAccessToken();
}
}