Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement new token interface #13917

Merged
merged 3 commits into from
Apr 24, 2023
Merged

Conversation

mjkkirschner
Copy link
Member

Purpose

depends on this PR:
DynamoDS/PackageManagerClient#80

implement new interface

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

make single sign on usable from graphs

Reviewers

@mjkkirschner
Copy link
Member Author

mjkkirschner commented Apr 24, 2023

pass here:
https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/9005/

@zeusongit - I notice that this failure occurred AFTER I merged your changes, and I also noticed that these tests actually put real load on the package manager to get the hosts lists - if for some reason the package manager returns an empty list or times out during a test run, the garbage value may now be cached.

I've only seen it infrequently, but perhaps we should either make the cache short lived, only cache if the result is not garbage, and in addition make these tests use mocks.

@mjkkirschner mjkkirschner merged commit c35aeee into DynamoDS:master Apr 24, 2023
@mjkkirschner mjkkirschner deleted the accesstoken branch April 24, 2023 22:14
mjkkirschner added a commit to mjkkirschner/Dynamo that referenced this pull request Apr 26, 2023
* implement new interface

* update to released greg
QilongTang pushed a commit that referenced this pull request Apr 27, 2023
* implement new interface

* update to released greg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants