-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Nuspecs Net folder version #9250
Conversation
LGTM |
@QilongTang does revit and samples build after this change - I guess we need to update those repos? |
@mjkkirschner Sure, but DynamoRevit will not break until we publish the new nugets publicly. So we can actually safely merge this PR, make the changes in DynamoRevit repo, copy the locally built nuget over and make sure DynamoRevit builds and publish in the end. |
@QilongTang is there a way to autogenerate the |
@aparajit-pratap Good point! It is actually possible, but harder to maintain in our case because:
So these two reasons making the automation less appealing to us in exchange of the benefit that dependencies appear automatically in the nuspec. I think this approach makes better sense if we have less nugets managing and assuming they all come from a corresponding csproj file. |
I guess another consideration here is do we want to configure dynamos core build to produce both .net 45 and 47 targets. |
@mjkkirschner I think it would be valuable to do so which require us to have two sln file and build both in the Dynamo CI/CD. Inside the group, we will take this as a requirement for the new DynamoCore CI/CD pipeline. Do you think we need to make it happen by Dynamo 2.1 release? If that's the case, we need to work with BRE team right now, otherwise gonna miss the boat. Or you are fine doing it at next release using hopefully the "new Pipeline" |
fine with after 2.1 |
Looking at the changes more carefully, since this change is applied to DynamoRuntime and SignDynamo nugets internally, we may need to update our build script and Revit CI/CD as well. I am going to at least merge it and publish the nuget using Jenkins tonight. Follow up PR: DynamoDS/DynamoRevit#2272 |
Please Note:
DynamoRevit
repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTM
label is added to the PR.Purpose
DYN-947
Update DynamoCore Nugets to bundle net 47
Since all projects under Dynamo.All.sln is converted to build with .Net 4.7, updating our nuspec defination to put them under correct folder
Net47
Inside Dynamo.all.sln, we do not need to update project reference unless we update
Greg
soon to build on .Net 4.7.I will check if I can use any public repo in DynamoDS org to validate this work, but even that will happen after this PR merged.
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@alfarok @ColinDayOrg @aparajit-pratap
FYIs
@mjkkirschner