Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nugets NET 47 updates #2272

Merged
merged 3 commits into from
Nov 29, 2018
Merged

Nugets NET 47 updates #2272

merged 3 commits into from
Nov 29, 2018

Conversation

QilongTang
Copy link
Contributor

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

Follow up PR of DynamoDS/Dynamo#9250. I will not merge until the new nugets are there on nuget.org

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • Snapshot of UI changes, if any.

Reviewers

FYIs

@mjkkirschner @ZiyunShang @AndyDu1985

@QilongTang
Copy link
Contributor Author

@ZiyunShang @AndyDu1985 @mjkkirschner I installed latest Revit Preview Release and sln built with this change. Merging. This should not impact the CI/CD but if it happens, let me know

@QilongTang QilongTang merged commit 2bf4398 into master Nov 29, 2018
@QilongTang QilongTang deleted the NugetNET47 branch November 29, 2018 16:10
@ZiyunShang
Copy link
Collaborator

Hi @QilongTang , is there a changelist in DynamoCore 2.1.0-beta6967? I found a new folder called IronPython.StdLib.2.7.8 was added. Is this a required component in Dynamo runtime?

@QilongTang
Copy link
Contributor Author

@ZiyunShang That is a result of update to the newer version of IronPython. @alfarok This is expected new dlls added correct?

@ZiyunShang
Copy link
Collaborator

@QilongTang This folder contains a lot of Python files, I wonder if they all need to be added to the installation package? Or just components that are needed at compile time?

@mjkkirschner
Copy link
Member

These are the core libraries of python - they need to be distributed with dynamo to support user code that relies on them. python nodes and packages containing python nodes.

@mjkkirschner
Copy link
Member

see this PR for more info:
DynamoDS/Dynamo#9180

@ZiyunShang
Copy link
Collaborator

@mjkkirschner OK, I get it. Thank you for your reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants