Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please Note:
DynamoRevit
repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTM
label is added to the PR.Purpose
This fix is needed so devs can continue to build R2019 branch with latest DynamoCore references.
FYI: @mjkkirschner @Dewb @ZiyunShang @AndyDu1985 I think the nuget folder change in DynamoDS/Dynamo#9250 impact is larger than I thought since DynamoRevit legacy branches other than master are setup in a way that always consumes latest-beta of DynamoCore nugets, so the folder change is automatically consumed downstream by all of these repos. Although I think only R2019 branch should be cherry-picked because R2019 branch is supposed to have moved to .Net 47.
However, I am not sure what we should do to R2018, R2017 etc because it is broken there as well unless we provide nugets containing dlls built both with Net45 and Net47.
Declarations
Check these if you believe they are true
*.resx
filesReviewers
FYIs