Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick Nuget Net47 changes #2275

Merged
merged 1 commit into from
Nov 30, 2018
Merged

Cherry-pick Nuget Net47 changes #2275

merged 1 commit into from
Nov 30, 2018

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Nov 29, 2018

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

This fix is needed so devs can continue to build R2019 branch with latest DynamoCore references.

FYI: @mjkkirschner @Dewb @ZiyunShang @AndyDu1985 I think the nuget folder change in DynamoDS/Dynamo#9250 impact is larger than I thought since DynamoRevit legacy branches other than master are setup in a way that always consumes latest-beta of DynamoCore nugets, so the folder change is automatically consumed downstream by all of these repos. Although I think only R2019 branch should be cherry-picked because R2019 branch is supposed to have moved to .Net 47.

However, I am not sure what we should do to R2018, R2017 etc because it is broken there as well unless we provide nugets containing dlls built both with Net45 and Net47.

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • Snapshot of UI changes, if any.

Reviewers

FYIs

@QilongTang QilongTang merged commit da0b1af into Revit2019 Nov 30, 2018
@QilongTang QilongTang deleted the NugetNet47 branch November 30, 2018 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant