Fix broken behavior of IsVisibleInDynamoLibrary attribute with interfaces and Enums #9242
Conversation
aparajit-pratap
changed the title
|
|
||
| [IsVisibleInDynamoLibrary(false)] | ||
| [Serializable] | ||
| public class TraceableId : ISerializable |
There was a problem hiding this comment.
@aparajit-pratap Can you explain how this test works, I can't see how adding a class with the tag verify stuff from my knowledge.
There was a problem hiding this comment.
@QilongTang I need to think how I can test for interfaces not appearing in search and library.
There was a problem hiding this comment.
@aparajit-pratap What do you think of either screen comparison or search results comparison?
| @@ -354,6 +354,10 @@ private ClassDeclNode ParseSystemType(Type type, string alias) | |||
| CLRModuleType.GetInstance(interf, Module, string.Empty); | |||
| } | |||
| } | |||
| if(classnode.IsInterface) | |||
There was a problem hiding this comment.
Are you able to track down why this got regressed? I do not see this check existed in previous version of code
aparajit-pratap
changed the title
|
LGTM |
|
@aparajit-pratap Considering this bug should be there in Dynamo 2.0.2 as well. Do you mind cherry-picking to RC2.0.2 as well? |
…aces and Enums (DynamoDS#9242) * fix broken behavior of IsVisibleInDynamoLibrary attribute with interfaces * revert extraneous changes * fixes * added test * revert file * fix regression in IsVisibleInDynamoLibrary attribute applied to enum * add test for enum attribute fix
| { | ||
| HiddenInLibrary = true; | ||
| ObsoleteMessage = (attr as IsObsoleteAttribute).Message; | ||
| ObsoleteMessage = (attr as ObsoleteAttribute).Message; |
There was a problem hiding this comment.
@aparajit-pratap what is the difference between these attribute types?
There was a problem hiding this comment.
IsObsolete is written by us and Obsolete is a standard attribute.
Purpose
https://jira.autodesk.com/browse/QNTM-4094
Bug description: When a class implements an interface method, although it is marked hidden, the interface method still appears as a node.
This is a regression in 2.0 and can be traced back to language changes to fix polymorphism. In this change polymorphism support was added to interfaces where the interface method was allowed to accept a derived type and the node would at runtime resolve to the concrete implementation of the method matching the derived type.
This fix is to hide the interface methods altogether to address this issue as well as to remove any confusion of having extraneous interface nodes.
When attribute
IsVisibleInDynamoLibrary(false)is defined on a class the following should be the expectation:The second issue is with the
IsVisibleInDynamoLibrary(false)attribute not taking effect on an enum, which is a regression from 1.3.X. This can be traced back to the change made here . This too has been fixed, which includes the change to not have to individually set the attributes on each enum field. The attributes,IsVisibleInDynamoLibraryandObsoletecan now be applied globally on the enum, which now takes effect on all of the fields as well.Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang