public enum with [IsVisibleInDynamoLibrary(false)] still visible in library

[ksobon]

I thought that adding this attribute to a public class would hide it from the library:

    /// <summary>
    /// Parameter Filter Numeric Rules.
    /// </summary>
    [IsVisibleInDynamoLibrary(false)]
    public enum FilterNumericValueRule
    {
        /// <summary>
        /// 
        /// </summary>
        DoubleRule,
        /// <summary>
        /// 
        /// </summary>
        ElementIdRule,
        /// <summary>
        /// 
        /// </summary>
        GlobalParameterRule,
        /// <summary>
        /// 
        /// </summary>
        IntegerRule
    }

Yet, it's still showing up. That was not an issue in previous version.

[mjkkirschner]

well, this is not a class, but an enum, but I believe @ramramps and I touched enums here:
https://github.com/DynamoDS/Dynamo/pull/8311/files

I don't see anything obvious that would cause a regression though.

@ksobon does this attribute work for you on classes? - can you hide this enum by making it internal?

@alfarok do we know if this attribute is working?

[ksobon]

I mean yeah, that's an Enum but it used to work just fine like that before. Besides even in that link you posted you guys do exactly the same thing to an Enum. Just scroll down a few lines. It's a DateTime enum and you hide it with that same attribute. Was there a regression?

[mjkkirschner]

I'm not sure the enum is hidden by the [IsVisibleInDynamoLibrary(false)] or the [obsolete] attribute. I just want to be specific because enums and classes are imported differently into the VM.

Looks to me like a regression.

[ksobon]

I can't make it internal because it's shared across projects. It's a utility Enum used in a couple of places. I was able to use a different attribute: [SupressImportIntoVM] to hide it and that seems to be working:

    /// <summary>
    /// Parameter Filter Numeric Rules.
    /// </summary>
    [SupressImportIntoVM]
    public enum FilterNumericValueRule
    {
        /// <summary>
        /// 
        /// </summary>
        DoubleRule,
        /// <summary>
        /// 
        /// </summary>
        ElementIdRule,
        /// <summary>
        /// 
        /// </summary>
        GlobalParameterRule,
        /// <summary>
        /// 
        /// </summary>
        IntegerRule
    }

It would still make sense to look at re-enabling the original implementation.

[mjkkirschner]

yes, lets keep this open.

[alvpickmans]

Same issue here. I tried [SuppressImportIntoVM] without any luck.

[mjkkirschner]

Hi @alvpickmans you can't suppress jObject as you're returning it directly, return an object or some other base class instead.

[mjkkirschner]

oh I see, you want to hide JsonOption - can you share your code where this in defined or where you reference it.

[mjkkirschner]

@alvpickmans - I see it now in your source, can you try making that class internal? You can cheat and give your other assemblies access to internal classes with:
https://msdn.microsoft.com/en-us/library/system.runtime.compilerservices.internalsvisibletoattribute(v=vs.110).aspx

inside the assembly info cs

[alvpickmans]

Thanks @mjkkirschner for the tip, I will try it out and get back to you.

[alvpickmans]

I've tried this and it compiles ok without errors, but once a node needs the internal class Dynamo simply fails to find the method.
It is not a big deal to be honest, I will just note this properly for the time being. Cheers!

[alfarok]

This regression is being tracked with QNTM-4094. The issue came up in the Dynamo Samples and was also circumvented by suppressing the import into the VM but more investigation is required for a permanent solution.

[johnpierson]

Tracked internally as QNTM-4094

[aparajit-pratap]

This is fixed in: #9242. Closing. Let us know if you still experience issues.